Simplify find_all_refs by always resolving a ast::BindPat

Author: kjeremy

crates/ra_analysis/src/imp.rs

@@ -256,40 +256,24 @@ impl AnalysisImpl {
         let file = root.syntax(file_id);
         let syntax = file.syntax();
 
-        let mut ret = vec![];
-
-        if let Some(binding) = find_node_at_offset::<ast::BindPat>(syntax, offset) {
-            let decl = DeclarationDescriptor::new(binding);
-
-            ret.push((file_id, decl.range));
-
-            ret.extend(decl.find_all_refs().into_iter()
-                .map(|ref_desc| (file_id, ref_desc.range )));
-
-            return ret;
+        // Find the binding associated with the offset
+        let maybe_binding = find_node_at_offset::<ast::BindPat>(syntax, offset)
+            .or_else(||
+                find_node_at_offset::<ast::NameRef>(syntax, offset)
+                    .and_then(|name_ref| resolve_local_name(name_ref))
+                    .and_then(|resolved| find_node_at_offset::<ast::BindPat>(syntax, resolved.1.end())));
+
+        if maybe_binding.is_none() {
+            return Vec::new();
         }
 
-        // Find the symbol we are looking for
-        if let Some(name_ref) = find_node_at_offset::<ast::NameRef>(syntax, offset) {
-
-            // We are only handing local references for now
-            if let Some(resolved) = resolve_local_name(name_ref) {
-
-                ret.push((file_id, resolved.1));
+        let binding = maybe_binding.unwrap();
 
-                if let Some(fn_def) = find_node_at_offset::<ast::FnDef>(syntax, offset) {
+        let decl = DeclarationDescriptor::new(binding);
 
-                    let refs : Vec<_> = fn_def.syntax().descendants()
-                        .filter_map(ast::NameRef::cast)
-                        .filter(|&n: &ast::NameRef| resolve_local_name(n) == Some(resolved.clone()))
-                        .collect();
-
-                    for r in refs {
-                        ret.push((file_id, r.syntax().range()));
-                    }
-                }
-            }
-        }
+        let mut ret = vec![(file_id, decl.range)];
+        ret.extend(decl.find_all_refs().into_iter()
+            .map(|ref_desc| (file_id, ref_desc.range )));
 
         ret
     }