Skip to content

Commit e372bdc

Browse files
Merge #10338
10338: fix: Fix diagnostics in unnamed consts r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
2 parents 8b08666 + 5967f3d commit e372bdc

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

crates/hir/src/lib.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,12 @@ impl Module {
673673

674674
pub fn declarations(self, db: &dyn HirDatabase) -> Vec<ModuleDef> {
675675
let def_map = self.id.def_map(db.upcast());
676-
def_map[self.id.local_id].scope.declarations().map(ModuleDef::from).collect()
676+
let scope = &def_map[self.id.local_id].scope;
677+
scope
678+
.declarations()
679+
.map(ModuleDef::from)
680+
.chain(scope.unnamed_consts().map(|id| ModuleDef::Const(Const::from(id))))
681+
.collect()
677682
}
678683

679684
pub fn impl_defs(self, db: &dyn HirDatabase) -> Vec<Impl> {

crates/ide_diagnostics/src/handlers/missing_ok_or_some_in_tail_expr.rs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,16 @@ static A: Option<()> = {($0)};
185185
r#"
186186
static A: Option<()> = {Some(())};
187187
"#,
188-
)
188+
);
189+
check_fix(
190+
r#"
191+
//- minicore: option, result
192+
const _: Option<()> = {($0)};
193+
"#,
194+
r#"
195+
const _: Option<()> = {Some(())};
196+
"#,
197+
);
189198
}
190199

191200
#[test]

0 commit comments

Comments
 (0)