Rename 'use_last' to 'get_last_with_len'

Author: HarrisonMc555

CHANGELOG.md

@@ -909,6 +909,7 @@ All notable changes to this project will be documented in this file.
 [`for_loop_over_result`]: https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result
 [`forget_copy`]: https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy
 [`forget_ref`]: https://rust-lang.github.io/rust-clippy/master/index.html#forget_ref
+[`get_last_with_len`]: https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len
 [`get_unwrap`]: https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
 [`identity_conversion`]: https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
 [`identity_op`]: https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
@@ -1106,7 +1107,6 @@ All notable changes to this project will be documented in this file.
 [`unused_label`]: https://rust-lang.github.io/rust-clippy/master/index.html#unused_label
 [`unused_unit`]: https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
 [`use_debug`]: https://rust-lang.github.io/rust-clippy/master/index.html#use_debug
-[`use_last`]: https://rust-lang.github.io/rust-clippy/master/index.html#use_last
 [`use_self`]: https://rust-lang.github.io/rust-clippy/master/index.html#use_self
 [`used_underscore_binding`]: https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding
 [`useless_asref`]: https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref

clippy_lints/src/use_last.rs renamed to clippy_lints/src/get_last_with_len.rs

@@ -37,12 +37,12 @@ declare_clippy_lint! {
     /// let x = vec![2, 3, 5];
     /// let last_element = x.last();
     /// ```
-    pub USE_LAST,
+    pub GET_LAST_WITH_LEN,
     complexity,
     "Using `x.get(x.len() - 1)` when `x.last()` is correct and simpler"
 }
 
-declare_lint_pass!(UseLast => [USE_LAST]);
+declare_lint_pass!(UseLast => [GET_LAST_WITH_LEN]);
 
 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UseLast {
     fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
@@ -76,17 +76,18 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UseLast {
             if let LitKind::Int(rhs_value, ..) = rhs_lit.node;
             if rhs_value == 1;
 
-            let mut applicability = Applicability::MachineApplicable;
-            let vec_name = snippet_with_applicability(
-                cx, struct_calling_on.span, "vec", &mut applicability);
 
             then {
+                let mut applicability = Applicability::MachineApplicable;
+                let vec_name = snippet_with_applicability(cx, struct_calling_on.span, "vec",
+                                                          &mut applicability);
+
                 span_lint_and_sugg(
                     cx,
-                    USE_LAST,
+                    GET_LAST_WITH_LEN,
                     expr.span,
-                    &format!("Use `{}.last()` instead of `{}.get({}.len() - 1)`",
-                             vec_name, vec_name, vec_name),
+                    &format!("Use `{}.last()` instead of `{}.get({}.len() - 1)`", vec_name,
+                             vec_name, vec_name),
                     "try",
                     format!("{}.last()", vec_name),
                     applicability,

clippy_lints/src/lib.rs

@@ -185,6 +185,7 @@ pub mod fallible_impl_from;
 pub mod format;
 pub mod formatting;
 pub mod functions;
+pub mod get_last_with_len;
 pub mod identity_conversion;
 pub mod identity_op;
 pub mod if_not_else;
@@ -266,7 +267,6 @@ pub mod unsafe_removed_from_name;
 pub mod unused_io_amount;
 pub mod unused_label;
 pub mod unwrap;
-pub mod use_last;
 pub mod use_self;
 pub mod vec;
 pub mod wildcard_dependencies;
@@ -574,7 +574,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
     reg.register_late_lint_pass(box types::RefToMut);
     reg.register_late_lint_pass(box assertions_on_constants::AssertionsOnConstants);
     reg.register_late_lint_pass(box missing_const_for_fn::MissingConstForFn);
-    reg.register_late_lint_pass(box use_last::UseLast);
     reg.register_late_lint_pass(box transmuting_null::TransmutingNull);
     reg.register_late_lint_pass(box path_buf_push_overwrite::PathBufPushOverwrite);
 
@@ -708,6 +707,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
         formatting::SUSPICIOUS_ELSE_FORMATTING,
         functions::NOT_UNSAFE_PTR_ARG_DEREF,
         functions::TOO_MANY_ARGUMENTS,
+        get_last_with_len::GET_LAST_WITH_LEN,
         identity_conversion::IDENTITY_CONVERSION,
         identity_op::IDENTITY_OP,
         indexing_slicing::OUT_OF_BOUNDS_INDEXING,
@@ -872,7 +872,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
         unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
         unused_io_amount::UNUSED_IO_AMOUNT,
         unused_label::UNUSED_LABEL,
-        use_last::USE_LAST,
         vec::USELESS_VEC,
         write::PRINTLN_EMPTY_STRING,
         write::PRINT_LITERAL,
@@ -980,6 +979,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
         explicit_write::EXPLICIT_WRITE,
         format::USELESS_FORMAT,
         functions::TOO_MANY_ARGUMENTS,
+        get_last_with_len::GET_LAST_WITH_LEN,
         identity_conversion::IDENTITY_CONVERSION,
         identity_op::IDENTITY_OP,
         int_plus_one::INT_PLUS_ONE,
@@ -1035,7 +1035,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
         types::UNNECESSARY_CAST,
         types::VEC_BOX,
         unused_label::UNUSED_LABEL,
-        use_last::USE_LAST,
         zero_div_zero::ZERO_DIVIDED_BY_ZERO,
     ]);
 

tests/ui/use_last.rs renamed to tests/ui/get_last_with_len.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::use_last)]
+#![warn(clippy::get_last_with_len)]
 
 fn dont_use_last() {
     let x = vec![2, 3, 5];

tests/ui/get_last_with_len.stderr

@@ -0,0 +1,10 @@
+error: unknown clippy lint: clippy::get_last_with_len
+  --> $DIR/get_last_with_len.rs:1:9
+   |
+LL | #![warn(clippy::get_last_with_len)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `-D clippy::unknown-clippy-lints` implied by `-D warnings`
+
+error: aborting due to previous error
+