Rename lint to cast_slice_reference_from_raw_parts

Author: clubby789

CHANGELOG.md

@@ -3481,6 +3481,7 @@ Released 2018-09-13
 [`cast_ref_to_mut`]: https://rust-lang.github.io/rust-clippy/master/index.html#cast_ref_to_mut
 [`cast_sign_loss`]: https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
 [`cast_slice_different_sizes`]: https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_different_sizes
+[`cast_slice_reference_from_raw_parts`]: https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_reference_from_raw_parts
 [`char_lit_as_u8`]: https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
 [`chars_last_cmp`]: https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp
 [`chars_next_cmp`]: https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp
@@ -3842,7 +3843,6 @@ Released 2018-09-13
 [`range_plus_one`]: https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
 [`range_step_by_zero`]: https://rust-lang.github.io/rust-clippy/master/index.html#range_step_by_zero
 [`range_zip_with_len`]: https://rust-lang.github.io/rust-clippy/master/index.html#range_zip_with_len
-[`raw_slice_pointer_cast`]: https://rust-lang.github.io/rust-clippy/master/index.html#raw_slice_pointer_cast
 [`rc_buffer`]: https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer
 [`rc_clone_in_vec_init`]: https://rust-lang.github.io/rust-clippy/master/index.html#rc_clone_in_vec_init
 [`rc_mutex`]: https://rust-lang.github.io/rust-clippy/master/index.html#rc_mutex

clippy_lints/src/casts/raw_slice_pointer_cast.rs renamed to clippy_lints/src/casts/cast_slice_reference_from_raw_parts.rs

@@ -1,5 +1,5 @@
 use clippy_utils::diagnostics::span_lint_and_sugg;
-use clippy_utils::source::{snippet, snippet_with_applicability};
+use clippy_utils::source::snippet_with_applicability;
 use clippy_utils::{match_def_path, meets_msrv, msrvs, paths};
 use if_chain::if_chain;
 use rustc_errors::Applicability;
@@ -8,7 +8,7 @@ use rustc_lint::LateContext;
 use rustc_middle::ty::{self, Ty};
 use rustc_semver::RustcVersion;
 
-use super::RAW_SLICE_POINTER_CAST;
+use super::CAST_SLICE_REFERENCE_FROM_RAW_PARTS;
 
 enum RawPartsKind {
     Immutable,
@@ -47,16 +47,17 @@ pub(super) fn check(
             };
             let span = expr.span;
             let mut applicability = Applicability::MachineApplicable;
-            let func_snippet = snippet_with_applicability(cx, fun.span, func, &mut applicability);
-            let ptr = snippet(cx, ptr_arg.span, "ptr");
-            let len = snippet(cx, len_arg.span, "len");
-            span_lint_and_sugg(cx,
-                RAW_SLICE_POINTER_CAST,
+            let ptr = snippet_with_applicability(cx, ptr_arg.span, "ptr", &mut applicability);
+            let len = snippet_with_applicability(cx, len_arg.span, "len", &mut applicability);
+            span_lint_and_sugg(
+                cx,
+                CAST_SLICE_REFERENCE_FROM_RAW_PARTS,
                 span,
-                &format!("casting the result of `{}` to {cast_to}", func_snippet),
+                &format!("casting the result of `{func}` to {cast_to}"),
                 "replace with",
                 format!("core::ptr::slice_{func}({ptr}, {len})"),
-                applicability);
+                applicability
+            );
         }
     }
 }

clippy_lints/src/casts/mod.rs

@@ -13,7 +13,7 @@ mod fn_to_numeric_cast;
 mod fn_to_numeric_cast_any;
 mod fn_to_numeric_cast_with_truncation;
 mod ptr_as_ptr;
-mod raw_slice_pointer_cast;
+mod cast_slice_reference_from_raw_parts;
 mod unnecessary_cast;
 mod utils;
 
@@ -529,9 +529,9 @@ declare_clippy_lint! {
     /// ```
     /// [safety requirements]: https://doc.rust-lang.org/std/slice/fn.from_raw_parts.html#safety
     #[clippy::version = "1.64.0"]
-    pub RAW_SLICE_POINTER_CAST,
+    pub CAST_SLICE_REFERENCE_FROM_RAW_PARTS,
     suspicious,
-    "casting a raw slice to a slice pointer"
+    "casting a slice created from a pointer and length to a slice pointer"
 }
 
 pub struct Casts {
@@ -563,7 +563,7 @@ impl_lint_pass!(Casts => [
     CAST_ENUM_TRUNCATION,
     CAST_ENUM_CONSTRUCTOR,
     CAST_ABS_TO_UNSIGNED,
-    RAW_SLICE_POINTER_CAST
+    CAST_SLICE_REFERENCE_FROM_RAW_PARTS
 ]);
 
 impl<'tcx> LateLintPass<'tcx> for Casts {
@@ -588,7 +588,7 @@ impl<'tcx> LateLintPass<'tcx> for Casts {
             if unnecessary_cast::check(cx, expr, cast_expr, cast_from, cast_to) {
                 return;
             }
-            raw_slice_pointer_cast::check(cx, expr, cast_expr, cast_to, self.msrv);
+            cast_slice_reference_from_raw_parts::check(cx, expr, cast_expr, cast_to, self.msrv);
             fn_to_numeric_cast_any::check(cx, expr, cast_expr, cast_from, cast_to);
             fn_to_numeric_cast::check(cx, expr, cast_expr, cast_from, cast_to);
             fn_to_numeric_cast_with_truncation::check(cx, expr, cast_expr, cast_from, cast_to);

clippy_lints/src/lib.register_all.rs

@@ -28,10 +28,10 @@ store.register_group(true, "clippy::all", Some("clippy_all"), vec![
     LintId::of(casts::CAST_ENUM_TRUNCATION),
     LintId::of(casts::CAST_REF_TO_MUT),
     LintId::of(casts::CAST_SLICE_DIFFERENT_SIZES),
+    LintId::of(casts::CAST_SLICE_REFERENCE_FROM_RAW_PARTS),
     LintId::of(casts::CHAR_LIT_AS_U8),
     LintId::of(casts::FN_TO_NUMERIC_CAST),
     LintId::of(casts::FN_TO_NUMERIC_CAST_WITH_TRUNCATION),
-    LintId::of(casts::RAW_SLICE_POINTER_CAST),
     LintId::of(casts::UNNECESSARY_CAST),
     LintId::of(collapsible_if::COLLAPSIBLE_ELSE_IF),
     LintId::of(collapsible_if::COLLAPSIBLE_IF),

clippy_lints/src/lib.register_lints.rs

@@ -81,12 +81,12 @@ store.register_lints(&[
     casts::CAST_REF_TO_MUT,
     casts::CAST_SIGN_LOSS,
     casts::CAST_SLICE_DIFFERENT_SIZES,
+    casts::CAST_SLICE_REFERENCE_FROM_RAW_PARTS,
     casts::CHAR_LIT_AS_U8,
     casts::FN_TO_NUMERIC_CAST,
     casts::FN_TO_NUMERIC_CAST_ANY,
     casts::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
     casts::PTR_AS_PTR,
-    casts::RAW_SLICE_POINTER_CAST,
     casts::UNNECESSARY_CAST,
     checked_conversions::CHECKED_CONVERSIONS,
     cognitive_complexity::COGNITIVE_COMPLEXITY,

clippy_lints/src/lib.register_suspicious.rs

@@ -11,7 +11,7 @@ store.register_group(true, "clippy::suspicious", Some("clippy_suspicious"), vec!
     LintId::of(casts::CAST_ABS_TO_UNSIGNED),
     LintId::of(casts::CAST_ENUM_CONSTRUCTOR),
     LintId::of(casts::CAST_ENUM_TRUNCATION),
-    LintId::of(casts::RAW_SLICE_POINTER_CAST),
+    LintId::of(casts::CAST_SLICE_REFERENCE_FROM_RAW_PARTS),
     LintId::of(crate_in_macro_def::CRATE_IN_MACRO_DEF),
     LintId::of(drop_forget_ref::DROP_NON_DROP),
     LintId::of(drop_forget_ref::FORGET_NON_DROP),

tests/ui/cast_raw_slice_pointer_cast.fixed

@@ -1,5 +1,5 @@
 // run-rustfix
-#![warn(clippy::raw_slice_pointer_cast)]
+#![warn(clippy::cast_slice_reference_from_raw_parts)]
 
 #[allow(unused_imports, unused_unsafe)]
 fn main() {

tests/ui/cast_raw_slice_pointer_cast.rs

@@ -1,5 +1,5 @@
 // run-rustfix
-#![warn(clippy::raw_slice_pointer_cast)]
+#![warn(clippy::cast_slice_reference_from_raw_parts)]
 
 #[allow(unused_imports, unused_unsafe)]
 fn main() {

tests/ui/cast_raw_slice_pointer_cast.stderr

@@ -1,42 +1,42 @@
-error: casting the result of `std::slice::from_raw_parts` to *const [u8]
+error: casting the result of `from_raw_parts` to *const [u8]
   --> $DIR/cast_raw_slice_pointer_cast.rs:9:35
    |
 LL |     let _: *const [u8] = unsafe { std::slice::from_raw_parts(ptr, 1) as *const [u8] };
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts(ptr, 1)`
    |
-   = note: `-D clippy::raw-slice-pointer-cast` implied by `-D warnings`
+   = note: `-D clippy::cast-slice-reference-from-raw-parts` implied by `-D warnings`
 
-error: casting the result of `std::slice::from_raw_parts_mut` to *mut [u8]
+error: casting the result of `from_raw_parts_mut` to *mut [u8]
   --> $DIR/cast_raw_slice_pointer_cast.rs:10:35
    |
 LL |     let _: *const [u8] = unsafe { std::slice::from_raw_parts_mut(mptr, 1) as *mut [u8] };
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts_mut(mptr, 1)`
 
-error: casting the result of `std::slice::from_raw_parts` to *const [u8]
+error: casting the result of `from_raw_parts` to *const [u8]
   --> $DIR/cast_raw_slice_pointer_cast.rs:11:26
    |
 LL |     let _: *const [u8] = unsafe { std::slice::from_raw_parts(ptr, 1) } as *const [u8];
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts(ptr, 1)`
 
-error: casting the result of `slice::from_raw_parts` to *const [u8]
+error: casting the result of `from_raw_parts` to *const [u8]
   --> $DIR/cast_raw_slice_pointer_cast.rs:14:30
    |
 LL |         let _: *const [u8] = unsafe { slice::from_raw_parts(ptr, 1) } as *const [u8];
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts(ptr, 1)`
 
-error: casting the result of `one::from_raw_parts` to *const [u8]
+error: casting the result of `from_raw_parts` to *const [u8]
   --> $DIR/cast_raw_slice_pointer_cast.rs:16:30
    |
 LL |         let _: *const [u8] = unsafe { one::from_raw_parts(ptr, 1) } as *const [u8];
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts(ptr, 1)`
 
-error: casting the result of `slice::from_raw_parts` to *const [u8]
+error: casting the result of `from_raw_parts` to *const [u8]
   --> $DIR/cast_raw_slice_pointer_cast.rs:20:30
    |
 LL |         let _: *const [u8] = unsafe { slice::from_raw_parts(ptr, 1) } as *const [u8];
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts(ptr, 1)`
 
-error: casting the result of `one::from_raw_parts` to *const [u8]
+error: casting the result of `from_raw_parts` to *const [u8]
   --> $DIR/cast_raw_slice_pointer_cast.rs:22:30
    |
 LL |         let _: *const [u8] = unsafe { one::from_raw_parts(ptr, 1) } as *const [u8];