Modify tests to account for the new allow-by-default needless_pass_by_ref_mut

blyxyas · blyxyas · commit 2705d627c275 · 2023-10-02T14:13:41.000+02:00
diff --git a/tests/ui/infinite_loop.rs b/tests/ui/infinite_loop.rs
@@ -1,4 +1,5 @@
 //@no-rustfix
+#![warn(clippy::needless_pass_by_ref_mut)]
 
 fn fn_val(i: i32) -> i32 {
     unimplemented!()
diff --git a/tests/ui/infinite_loop.stderr b/tests/ui/infinite_loop.stderr
@@ -1,5 +1,5 @@
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:24:11
+  --> $DIR/infinite_loop.rs:25:11
    |
 LL |     while y < 10 {
    |           ^^^^^^
@@ -8,71 +8,71 @@ LL |     while y < 10 {
    = note: `#[deny(clippy::while_immutable_condition)]` on by default
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:31:11
+  --> $DIR/infinite_loop.rs:32:11
    |
 LL |     while y < 10 && x < 3 {
    |           ^^^^^^^^^^^^^^^
    |
    = note: this may lead to an infinite or to a never running loop
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:40:11
+  --> $DIR/infinite_loop.rs:41:11
    |
 LL |     while !cond {
    |           ^^^^^
    |
    = note: this may lead to an infinite or to a never running loop
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:86:11
+  --> $DIR/infinite_loop.rs:87:11
    |
 LL |     while i < 3 {
    |           ^^^^^
    |
    = note: this may lead to an infinite or to a never running loop
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:93:11
+  --> $DIR/infinite_loop.rs:94:11
    |
 LL |     while i < 3 && j > 0 {
    |           ^^^^^^^^^^^^^^
    |
    = note: this may lead to an infinite or to a never running loop
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:99:11
+  --> $DIR/infinite_loop.rs:100:11
    |
 LL |     while i < 3 {
    |           ^^^^^
    |
    = note: this may lead to an infinite or to a never running loop
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:116:11
+  --> $DIR/infinite_loop.rs:117:11
    |
 LL |     while i < 3 {
    |           ^^^^^
    |
    = note: this may lead to an infinite or to a never running loop
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:123:11
+  --> $DIR/infinite_loop.rs:124:11
    |
 LL |     while i < 3 {
    |           ^^^^^
    |
    = note: this may lead to an infinite or to a never running loop
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:191:15
+  --> $DIR/infinite_loop.rs:192:15
    |
 LL |         while self.count < n {
    |               ^^^^^^^^^^^^^^
    |
    = note: this may lead to an infinite or to a never running loop
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:201:11
+  --> $DIR/infinite_loop.rs:202:11
    |
 LL |     while y < 10 {
    |           ^^^^^^
@@ -82,7 +82,7 @@ LL |     while y < 10 {
    = help: rewrite it as `if cond { loop { } }`
 
 error: variables in the condition are not mutated in the loop body
-  --> $DIR/infinite_loop.rs:210:11
+  --> $DIR/infinite_loop.rs:211:11
    |
 LL |     while y < 10 {
    |           ^^^^^^
@@ -92,7 +92,7 @@ LL |     while y < 10 {
    = help: rewrite it as `if cond { loop { } }`
 
 error: this argument is a mutable reference, but not used mutably
-  --> $DIR/infinite_loop.rs:9:17
+  --> $DIR/infinite_loop.rs:10:17
    |
 LL | fn fn_mutref(i: &mut i32) {
    |                 ^^^^^^^^ help: consider changing to: `&i32`
diff --git a/tests/ui/let_underscore_future.rs b/tests/ui/let_underscore_future.rs
@@ -1,3 +1,4 @@
+#![warn(clippy::needless_pass_by_ref_mut)]
 use std::future::Future;
 //@no-rustfix
 async fn some_async_fn() {}
diff --git a/tests/ui/let_underscore_future.stderr b/tests/ui/let_underscore_future.stderr
@@ -1,5 +1,5 @@
 error: non-binding `let` on a future
-  --> $DIR/let_underscore_future.rs:16:5
+  --> $DIR/let_underscore_future.rs:17:5
    |
 LL |     let _ = some_async_fn();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^
@@ -9,23 +9,23 @@ LL |     let _ = some_async_fn();
    = help: to override `-D warnings` add `#[allow(clippy::let_underscore_future)]`
 
 error: non-binding `let` on a future
-  --> $DIR/let_underscore_future.rs:18:5
+  --> $DIR/let_underscore_future.rs:19:5
    |
 LL |     let _ = custom();
    |     ^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
 
 error: non-binding `let` on a future
-  --> $DIR/let_underscore_future.rs:23:5
+  --> $DIR/let_underscore_future.rs:24:5
    |
 LL |     let _ = future;
    |     ^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
 
 error: this argument is a mutable reference, but not used mutably
-  --> $DIR/let_underscore_future.rs:11:35
+  --> $DIR/let_underscore_future.rs:12:35
    |
 LL | fn do_something_to_future(future: &mut impl Future<Output = ()>) {}
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&impl Future<Output = ()>`
diff --git a/tests/ui/mut_key.rs b/tests/ui/mut_key.rs
@@ -1,3 +1,4 @@
+#![warn(clippy::needless_pass_by_ref_mut)]
 use std::cell::Cell;
 use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet};
 use std::hash::{Hash, Hasher};
diff --git a/tests/ui/mut_key.stderr b/tests/ui/mut_key.stderr
@@ -1,5 +1,5 @@
 error: mutable key type
-  --> $DIR/mut_key.rs:31:32
+  --> $DIR/mut_key.rs:32:32
    |
 LL | fn should_not_take_this_arg(m: &mut HashMap<Key, usize>, _n: usize) -> HashSet<Key> {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^
@@ -8,103 +8,103 @@ LL | fn should_not_take_this_arg(m: &mut HashMap<Key, usize>, _n: usize) -> Hash
    = help: to override `-D warnings` add `#[allow(clippy::mutable_key_type)]`
 
 error: mutable key type
-  --> $DIR/mut_key.rs:31:72
+  --> $DIR/mut_key.rs:32:72
    |
 LL | fn should_not_take_this_arg(m: &mut HashMap<Key, usize>, _n: usize) -> HashSet<Key> {
    |                                                                        ^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:37:5
+  --> $DIR/mut_key.rs:38:5
    |
 LL |     let _other: HashMap<Key, bool> = HashMap::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:65:22
+  --> $DIR/mut_key.rs:66:22
    |
 LL | fn tuples_bad<U>(_m: &mut HashMap<(Key, U), bool>) {}
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:78:5
+  --> $DIR/mut_key.rs:79:5
    |
 LL |     let _map = HashMap::<Cell<usize>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:80:5
+  --> $DIR/mut_key.rs:81:5
    |
 LL |     let _map = HashMap::<&mut Cell<usize>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:82:5
+  --> $DIR/mut_key.rs:83:5
    |
 LL |     let _map = HashMap::<&mut usize, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:85:5
+  --> $DIR/mut_key.rs:86:5
    |
 LL |     let _map = HashMap::<Vec<Cell<usize>>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:87:5
+  --> $DIR/mut_key.rs:88:5
    |
 LL |     let _map = HashMap::<BTreeMap<Cell<usize>, ()>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:89:5
+  --> $DIR/mut_key.rs:90:5
    |
 LL |     let _map = HashMap::<BTreeMap<(), Cell<usize>>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:91:5
+  --> $DIR/mut_key.rs:92:5
    |
 LL |     let _map = HashMap::<BTreeSet<Cell<usize>>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:93:5
+  --> $DIR/mut_key.rs:94:5
    |
 LL |     let _map = HashMap::<Option<Cell<usize>>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:95:5
+  --> $DIR/mut_key.rs:96:5
    |
 LL |     let _map = HashMap::<Option<Vec<Cell<usize>>>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:97:5
+  --> $DIR/mut_key.rs:98:5
    |
 LL |     let _map = HashMap::<Result<&mut usize, ()>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:100:5
+  --> $DIR/mut_key.rs:101:5
    |
 LL |     let _map = HashMap::<Box<Cell<usize>>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:102:5
+  --> $DIR/mut_key.rs:103:5
    |
 LL |     let _map = HashMap::<Rc<Cell<usize>>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: mutable key type
-  --> $DIR/mut_key.rs:104:5
+  --> $DIR/mut_key.rs:105:5
    |
 LL |     let _map = HashMap::<Arc<Cell<usize>>, usize>::new();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: this argument is a mutable reference, but not used mutably
-  --> $DIR/mut_key.rs:31:32
+  --> $DIR/mut_key.rs:32:32
    |
 LL | fn should_not_take_this_arg(m: &mut HashMap<Key, usize>, _n: usize) -> HashSet<Key> {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&HashMap<Key, usize>`
diff --git a/tests/ui/mut_reference.rs b/tests/ui/mut_reference.rs
@@ -1,4 +1,5 @@
 #![allow(unused_variables, dead_code)]
+#![warn(clippy::needless_pass_by_ref_mut)]
 //@no-rustfix
 fn takes_an_immutable_reference(a: &i32) {}
 fn takes_a_mutable_reference(a: &mut i32) {}
diff --git a/tests/ui/mut_reference.stderr b/tests/ui/mut_reference.stderr
@@ -1,5 +1,5 @@
 error: the function `takes_an_immutable_reference` doesn't need a mutable reference
-  --> $DIR/mut_reference.rs:32:34
+  --> $DIR/mut_reference.rs:33:34
    |
 LL |     takes_an_immutable_reference(&mut 42);
    |                                  ^^^^^^^
@@ -8,19 +8,19 @@ LL |     takes_an_immutable_reference(&mut 42);
    = help: to override `-D warnings` add `#[allow(clippy::unnecessary_mut_passed)]`
 
 error: the function `as_ptr` doesn't need a mutable reference
-  --> $DIR/mut_reference.rs:36:12
+  --> $DIR/mut_reference.rs:37:12
    |
 LL |     as_ptr(&mut 42);
    |            ^^^^^^^
 
 error: the method `takes_an_immutable_reference` doesn't need a mutable reference
-  --> $DIR/mut_reference.rs:41:44
+  --> $DIR/mut_reference.rs:42:44
    |
 LL |     my_struct.takes_an_immutable_reference(&mut 42);
    |                                            ^^^^^^^
 
 error: this argument is a mutable reference, but not used mutably
-  --> $DIR/mut_reference.rs:24:44
+  --> $DIR/mut_reference.rs:25:44
    |
 LL |     fn takes_a_mutable_reference(&self, a: &mut i32) {}
    |                                            ^^^^^^^^ help: consider changing to: `&i32`
diff --git a/tests/ui/needless_pass_by_ref_mut.rs b/tests/ui/needless_pass_by_ref_mut.rs
@@ -1,4 +1,5 @@
 #![allow(clippy::if_same_then_else, clippy::no_effect, clippy::redundant_closure_call)]
+#![warn(clippy::needless_pass_by_ref_mut)]
 #![feature(lint_reasons)]
 //@no-rustfix
 use std::ptr::NonNull;
diff --git a/tests/ui/needless_pass_by_ref_mut.stderr b/tests/ui/needless_pass_by_ref_mut.stderr
diff --git a/tests/ui/should_impl_trait/method_list_2.rs b/tests/ui/should_impl_trait/method_list_2.rs
diff --git a/tests/ui/slow_vector_initialization.rs b/tests/ui/slow_vector_initialization.rs
diff --git a/tests/ui/slow_vector_initialization.stderr b/tests/ui/slow_vector_initialization.stderr

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`//@no-rustfix`
	`2`	`+#![warn(clippy::needless_pass_by_ref_mut)]`
`2`	`3`
`3`	`4`	`fn fn_val(i: i32) -> i32 {`
`4`	`5`	`unimplemented!()`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`error: variables in the condition are not mutated in the loop body`
`2`		`- --> $DIR/infinite_loop.rs:24:11`
	`2`	`+ --> $DIR/infinite_loop.rs:25:11`
`3`	`3`	`\|`
`4`	`4`	`LL \| while y < 10 {`
`5`	`5`	`\| ^^^^^^`
`@@ -8,71 +8,71 @@ LL \| while y < 10 {`
`8`	`8`	= note: `#[deny(clippy::while_immutable_condition)]` on by default
`9`	`9`
`10`	`10`	`error: variables in the condition are not mutated in the loop body`
`11`		`- --> $DIR/infinite_loop.rs:31:11`
	`11`	`+ --> $DIR/infinite_loop.rs:32:11`
`12`	`12`	`\|`
`13`	`13`	`LL \| while y < 10 && x < 3 {`
`14`	`14`	`\| ^^^^^^^^^^^^^^^`
`15`	`15`	`\|`
`16`	`16`	`= note: this may lead to an infinite or to a never running loop`
`17`	`17`
`18`	`18`	`error: variables in the condition are not mutated in the loop body`
`19`		`- --> $DIR/infinite_loop.rs:40:11`
	`19`	`+ --> $DIR/infinite_loop.rs:41:11`
`20`	`20`	`\|`
`21`	`21`	`LL \| while !cond {`
`22`	`22`	`\| ^^^^^`
`23`	`23`	`\|`
`24`	`24`	`= note: this may lead to an infinite or to a never running loop`
`25`	`25`
`26`	`26`	`error: variables in the condition are not mutated in the loop body`
`27`		`- --> $DIR/infinite_loop.rs:86:11`
	`27`	`+ --> $DIR/infinite_loop.rs:87:11`
`28`	`28`	`\|`
`29`	`29`	`LL \| while i < 3 {`
`30`	`30`	`\| ^^^^^`
`31`	`31`	`\|`
`32`	`32`	`= note: this may lead to an infinite or to a never running loop`
`33`	`33`
`34`	`34`	`error: variables in the condition are not mutated in the loop body`
`35`		`- --> $DIR/infinite_loop.rs:93:11`
	`35`	`+ --> $DIR/infinite_loop.rs:94:11`
`36`	`36`	`\|`
`37`	`37`	`LL \| while i < 3 && j > 0 {`
`38`	`38`	`\| ^^^^^^^^^^^^^^`
`39`	`39`	`\|`
`40`	`40`	`= note: this may lead to an infinite or to a never running loop`
`41`	`41`
`42`	`42`	`error: variables in the condition are not mutated in the loop body`
`43`		`- --> $DIR/infinite_loop.rs:99:11`
	`43`	`+ --> $DIR/infinite_loop.rs:100:11`
`44`	`44`	`\|`
`45`	`45`	`LL \| while i < 3 {`
`46`	`46`	`\| ^^^^^`
`47`	`47`	`\|`
`48`	`48`	`= note: this may lead to an infinite or to a never running loop`
`49`	`49`
`50`	`50`	`error: variables in the condition are not mutated in the loop body`
`51`		`- --> $DIR/infinite_loop.rs:116:11`
	`51`	`+ --> $DIR/infinite_loop.rs:117:11`
`52`	`52`	`\|`
`53`	`53`	`LL \| while i < 3 {`
`54`	`54`	`\| ^^^^^`
`55`	`55`	`\|`
`56`	`56`	`= note: this may lead to an infinite or to a never running loop`
`57`	`57`
`58`	`58`	`error: variables in the condition are not mutated in the loop body`
`59`		`- --> $DIR/infinite_loop.rs:123:11`
	`59`	`+ --> $DIR/infinite_loop.rs:124:11`
`60`	`60`	`\|`
`61`	`61`	`LL \| while i < 3 {`
`62`	`62`	`\| ^^^^^`
`63`	`63`	`\|`
`64`	`64`	`= note: this may lead to an infinite or to a never running loop`
`65`	`65`
`66`	`66`	`error: variables in the condition are not mutated in the loop body`
`67`		`- --> $DIR/infinite_loop.rs:191:15`
	`67`	`+ --> $DIR/infinite_loop.rs:192:15`
`68`	`68`	`\|`
`69`	`69`	`LL \| while self.count < n {`
`70`	`70`	`\| ^^^^^^^^^^^^^^`
`71`	`71`	`\|`
`72`	`72`	`= note: this may lead to an infinite or to a never running loop`
`73`	`73`
`74`	`74`	`error: variables in the condition are not mutated in the loop body`
`75`		`- --> $DIR/infinite_loop.rs:201:11`
	`75`	`+ --> $DIR/infinite_loop.rs:202:11`
`76`	`76`	`\|`
`77`	`77`	`LL \| while y < 10 {`
`78`	`78`	`\| ^^^^^^`
`@@ -82,7 +82,7 @@ LL \| while y < 10 {`
`82`	`82`	= help: rewrite it as `if cond { loop { } }`
`83`	`83`
`84`	`84`	`error: variables in the condition are not mutated in the loop body`
`85`		`- --> $DIR/infinite_loop.rs:210:11`
	`85`	`+ --> $DIR/infinite_loop.rs:211:11`
`86`	`86`	`\|`
`87`	`87`	`LL \| while y < 10 {`
`88`	`88`	`\| ^^^^^^`
`@@ -92,7 +92,7 @@ LL \| while y < 10 {`
`92`	`92`	= help: rewrite it as `if cond { loop { } }`
`93`	`93`
`94`	`94`	`error: this argument is a mutable reference, but not used mutably`
`95`		`- --> $DIR/infinite_loop.rs:9:17`
	`95`	`+ --> $DIR/infinite_loop.rs:10:17`
`96`	`96`	`\|`
`97`	`97`	`LL \| fn fn_mutref(i: &mut i32) {`
`98`	`98`	\| ^^^^^^^^ help: consider changing to: `&i32`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#![warn(clippy::needless_pass_by_ref_mut)]`
`1`	`2`	`use std::future::Future;`
`2`	`3`	`//@no-rustfix`
`3`	`4`	`async fn some_async_fn() {}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error: non-binding `let` on a future
`2`		`- --> $DIR/let_underscore_future.rs:16:5`
	`2`	`+ --> $DIR/let_underscore_future.rs:17:5`
`3`	`3`	`\|`
`4`	`4`	`LL \| let _ = some_async_fn();`
`5`	`5`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^`
`@@ -9,23 +9,23 @@ LL \| let _ = some_async_fn();`
`9`	`9`	= help: to override `-D warnings` add `#[allow(clippy::let_underscore_future)]`
`10`	`10`
`11`	`11`	error: non-binding `let` on a future
`12`		`- --> $DIR/let_underscore_future.rs:18:5`
	`12`	`+ --> $DIR/let_underscore_future.rs:19:5`
`13`	`13`	`\|`
`14`	`14`	`LL \| let _ = custom();`
`15`	`15`	`\| ^^^^^^^^^^^^^^^^^`
`16`	`16`	`\|`
`17`	`17`	= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
`18`	`18`
`19`	`19`	error: non-binding `let` on a future
`20`		`- --> $DIR/let_underscore_future.rs:23:5`
	`20`	`+ --> $DIR/let_underscore_future.rs:24:5`
`21`	`21`	`\|`
`22`	`22`	`LL \| let _ = future;`
`23`	`23`	`\| ^^^^^^^^^^^^^^^`
`24`	`24`	`\|`
`25`	`25`	= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
`26`	`26`
`27`	`27`	`error: this argument is a mutable reference, but not used mutably`
`28`		`- --> $DIR/let_underscore_future.rs:11:35`
	`28`	`+ --> $DIR/let_underscore_future.rs:12:35`
`29`	`29`	`\|`
`30`	`30`	`LL \| fn do_something_to_future(future: &mut impl Future<Output = ()>) {}`
`31`	`31`	\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&impl Future<Output = ()>`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#![warn(clippy::needless_pass_by_ref_mut)]`
`1`	`2`	`use std::cell::Cell;`
`2`	`3`	`use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet};`
`3`	`4`	`use std::hash::{Hash, Hasher};`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#![allow(unused_variables, dead_code)]`
	`2`	`+#![warn(clippy::needless_pass_by_ref_mut)]`
`2`	`3`	`//@no-rustfix`
`3`	`4`	`fn takes_an_immutable_reference(a: &i32) {}`
`4`	`5`	`fn takes_a_mutable_reference(a: &mut i32) {}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#![allow(clippy::if_same_then_else, clippy::no_effect, clippy::redundant_closure_call)]`
	`2`	`+#![warn(clippy::needless_pass_by_ref_mut)]`
`2`	`3`	`#![feature(lint_reasons)]`
`3`	`4`	`//@no-rustfix`
`4`	`5`	`use std::ptr::NonNull;`