Fix incorrect uses of bitwise_bool in dogfood

Author: arya-k

clippy_lints/src/loops/needless_range_loop.rs

@@ -107,7 +107,7 @@ pub(super) fn check<'tcx>(
                                 take_expr = left;
                             }
 
-                            end_is_start_plus_val = start_equal_left | start_equal_right;
+                            end_is_start_plus_val = start_equal_left || start_equal_right;
                         }
                     }
 

clippy_lints/src/methods/unnecessary_filter_map.rs

@@ -82,7 +82,7 @@ fn check_expression<'tcx>(cx: &LateContext<'tcx>, arg_id: hir::HirId, expr: &'tc
         hir::ExprKind::If(_, if_arm, Some(else_arm)) => {
             let if_check = check_expression(cx, arg_id, if_arm);
             let else_check = check_expression(cx, arg_id, else_arm);
-            (if_check.0 | else_check.0, if_check.1 | else_check.1)
+            (if_check.0 || else_check.0, if_check.1 || else_check.1)
         },
         hir::ExprKind::Path(path) if is_lang_ctor(cx, path, OptionNone) => (false, true),
         _ => (true, true),

clippy_lints/src/needless_bool.rs

@@ -165,7 +165,7 @@ impl<'tcx> LateLintPass<'tcx> for BoolComparison {
                     )),
                     ignore_case,
                     Some((
-                        |l: Sugg<'_>, r: Sugg<'_>| (!l).bit_and(&r),
+                        |l: Sugg<'_>, r: Sugg<'_>| (!l).and(&r),
                         "order comparisons between booleans can be simplified",
                     )),
                 ),
@@ -180,7 +180,7 @@ impl<'tcx> LateLintPass<'tcx> for BoolComparison {
                     ignore_case,
                     Some((|h| h, "greater than checks against false are unnecessary")),
                     Some((
-                        |l: Sugg<'_>, r: Sugg<'_>| l.bit_and(&(!r)),
+                        |l: Sugg<'_>, r: Sugg<'_>| l.and(&(!r)),
                         "order comparisons between booleans can be simplified",
                     )),
                 ),

clippy_lints/src/use_self.rs

@@ -236,7 +236,7 @@ impl<'tcx> LateLintPass<'tcx> for UseSelf {
     }
 
     fn check_ty(&mut self, cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>) {
-        if in_macro(hir_ty.span) | in_impl(cx, hir_ty) | !meets_msrv(self.msrv.as_ref(), &USE_SELF_MSRV) {
+        if in_macro(hir_ty.span) || in_impl(cx, hir_ty) || !meets_msrv(self.msrv.as_ref(), &USE_SELF_MSRV) {
             return;
         }
 
@@ -288,7 +288,7 @@ impl<'tcx> LateLintPass<'tcx> for UseSelf {
             }
         }
 
-        if in_macro(expr.span) | !meets_msrv(self.msrv.as_ref(), &USE_SELF_MSRV) {
+        if in_macro(expr.span) || !meets_msrv(self.msrv.as_ref(), &USE_SELF_MSRV) {
             return;
         }
 

tests/ui/bool_comparison.fixed

@@ -65,12 +65,12 @@ fn main() {
         "no"
     };
     let y = true;
-    if !x & y {
+    if !x && y {
         "yes"
     } else {
         "no"
     };
-    if x & !y {
+    if x && !y {
         "yes"
     } else {
         "no"

tests/ui/bool_comparison.stderr

@@ -76,13 +76,13 @@ error: order comparisons between booleans can be simplified
   --> $DIR/bool_comparison.rs:68:8
    |
 LL |     if x < y {
-   |        ^^^^^ help: try simplifying it as shown: `!x & y`
+   |        ^^^^^ help: try simplifying it as shown: `!x && y`
 
 error: order comparisons between booleans can be simplified
   --> $DIR/bool_comparison.rs:73:8
    |
 LL |     if x > y {
-   |        ^^^^^ help: try simplifying it as shown: `x & !y`
+   |        ^^^^^ help: try simplifying it as shown: `x && !y`
 
 error: this comparison might be written more concisely
   --> $DIR/bool_comparison.rs:121:8