Prevent linting on zero values

Author: cgm616

clippy_lints/src/xor_used_as_pow.rs

@@ -130,16 +130,11 @@ fn report_with_ident(cx: &LateContext<'_>, lhs: u128, rhs: &QPath<'_>, span: Spa
 }
 
 fn report_with_lit(cx: &LateContext<'_>, lhs: u128, rhs: u128, span: Span) {
-    if rhs > 127 {
+    if rhs > 127 || rhs == 0 {
         return;
     }
     match lhs {
         2 => {
-            if rhs == 0 {
-                report_pow_of_two(cx, format!("1"), span);
-                return;
-            }
-
             let lhs_str = if rhs <= 31 {
                 "1_u32"
             } else if rhs <= 63 {

tests/ui/xor_used_as_pow.fixed

@@ -19,13 +19,12 @@ fn main() {
     let _ = 10 ^ 0b0101; // rhs binary
     let _ = 2 ^ 0o1; // rhs octal
     let _ = 10 ^ -18; // negative rhs
+    let _ = 2 ^ 0; // zero rhs
 
     // These should fail
     let _ = 1_u32 << 3;
     let _ = 10 ^ 4;
     let _ = 1_u64 << 32;
-    let _ = 1;
-    let _ = 10 ^ 0;
     {
         let x = 15;
         let _ = 1 << x;

tests/ui/xor_used_as_pow.rs

@@ -19,13 +19,12 @@ fn main() {
     let _ = 10 ^ 0b0101; // rhs binary
     let _ = 2 ^ 0o1; // rhs octal
     let _ = 10 ^ -18; // negative rhs
+    let _ = 2 ^ 0; // zero rhs
 
     // These should fail
     let _ = 2 ^ 3;
     let _ = 10 ^ 4;
     let _ = 2 ^ 32;
-    let _ = 2 ^ 0;
-    let _ = 10 ^ 0;
     {
         let x = 15;
         let _ = 2 ^ x;

tests/ui/xor_used_as_pow.stderr

@@ -1,52 +1,38 @@
 error: it appears you are trying to get a power of two, but `^` is not an exponentiation operator
-  --> $DIR/xor_used_as_pow.rs:24:13
+  --> $DIR/xor_used_as_pow.rs:25:13
    |
 LL |     let _ = 2 ^ 3;
    |             ^^^^^ help: use a bitshift or constant instead: `1_u32 << 3`
    |
    = note: `-D clippy::xor-used-as-pow` implied by `-D warnings`
 
 error: `^` is not an exponentiation operator but appears to have been used as one
-  --> $DIR/xor_used_as_pow.rs:25:13
+  --> $DIR/xor_used_as_pow.rs:26:13
    |
 LL |     let _ = 10 ^ 4;
    |             ^^^^^^
    |
    = help: did you mean to use .pow()?
 
 error: it appears you are trying to get a power of two, but `^` is not an exponentiation operator
-  --> $DIR/xor_used_as_pow.rs:26:13
+  --> $DIR/xor_used_as_pow.rs:27:13
    |
 LL |     let _ = 2 ^ 32;
    |             ^^^^^^ help: use a bitshift or constant instead: `1_u64 << 32`
 
 error: it appears you are trying to get a power of two, but `^` is not an exponentiation operator
-  --> $DIR/xor_used_as_pow.rs:27:13
-   |
-LL |     let _ = 2 ^ 0;
-   |             ^^^^^ help: use a bitshift or constant instead: `1`
-
-error: `^` is not an exponentiation operator but appears to have been used as one
-  --> $DIR/xor_used_as_pow.rs:28:13
-   |
-LL |     let _ = 10 ^ 0;
-   |             ^^^^^^
-   |
-   = help: did you mean to use .pow()?
-
-error: it appears you are trying to get a power of two, but `^` is not an exponentiation operator
-  --> $DIR/xor_used_as_pow.rs:31:17
+  --> $DIR/xor_used_as_pow.rs:30:17
    |
 LL |         let _ = 2 ^ x;
    |                 ^^^^^ help: use a bitshift or constant instead: `1 << x`
 
 error: `^` is not an exponentiation operator but appears to have been used as one
-  --> $DIR/xor_used_as_pow.rs:32:17
+  --> $DIR/xor_used_as_pow.rs:31:17
    |
 LL |         let _ = 10 ^ x;
    |                 ^^^^^^
    |
    = help: did you mean to use .pow()?
 
-error: aborting due to 7 previous errors
+error: aborting due to 5 previous errors