Skip to content

Commit ae787d9

Browse files
committed
fix missing a semicolon
1 parent 0d89372 commit ae787d9

File tree

8 files changed

+34
-7
lines changed

8 files changed

+34
-7
lines changed

clippy_lints/src/utils/author.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ impl<'tcx> Visitor<'tcx> for PrintVisitor {
639639
println!("Local(ref {}) = {};", local_pat, current);
640640
if let Some(ref init) = local.init {
641641
let init_pat = self.next("init");
642-
println!(" if let Some(ref {}) = {}.init", init_pat, local_pat);
642+
println!(" if let Some(ref {}) = {}.init;", init_pat, local_pat);
643643
self.current = init_pat;
644644
self.visit_expr(init);
645645
}

main

253 KB
Binary file not shown.

tests/ui/author.stdout

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
if_chain! {
22
if let StmtKind::Local(ref local) = stmt.node;
3-
if let Some(ref init) = local.init
3+
if let Some(ref init) = local.init;
44
if let ExprKind::Cast(ref expr, ref cast_ty) = init.node;
55
if let TyKind::Path(ref qp) = cast_ty.node;
66
if match_qpath(qp, &["char"]);

tests/ui/author/call.stdout

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
if_chain! {
22
if let StmtKind::Local(ref local) = stmt.node;
3-
if let Some(ref init) = local.init
3+
if let Some(ref init) = local.init;
44
if let ExprKind::Call(ref func, ref args) = init.node;
55
if let ExprKind::Path(ref path) = func.node;
66
if match_qpath(path, &["{{root}}", "std", "cmp", "min"]);

tests/ui/author/for_loop.stdout

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
if_chain! {
22
if let ExprKind::Block(ref block) = expr.node;
33
if let StmtKind::Local(ref local) = block.node;
4-
if let Some(ref init) = local.init
4+
if let Some(ref init) = local.init;
55
if let ExprKind::Match(ref expr, ref arms, MatchSource::ForLoopDesugar) = init.node;
66
if let ExprKind::Call(ref func, ref args) = expr.node;
77
if let ExprKind::Path(ref path) = func.node;
@@ -41,15 +41,15 @@ if_chain! {
4141
if let PatKind::Path(ref path7) = arms1[1].pats[0].node;
4242
if match_qpath(path7, &["{{root}}", "std", "option", "Option", "None"]);
4343
if let StmtKind::Local(ref local2) = path7.node;
44-
if let Some(ref init1) = local2.init
44+
if let Some(ref init1) = local2.init;
4545
if let ExprKind::Path(ref path8) = init1.node;
4646
if match_qpath(path8, &["__next"]);
4747
if let PatKind::Binding(BindingAnnotation::Unannotated, _, name1, None) = local2.pat.node;
4848
if name1.node.as_str() == "y";
4949
if let StmtKind::Expr(ref e1, _) = local2.pat.node
5050
if let ExprKind::Block(ref block1) = e1.node;
5151
if let StmtKind::Local(ref local3) = block1.node;
52-
if let Some(ref init2) = local3.init
52+
if let Some(ref init2) = local3.init;
5353
if let ExprKind::Path(ref path9) = init2.node;
5454
if match_qpath(path9, &["y"]);
5555
if let PatKind::Binding(BindingAnnotation::Unannotated, _, name2, None) = local3.pat.node;

tests/ui/author/matches.stout

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
if_chain! {
22
if let StmtKind::Decl(ref decl, _) = stmt.node
33
if let DeclKind::Local(ref local) = decl.node;
4-
if let Some(ref init) = local.init
4+
if let Some(ref init) = local.init;
55
if let ExprKind::Match(ref expr, ref arms, MatchSource::Normal) = init.node;
66
if let ExprKind::Lit(ref lit) = expr.node;
77
if let LitKind::Int(42, _) = lit.node;

tests/ui/issue_3849.rs

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
#![allow(dead_code)]
2+
#![allow(clippy::zero_ptr)]
3+
#![allow(clippy::transmute_ptr_to_ref)]
4+
5+
pub const ZPTR: *const usize = 0 as *const _;
6+
7+
fn main() {
8+
unsafe {
9+
#[clippy::author]
10+
let _: &i32 = std::mem::transmute(ZPTR);
11+
let _: &i32 = std::mem::transmute(0 as *const i32);
12+
}
13+
}

tests/ui/issue_3849.stdout

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
if_chain! {
2+
if let StmtKind::Local(ref local) = stmt.node;
3+
if let Some(ref init) = local.init;
4+
if let ExprKind::Call(ref func, ref args) = init.node;
5+
if let ExprKind::Path(ref path) = func.node;
6+
if match_qpath(path, &["std", "mem", "transmute"]);
7+
if args.len() == 1;
8+
if let ExprKind::Path(ref path1) = args[0].node;
9+
if match_qpath(path1, &["ZPTR"]);
10+
if let PatKind::Wild = local.pat.node;
11+
then {
12+
// report your lint here
13+
}
14+
}

0 commit comments

Comments
 (0)