New lint: swap_with_temporary

Author: samueltardieu

CHANGELOG.md

@@ -6098,6 +6098,7 @@ Released 2018-09-13
 [`suspicious_unary_op_formatting`]: https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_unary_op_formatting
 [`suspicious_xor_used_as_pow`]: https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_xor_used_as_pow
 [`swap_ptr_to_ref`]: https://rust-lang.github.io/rust-clippy/master/index.html#swap_ptr_to_ref
+[`swap_with_temporary`]: https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
 [`tabs_in_doc_comments`]: https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments
 [`temporary_assignment`]: https://rust-lang.github.io/rust-clippy/master/index.html#temporary_assignment
 [`temporary_cstring_as_ptr`]: https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr

clippy_lints/src/declared_lints.rs

@@ -477,6 +477,7 @@ pub static LINTS: &[&crate::LintInfo] = &[
     crate::methods::SUSPICIOUS_OPEN_OPTIONS_INFO,
     crate::methods::SUSPICIOUS_SPLITN_INFO,
     crate::methods::SUSPICIOUS_TO_OWNED_INFO,
+    crate::methods::SWAP_WITH_TEMPORARY_INFO,
     crate::methods::TYPE_ID_ON_BOX_INFO,
     crate::methods::UNINIT_ASSUMED_INIT_INFO,
     crate::methods::UNIT_HASH_INFO,

clippy_lints/src/methods/mod.rs

@@ -111,6 +111,7 @@ mod suspicious_command_arg_space;
 mod suspicious_map;
 mod suspicious_splitn;
 mod suspicious_to_owned;
+mod swap_with_temporary;
 mod type_id_on_box;
 mod uninit_assumed_init;
 mod unit_hash;
@@ -4363,6 +4364,34 @@ declare_clippy_lint! {
     "detect `repeat().take()` that can be replaced with `repeat_n()`"
 }
 
+declare_clippy_lint! {
+    /// ### What it does
+    /// Checks for usage of `std::mem::swap` with temporary values.
+    ///
+    /// ### Why is this bad?
+    /// Storing a new value in place of a temporary value which will
+    /// be dropped right after the `swap` is inefficient. The same
+    /// result can be achieved by using an assignment, or dropping
+    /// the swap arguments.
+    ///
+    /// ### Example
+    /// ```no_run
+    /// fn replace_string(s: &mut String) {
+    ///     std::mem::swap(s, &mut String::from("replaced"));
+    /// }
+    /// ```
+    /// Use instead:
+    /// ```no_run
+    /// fn replace_string(s: &mut String) {
+    ///     *s = String::from("replaced");
+    /// }
+    /// ```
+    #[clippy::version = "1.86.0"]
+    pub SWAP_WITH_TEMPORARY,
+    perf,
+    "detect swap with a temporary value"
+}
+
 pub struct Methods {
     avoid_breaking_exported_api: bool,
     msrv: Msrv,
@@ -4531,6 +4560,7 @@ impl_lint_pass!(Methods => [
     DOUBLE_ENDED_ITERATOR_LAST,
     USELESS_NONZERO_NEW_UNCHECKED,
     MANUAL_REPEAT_N,
+    SWAP_WITH_TEMPORARY,
 ]);
 
 /// Extracts a method call name, args, and `Span` of the method name.
@@ -4560,6 +4590,7 @@ impl<'tcx> LateLintPass<'tcx> for Methods {
                 unnecessary_fallible_conversions::check_function(cx, expr, func);
                 manual_c_str_literals::check(cx, expr, func, args, &self.msrv);
                 useless_nonzero_new_unchecked::check(cx, expr, func, args, &self.msrv);
+                swap_with_temporary::check(cx, expr, func, args);
             },
             ExprKind::MethodCall(method_call, receiver, args, _) => {
                 let method_span = method_call.ident.span;

clippy_lints/src/methods/swap_with_temporary.rs

@@ -0,0 +1,134 @@
+use clippy_utils::diagnostics::span_lint_and_then;
+use clippy_utils::is_no_std_crate;
+use clippy_utils::sugg::Sugg;
+use rustc_ast::BorrowKind;
+use rustc_errors::Applicability;
+use rustc_hir::{Expr, ExprKind, Node, QPath};
+use rustc_lint::LateContext;
+use rustc_span::sym;
+
+use super::SWAP_WITH_TEMPORARY;
+
+const MSG_TEMPORARY: &str = "this expression returns a temporary value";
+
+pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>, func: &Expr<'_>, args: &[Expr<'_>]) {
+    if let ExprKind::Path(QPath::Resolved(_, func_path)) = func.kind
+        && let Some(func_def_id) = func_path.res.opt_def_id()
+        && cx.tcx.is_diagnostic_item(sym::mem_swap, func_def_id)
+    {
+        match (arg_kind(&args[0]), arg_kind(&args[1])) {
+            (ArgKind::FromExpansion, _) | (_, ArgKind::FromExpansion) => {},
+            (ArgKind::RefMutToTemp(left_temp), ArgKind::RefMutToTemp(right_temp)) => {
+                emit_lint_useless(cx, expr, func, &args[0], &args[1], left_temp, right_temp);
+            },
+            (ArgKind::RefMutToTemp(left_temp), right) => emit_lint_assign(cx, expr, &right, left_temp),
+            (left, ArgKind::RefMutToTemp(right_temp)) => emit_lint_assign(cx, expr, &left, right_temp),
+            _ => {},
+        }
+    }
+}
+
+enum ArgKind<'tcx> {
+    Expr(&'tcx Expr<'tcx>),
+    RefMutToPlace(&'tcx Expr<'tcx>),
+    RefMutToTemp(&'tcx Expr<'tcx>),
+    FromExpansion,
+}
+
+fn arg_kind<'tcx>(arg: &'tcx Expr<'tcx>) -> ArgKind<'tcx> {
+    if arg.span.from_expansion() {
+        ArgKind::FromExpansion
+    } else if let ExprKind::AddrOf(BorrowKind::Ref, _, target) = arg.kind {
+        if target.span.from_expansion() {
+            ArgKind::FromExpansion
+        } else if target.is_syntactic_place_expr() {
+            ArgKind::RefMutToPlace(target)
+        } else {
+            ArgKind::RefMutToTemp(target)
+        }
+    } else {
+        ArgKind::Expr(arg)
+    }
+}
+
+fn emit_lint_useless(
+    cx: &LateContext<'_>,
+    expr: &Expr<'_>,
+    func: &Expr<'_>,
+    left: &Expr<'_>,
+    right: &Expr<'_>,
+    left_temp: &Expr<'_>,
+    right_temp: &Expr<'_>,
+) {
+    span_lint_and_then(
+        cx,
+        SWAP_WITH_TEMPORARY,
+        expr.span,
+        "swapping temporary values has no effect",
+        |diag| {
+            const DROP_MSG: &str = "drop them if creating these temporary expressions is necessary";
+
+            diag.span_note(left_temp.span, MSG_TEMPORARY);
+            diag.span_note(right_temp.span, MSG_TEMPORARY);
+
+            // If the `swap()` is a statement by itself, just propose to replace `swap(&mut a, &mut b)` by `a;
+            // b;` in order to drop `a` and `b` while acknowledging their side effects. If the
+            // `swap()` call is part of a larger expression, replace it by `{core,
+            // std}::mem::drop((a, b))`.
+            if matches!(cx.tcx.parent_hir_node(expr.hir_id), Node::Stmt(..)) {
+                diag.multipart_suggestion(
+                    DROP_MSG,
+                    vec![
+                        (func.span.with_hi(left_temp.span.lo()), String::new()),
+                        (left_temp.span.between(right_temp.span), String::from("; ")),
+                        (expr.span.with_lo(right_temp.span.hi()), String::new()),
+                    ],
+                    Applicability::MachineApplicable,
+                );
+            } else {
+                diag.multipart_suggestion(
+                    DROP_MSG,
+                    vec![
+                        (
+                            func.span,
+                            format!("{}::mem::drop(", if is_no_std_crate(cx) { "core" } else { "std" }),
+                        ),
+                        (left.span.with_hi(left_temp.span.lo()), String::new()),
+                        (right.span.with_hi(right_temp.span.lo()), String::new()),
+                        (expr.span.shrink_to_hi(), String::from(")")),
+                    ],
+                    Applicability::MachineApplicable,
+                );
+            }
+        },
+    );
+}
+
+fn emit_lint_assign(cx: &LateContext<'_>, expr: &Expr<'_>, target: &ArgKind<'_>, temp: &Expr<'_>) {
+    span_lint_and_then(
+        cx,
+        SWAP_WITH_TEMPORARY,
+        expr.span,
+        "swapping with a temporary value is inefficient",
+        |diag| {
+            diag.span_note(temp.span, MSG_TEMPORARY);
+            let mut applicability = Applicability::MachineApplicable;
+            let assign_target = match target {
+                ArgKind::Expr(expr) => Sugg::hir_with_applicability(cx, expr, "_", &mut applicability).deref(),
+                ArgKind::RefMutToPlace(expr) => Sugg::hir_with_applicability(cx, expr, "_", &mut applicability),
+                ArgKind::RefMutToTemp(_) | ArgKind::FromExpansion => unreachable!(),
+            };
+            let assign_source = Sugg::hir_with_applicability(cx, temp, "_", &mut applicability);
+
+            // If the `swap()` is a statement by itself, propose to replace it by `a = b`. Otherwise, when part
+            // of a larger expression, surround the assignment with a block to make it `()`.
+            let suggestion = format!("{assign_target} = {assign_source}");
+            let suggestion = if matches!(cx.tcx.parent_hir_node(expr.hir_id), Node::Stmt(..)) {
+                suggestion
+            } else {
+                format!("{{ {suggestion}; }}")
+            };
+            diag.span_suggestion(expr.span, "use assignment instead", suggestion, applicability);
+        },
+    );
+}

tests/ui/swap_with_temporary.fixed

@@ -0,0 +1,67 @@
+#![warn(clippy::swap_with_temporary)]
+
+use std::mem::swap;
+
+fn func() -> String {
+    String::from("func")
+}
+
+fn func_returning_refmut(s: &mut String) -> &mut String {
+    s
+}
+
+fn main() {
+    let mut x = String::from("x");
+    let mut y = String::from("y");
+    let mut zz = String::from("zz");
+    let z = &mut zz;
+
+    // No lint
+    swap(&mut x, &mut y);
+
+    func(); func();
+    //~^ ERROR: swapping temporary values has no effect
+
+    y = func();
+    //~^ ERROR: swapping with a temporary value is inefficient
+
+    x = func();
+    //~^ ERROR: swapping with a temporary value is inefficient
+
+    *z = func();
+    //~^ ERROR: swapping with a temporary value is inefficient
+
+    // No lint
+    swap(z, func_returning_refmut(&mut x));
+
+    swap(&mut y, z);
+
+    *z = func();
+    //~^ ERROR: swapping with a temporary value is inefficient
+
+    // Check rewrites as part of a larger expression
+    if matches!(std::mem::drop((func(), func())), ()) {
+        //~^ ERROR: swapping temporary values has no effect
+        println!("Yeah");
+    }
+    if matches!({ *z = func(); }, ()) {
+        //~^ ERROR: swapping with a temporary value is inefficient
+        println!("Yeah");
+    }
+
+    // Check that macros won't trigger the lint
+    macro_rules! mac {
+        (refmut $x:expr) => {
+            &mut $x
+        };
+        (funcall $f:ident) => {
+            $f()
+        };
+        (wholeexpr) => {
+            swap(&mut 42, &mut 0)
+        };
+    }
+    swap(mac!(refmut func()), z);
+    swap(&mut mac!(funcall func), z);
+    mac!(wholeexpr);
+}

tests/ui/swap_with_temporary.rs

@@ -0,0 +1,67 @@
+#![warn(clippy::swap_with_temporary)]
+
+use std::mem::swap;
+
+fn func() -> String {
+    String::from("func")
+}
+
+fn func_returning_refmut(s: &mut String) -> &mut String {
+    s
+}
+
+fn main() {
+    let mut x = String::from("x");
+    let mut y = String::from("y");
+    let mut zz = String::from("zz");
+    let z = &mut zz;
+
+    // No lint
+    swap(&mut x, &mut y);
+
+    swap(&mut func(), &mut func());
+    //~^ ERROR: swapping temporary values has no effect
+
+    swap(&mut func(), &mut y);
+    //~^ ERROR: swapping with a temporary value is inefficient
+
+    swap(&mut x, &mut func());
+    //~^ ERROR: swapping with a temporary value is inefficient
+
+    swap(z, &mut func());
+    //~^ ERROR: swapping with a temporary value is inefficient
+
+    // No lint
+    swap(z, func_returning_refmut(&mut x));
+
+    swap(&mut y, z);
+
+    swap(&mut func(), z);
+    //~^ ERROR: swapping with a temporary value is inefficient
+
+    // Check rewrites as part of a larger expression
+    if matches!(swap(&mut func(), &mut func()), ()) {
+        //~^ ERROR: swapping temporary values has no effect
+        println!("Yeah");
+    }
+    if matches!(swap(z, &mut func()), ()) {
+        //~^ ERROR: swapping with a temporary value is inefficient
+        println!("Yeah");
+    }
+
+    // Check that macros won't trigger the lint
+    macro_rules! mac {
+        (refmut $x:expr) => {
+            &mut $x
+        };
+        (funcall $f:ident) => {
+            $f()
+        };
+        (wholeexpr) => {
+            swap(&mut 42, &mut 0)
+        };
+    }
+    swap(mac!(refmut func()), z);
+    swap(&mut mac!(funcall func), z);
+    mac!(wholeexpr);
+}