Partially revert 2c1f2ff

Author: Jarcho

clippy_lints/src/methods/unnecessary_to_owned.rs

@@ -253,7 +253,7 @@ fn check_other_call_arg<'tcx>(
         } else if trait_predicate.def_id() == as_ref_trait_id {
             let composed_substs = compose_substs(
                 cx,
-                &*trait_predicate.trait_ref.substs.iter().skip(1).collect::<Vec<_>>(),
+                &trait_predicate.trait_ref.substs.iter().skip(1).collect::<Vec<_>>()[..],
                 call_substs
             );
             implements_trait(cx, receiver_ty, as_ref_trait_id, &composed_substs)

clippy_lints/src/needless_arbitrary_self_type.rs

@@ -67,7 +67,7 @@ enum Mode {
 
 fn check_param_inner(cx: &EarlyContext<'_>, path: &Path, span: Span, binding_mode: &Mode, mutbl: Mutability) {
     if_chain! {
-        if let [segment] = &*path.segments;
+        if let [segment] = &path.segments[..];
         if segment.ident.name == kw::SelfUpper;
         then {
             // In case we have a named lifetime, we check if the name comes from expansion.

clippy_lints/src/utils/internal_lints.rs

@@ -525,7 +525,7 @@ fn extract_clippy_version_value(cx: &LateContext<'_>, item: &'_ Item<'_>) -> Opt
         if_chain! {
             // Identify attribute
             if let ast::AttrKind::Normal(ref attr_kind, _) = &attr.kind;
-            if let [tool_name, attr_name] = &*attr_kind.path.segments;
+            if let [tool_name, attr_name] = &attr_kind.path.segments[..];
             if tool_name.ident.name == sym::clippy;
             if attr_name.ident.name == sym::version;
             if let Some(version) = attr.value_str();
@@ -976,7 +976,7 @@ impl<'tcx> LateLintPass<'tcx> for InvalidPaths {
                         unreachable!()
                     }
                 }).collect();
-            if !check_path(cx, &*path);
+            if !check_path(cx, &path[..]);
             then {
                 span_lint(cx, INVALID_PATHS, item.span, "invalid path");
             }

tests/ui/bytecount.rs

@@ -6,7 +6,7 @@ fn main() {
 
     let _ = x.iter().filter(|&&a| a == 0).count(); // naive byte count
 
-    let _ = (&*x).iter().filter(|&a| *a == 0).count(); // naive byte count
+    let _ = (&x[..]).iter().filter(|&a| *a == 0).count(); // naive byte count
 
     let _ = x.iter().filter(|a| **a > 0).count(); // not an equality count, OK.
 

tests/ui/bytecount.stderr

@@ -13,8 +13,8 @@ LL | #[deny(clippy::naive_bytecount)]
 error: you appear to be counting bytes the naive way
   --> $DIR/bytecount.rs:9:13
    |
-LL |     let _ = (&*x).iter().filter(|&a| *a == 0).count(); // naive byte count
-   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using the bytecount crate: `bytecount::count((&*x), 0)`
+LL |     let _ = (&x[..]).iter().filter(|&a| *a == 0).count(); // naive byte count
+   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using the bytecount crate: `bytecount::count((&x[..]), 0)`
 
 error: you appear to be counting bytes the naive way
   --> $DIR/bytecount.rs:21:13

tests/ui/indexing_slicing_slice.rs

@@ -2,7 +2,7 @@
 // We also check the out_of_bounds_indexing lint here, because it lints similar things and
 // we want to avoid false positives.
 #![warn(clippy::out_of_bounds_indexing)]
-#![allow(clippy::no_effect, clippy::unnecessary_operation, clippy::redundant_slicing)]
+#![allow(clippy::no_effect, clippy::unnecessary_operation)]
 
 fn main() {
     let x = [1, 2, 3, 4];

tests/ui/str_to_string.rs

@@ -2,6 +2,6 @@
 
 fn main() {
     let hello = "hello world".to_string();
-    let msg = &*hello;
+    let msg = &hello[..];
     msg.to_string();
 }