Skip to content

Commit 39b0d14

Browse files
authored
Merge pull request #411 from JohnTitor/notification-groups
Mention Zulip stream in notification group TODO list
2 parents 58490bc + ac46601 commit 39b0d14

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

src/compiler/notification-groups.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,31 +9,37 @@ are setup so that anyone can join them if they want.
99
If you'd like to create a notification group, here are the steps.
1010
First, you want to get approval from the compiler team:
1111

12-
* Propose the group by preparing a [Major Change Proposal][MCP]. If
12+
* Propose the group by preparing a [Major Change Proposal][MCP]. If
1313
your group is not analogous to some existing group, it is probably
1414
a good idea to ping compiler team leads before-hand or as part of
1515
the MCP.
1616
* The MCP should specify what GitHub label will be associated with the
1717
notification group. Often this is an existing label, such as
1818
`O-Windows`.
19-
19+
2020
Once the MCP is accepted, here are the steps to actually create the group.
21-
In some cases we include an example PR from some other group.
21+
In some cases we include an example PR from some other group.
2222

23-
* File a tracking issue in the rust-lang/compiler-team repository to collect
23+
* File a tracking issue in the [rust-lang/compiler-team] repository to collect
2424
your progress.
25-
* Create a PR against the rust-lang/team repository adding the notification
25+
* Create a PR against the [rust-lang/team] repository adding the notification
2626
group. [Example PR.](https://github.com/rust-lang/team/pull/347)
27-
* Configure the rust-lang/rust repository to accept triagebot commands
27+
* Configure the [rust-lang/rust] repository to accept triagebot commands
2828
for this group. [Example PR.](https://github.com/rust-lang/rust/pull/72706)
2929
* Create a PR for the rustc-dev-guide amending [the notification group
3030
section](https://rustc-dev-guide.rust-lang.org/notification-groups/about.html)
3131
to mention your group.
32-
* Create a sample PR for the rust-lang/team repository showing how one can add
33-
oneself. This will be referenced by your blog post to show people how to
32+
* Create a sample PR for the [rust-lang/team] repository showing how one can add
33+
oneself. This will be referenced by your blog post to show people how to
3434
join. [Example PR.](https://github.com/rust-lang/team/pull/140)
35+
* Create a Zulip stream for the notification group. If you don't have the permission
36+
to do, you can ask on [#t-compiler/wg-meta].
3537
* Write an announcement blog post for Inside Rust and open a PR against
3638
[blog.rust-lang.org](https://github.com/rust-lang/blog.rust-lang.org).
3739
[Example PR.](https://github.com/rust-lang/blog.rust-lang.org/pull/615)
3840

41+
[rust-lang/compiler-team]: https://github.com/rust-lang/compiler-team
42+
[rust-lang/team]: https://github.com/rust-lang/team
43+
[rust-lang/rust]: https://github.com/rust-lang/rust
44+
[#t-compiler/wg-meta]: https://rust-lang.zulipchat.com/#narrow/stream/185694-t-compiler.2Fwg-meta
3945
[MCP]: ./mcp.md

0 commit comments

Comments
 (0)