Move suggestion list creation to coerce check

GuillaumeGomez · GuillaumeGomez · commit 021d97d1c5e0 · 2016-12-20T11:37:15.000+01:00
diff --git a/src/librustc/infer/error_reporting.rs b/src/librustc/infer/error_reporting.rs
@@ -83,13 +83,14 @@ use hir::def_id::DefId;
 use infer;
 use middle::region;
 use traits::{ObligationCause, ObligationCauseCode};
-use ty::{self, ImplOrTraitItem, Ty, TyCtxt, TypeFoldable};
+use ty::{self, TyCtxt, TypeFoldable};
 use ty::{Region, ReFree};
 use ty::error::TypeError;
 
 use std::cell::{Cell, RefCell};
 use std::char::from_u32;
 use std::fmt;
+//use std::rc::Rc;
 use syntax::ast;
 use syntax::ptr::P;
 use syntax::symbol::Symbol;
@@ -233,6 +234,22 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> {
     }
 }
 
+/*struct MethodInfo<'tcx> {
+    ast: Option<ast::Attribute>,
+    id: DefId,
+    item: Rc<ImplOrTraitItem<'tcx>>,
+}
+
+impl<'tcx> MethodInfo<'tcx> {
+    fn new(ast: Option<ast::Attribute>, id: DefId, item: Rc<ImplOrTraitItem<'tcx>>) -> MethodInfo {
+        MethodInfo {
+            ast: ast,
+            id: id,
+            item: item,
+        }
+    }
+}*/
+
 impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
     pub fn report_region_errors(&self,
                                 errors: &Vec<RegionResolutionError<'tcx>>) {
@@ -583,36 +600,53 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
                 }
             }
 
-            if let Some((found, (expected_ty, _))) = self.get_ids(values) {
+            //if let Some((found, (expected_ty, expected))) = self.get_ids(values) {
                 // look for expected with found id
-                self.tcx.populate_inherent_implementations_for_type_if_necessary(found);
+                /*self.tcx.populate_inherent_implementations_for_type_if_necessary(found);
                 if let Some(impl_infos) = self.tcx.inherent_impls.borrow().get(&found) {
-                    let mut methods: Vec<(Option<ast::Attribute>, DefId, ImplOrTraitItem<'tcx>)> = Vec::new();
+                    let mut methods: Vec<MethodInfo> = Vec::new();
                     for impl_ in impl_infos {
                         methods.append(&mut self.tcx
                                                 .impl_or_trait_items(*impl_)
                                                 .iter()
-                                                .map(|&did| (None, did, self.tcx.impl_or_trait_item(did)))
-                                                .filter(|&(_, _, ref x)| {
-                                                    self.matches_return_type(x, &expected_ty)
+                                                .map(|&did| MethodInfo::new(None, did, Rc::new(self.tcx.impl_or_trait_item(did))))
+                                                .filter(|ref x| {
+                                                    self.matches_return_type(&*x.item, &expected_ty)
                                                 })
                                                 .collect());
                     }
-                    let safe_suggestions: Vec<_> = methods.iter()
-                                                  .map(|&(_, ref id, ref x)| (self.find_attr(*id, "safe_suggestion"), id, x))
-                                                  .filter(|&(ref res, _, _)| res.is_some())
-                                                  .collect();
-                    if safe_suggestions.len() > 0 {
-                        for (_, _, method) in safe_suggestions {
-                            println!("safe ==> {:?}", method.name());
-                        }
-                    } else {
-                        for &(_, _, ref method) in methods.iter() {
-                            println!("not safe ==> {:?}", method.name());
+                    for did in self.tcx.sess.cstore.implementations_of_trait(None) {
+                        if did == found {
+                            methods.append(
+                                self.tcx.sess.cstore.impl_or_trait_items(did)
+                                                    .iter()
+                                                    .map(|&did| MethodInfo::new(None, did, Rc::new(self.tcx.impl_or_trait_item(did))))
+                                                    .filter(|ref x| {
+                                                        self.matches_return_type(&*x.item, &expected_ty)
+                                                    })
+                                                    .collect());
+                            ;
                         }
                     }
-                }
-            }
+                    let safe_suggestions: Vec<_> =
+                        methods.iter()
+                               .map(|ref x| MethodInfo::new(self.find_attr(x.id, "safe_suggestion"), x.id, x.item.clone()))
+                               .filter(|ref x| x.ast.is_some())
+                               .collect();
+                    if safe_suggestions.len() > 0 {
+                        println!("safe");
+                        self.get_best_match(&safe_suggestions);
+                    } else {
+                        println!("not safe");
+                        self.get_best_match(&methods);
+                    }*/
+                    /*let mode = probe::Mode::MethodCall;
+                    if let Ok(ret) = self.probe_return(DUMMY_SP, mode, expected, found,                               DUMMY_NODE_ID) {
+                        println!("got it");
+                    } else {
+                        println!("sad...");
+                    }*/
+            //}
         }
 
         diag.span_label(span, &terr);
@@ -625,14 +659,31 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
         self.tcx.note_and_explain_type_err(diag, terr, span);
     }
 
+    /*fn get_best_match(&self, methods: &[MethodInfo<'tcx>]) -> String {
+        let no_argument_methods: Vec<&MethodInfo> =
+            methods.iter()
+                   .filter(|ref x| self.has_not_input_arg(&*x.item))
+                   .collect();
+        if no_argument_methods.len() > 0 {
+            for ref method in no_argument_methods {
+                println!("best match ==> {:?}", method.item.name());
+            }
+        } else {
+            for ref method in methods.iter() {
+                println!("not best ==> {:?}", method.item.name());
+            }
+        }
+        String::new()
+    }
+
     fn find_attr(&self, def_id: DefId, attr_name: &str) -> Option<ast::Attribute> {
         for item in self.tcx.get_attrs(def_id).iter() {
             if item.check_name(attr_name) {
                 return Some(item.clone());
             }
         }
         None
-    }
+    }*/
 
     pub fn report_and_explain_type_error(&self,
                                          trace: TypeTrace<'tcx>,
@@ -662,6 +713,15 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
         }
     }
 
+    /*fn has_not_input_arg(&self, method: &ImplOrTraitItem<'tcx>) -> bool {
+        match *method {
+            ImplOrTraitItem::MethodTraitItem(ref x) => {
+                x.fty.sig.skip_binder().inputs.len() == 1
+            }
+            _ => false,
+        }
+    }
+
     fn matches_return_type(&self, method: &ImplOrTraitItem<'tcx>, expected: &ty::Ty<'tcx>) -> bool {
         match *method {
             ImplOrTraitItem::MethodTraitItem(ref x) => {
@@ -714,7 +774,7 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
             }
             _ => None,
         }
-    }
+    }*/
 
     fn expected_found_str<T: fmt::Display + TypeFoldable<'tcx>>(
         &self,
diff --git a/src/librustc_typeck/check/demand.rs b/src/librustc_typeck/check/demand.rs
@@ -14,8 +14,32 @@ use rustc::ty::Ty;
 use rustc::infer::{InferOk};
 use rustc::traits::ObligationCause;
 
-use syntax_pos::Span;
+use syntax::ast;
+use syntax_pos::{self, Span};
 use rustc::hir;
+use rustc::ty::{self, ImplOrTraitItem};
+
+use hir::def_id::DefId;
+
+use std::rc::Rc;
+
+use super::method::probe;
+
+struct MethodInfo<'tcx> {
+    ast: Option<ast::Attribute>,
+    id: DefId,
+    item: Rc<ImplOrTraitItem<'tcx>>,
+}
+
+impl<'tcx> MethodInfo<'tcx> {
+    fn new(ast: Option<ast::Attribute>, id: DefId, item: Rc<ImplOrTraitItem<'tcx>>) -> MethodInfo {
+        MethodInfo {
+            ast: ast,
+            id: id,
+            item: item,
+        }
+    }
+}
 
 impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
     // Requires that the two types unify, and prints an error message if
@@ -57,7 +81,70 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
         if let Err(e) = self.try_coerce(expr, checked_ty, expected) {
             let cause = self.misc(expr.span);
             let expr_ty = self.resolve_type_vars_with_obligations(checked_ty);
+            let mode = probe::Mode::MethodCall;
+            if let Ok(methods) = self.probe_return(syntax_pos::DUMMY_SP, mode, expected,
+                                                   checked_ty, ast::DUMMY_NODE_ID) {
+                let suggestions: Vec<_> =
+                    methods.iter()
+                           .filter_map(|ref x| {
+                            if let Some(id) = self.get_impl_id(&x.item) {
+                                Some(MethodInfo::new(None, id, Rc::new(x.item.clone())))
+                            } else {
+                                None
+                            }})
+                           .collect();
+                let safe_suggestions: Vec<_> =
+                    suggestions.iter()
+                               .map(|ref x| MethodInfo::new(
+                                                self.find_attr(x.id, "safe_suggestion"),
+                                                               x.id,
+                                                               x.item.clone()))
+                               .filter(|ref x| x.ast.is_some())
+                               .collect();
+                if safe_suggestions.len() > 0 {
+                    self.get_best_match(&safe_suggestions);
+                } else {
+                    self.get_best_match(&suggestions);
+                }
+            }
             self.report_mismatched_types(&cause, expected, expr_ty, e);
         }
     }
+
+    fn get_best_match(&self, methods: &[MethodInfo<'tcx>]) -> String {
+        if methods.len() == 1 {
+            println!("unique match ==> {:?}", methods[0].item.name());
+            return String::new();
+        }
+        let no_argument_methods: Vec<&MethodInfo> =
+            methods.iter()
+                   .filter(|ref x| self.has_not_input_arg(&*x.item))
+                   .collect();
+        if no_argument_methods.len() > 0 {
+            for ref method in no_argument_methods {
+                println!("best match ==> {:?}", method.item.name());
+            }
+        } else {
+            for ref method in methods.iter() {
+                println!("not best ==> {:?}", method.item.name());
+            }
+        }
+        String::new()
+    }
+
+    fn get_impl_id(&self, impl_: &ImplOrTraitItem<'tcx>) -> Option<DefId> {
+        match *impl_ {
+            ty::ImplOrTraitItem::MethodTraitItem(ref m) => Some((*m).def_id),
+            _ => None,
+        }
+    }
+
+    fn has_not_input_arg(&self, method: &ImplOrTraitItem<'tcx>) -> bool {
+        match *method {
+            ImplOrTraitItem::MethodTraitItem(ref x) => {
+                x.fty.sig.skip_binder().inputs.len() == 1
+            }
+            _ => false,
+        }
+    }
 }
diff --git a/src/librustc_typeck/check/method/mod.rs b/src/librustc_typeck/check/method/mod.rs
@@ -30,7 +30,7 @@ pub use self::CandidateSource::*;
 pub use self::suggest::AllTraitsVec;
 
 mod confirm;
-mod probe;
+pub mod probe;
 mod suggest;
 
 pub enum MethodError<'tcx> {
@@ -130,7 +130,7 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
 
         let mode = probe::Mode::MethodCall;
         let self_ty = self.resolve_type_vars_if_possible(&self_ty);
-        let pick = self.probe_method(span, mode, method_name, self_ty, call_expr.id)?;
+        let pick = self.probe_method(span, mode, method_name, self_ty, call_expr.id)?.remove(0);
 
         if let Some(import_id) = pick.import_id {
             self.tcx.used_trait_imports.borrow_mut().insert(import_id);
@@ -328,7 +328,8 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
                         expr_id: ast::NodeId)
                         -> Result<Def, MethodError<'tcx>> {
         let mode = probe::Mode::Path;
-        let pick = self.probe_method(span, mode, method_name, self_ty, expr_id)?;
+        let picks = self.probe_method(span, mode, method_name, self_ty, expr_id)?;
+        let pick = &picks[0];
 
         if let Some(import_id) = pick.import_id {
             self.tcx.used_trait_imports.borrow_mut().insert(import_id);
@@ -353,4 +354,25 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
                            -> Option<ty::AssociatedItem> {
         self.tcx.associated_items(def_id).find(|item| item.name == item_name)
     }
+
+    fn matches_return_type(&self, method: &ty::ImplOrTraitItem<'tcx>,
+                           expected: ty::Ty<'tcx>) -> bool {
+        match *method {
+            ty::ImplOrTraitItem::MethodTraitItem(ref x) => {
+                self.can_sub_types(x.fty.sig.skip_binder().output, expected).is_ok()
+            }
+            _ => false,
+        }
+    }
+
+    pub fn impl_or_return_item(&self,
+                               def_id: DefId,
+                               return_type: ty::Ty<'tcx>)
+                               -> Option<ty::ImplOrTraitItem<'tcx>> {
+        self.tcx
+            .impl_or_trait_items(def_id)
+            .iter()
+            .map(|&did| self.tcx.impl_or_trait_item(did))
+            .find(|m| self.matches_return_type(m, return_type))
+    }
 }
diff --git a/src/librustc_typeck/check/method/probe.rs b/src/librustc_typeck/check/method/probe.rs
