Skip to content

Commit 06f6e30

Browse files
committed
---
yaml --- r: 23252 b: refs/heads/master c: a83414b h: refs/heads/master v: v3
1 parent cf2169f commit 06f6e30

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 74c69e1053188d92b86bc8b28cbf1af87d31ea2d
2+
refs/heads/master: a83414b6e8879b2485374469f7f5fe60f22ae936
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: cd6f24f9d14ac90d167386a56e7a6ac1f0318195
55
refs/heads/try: ffbe0e0e00374358b789b0037bcb3a577cd218be

trunk/src/rustc/middle/lint.rs

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -452,17 +452,28 @@ fn check_item_path_statement(cx: ty::ctxt, it: @ast::item) {
452452
fn check_item_non_camel_case_types(cx: ty::ctxt, it: @ast::item) {
453453
fn is_camel_case(ident: ast::ident) -> bool {
454454
assert ident.is_not_empty();
455-
let ident = ident_without_trailing_underscores(ident);
455+
let ident = ident_without_trailing_underscores(*ident);
456+
let ident = ident_without_leading_underscores(ident);
456457
char::is_uppercase(str::char_at(ident, 0)) &&
457458
!ident.contains_char('_')
458459
}
459460

460-
fn ident_without_trailing_underscores(ident: ast::ident) -> ~str {
461-
match str::rfind(*ident, |c| c != '_') {
462-
some(idx) => (*ident).slice(0, idx + 1),
461+
fn ident_without_trailing_underscores(ident: ~str) -> ~str {
462+
match str::rfind(ident, |c| c != '_') {
463+
some(idx) => ident.slice(0, idx + 1),
463464
none => {
464465
// all underscores
465-
*ident
466+
ident
467+
}
468+
}
469+
}
470+
471+
fn ident_without_leading_underscores(ident: ~str) -> ~str {
472+
match str::find(ident, |c| c != '_') {
473+
some(idx) => ident.slice(idx, ident.len()),
474+
none => {
475+
// all underscores
476+
ident
466477
}
467478
}
468479
}

0 commit comments

Comments
 (0)