---

yaml
---
r: 23156
b: refs/heads/master
c: ac4132b
h: refs/heads/master
v: v3

Author: brson

[refs]

@@ -1,5 +1,5 @@
 ---
-refs/heads/master: 78d19d8f1bdb64317ebdb072c25ee1240a562095
+refs/heads/master: ac4132b7fda1e2bd356a5af8d89badf3e05f7a1a
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: cd6f24f9d14ac90d167386a56e7a6ac1f0318195
 refs/heads/try: ffbe0e0e00374358b789b0037bcb3a577cd218be

trunk/src/libstd/cell.rs

@@ -18,17 +18,18 @@ fn empty_cell<T>() -> Cell<T> {
 impl<T> Cell<T> {
     /// Yields the value, failing if the cell is empty.
     fn take() -> T {
-        let mut value = none;
-        value <-> self.value;
-        if value.is_none() {
+        if self.is_empty() {
             fail ~"attempt to take an empty cell";
         }
+
+        let mut value = none;
+        value <-> self.value;
         return option::unwrap(value);
     }
 
     /// Returns the value, failing if the cell is full.
     fn put_back(+value: T) {
-        if self.value.is_none() {
+        if !self.is_empty() {
             fail ~"attempt to put a value back into a full cell";
         }
         self.value = some(move value);
@@ -39,3 +40,30 @@ impl<T> Cell<T> {
         self.value.is_none()
     }
 }
+
+#[test]
+fn test_basic() {
+    let value_cell = Cell(~10);
+    assert !value_cell.is_empty();
+    let value = value_cell.take();
+    assert value == ~10;
+    assert value_cell.is_empty();
+    value_cell.put_back(value);
+    assert !value_cell.is_empty();
+}
+
+#[test]
+#[should_fail]
+#[ignore(cfg(windows))]
+fn test_take_empty() {
+    let value_cell = empty_cell::<~int>();
+    value_cell.take();
+}
+
+#[test]
+#[should_fail]
+#[ignore(cfg(windows))]
+fn test_put_back_non_empty() {
+    let value_cell = Cell(~10);
+    value_cell.put_back(~20);
+}