Skip to content

Commit 0ce0f83

Browse files
committed
std: Fix test that was commented out
1 parent e1c52a4 commit 0ce0f83

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

src/libstd/net_tcp.rs

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
// except according to those terms.
1010

1111
//! High-level interface to libuv's TCP functionality
12-
// XXX Need FFI fixes
12+
// FIXME #4425: Need FFI fixes
1313
#[allow(deprecated_mode)];
1414

1515
use future;
@@ -1546,23 +1546,21 @@ pub mod test {
15461546
}
15471547
}
15481548
pub fn impl_gl_tcp_ipv4_server_client_reader_writer() {
1549-
/*
1550-
XXX: Causes an ICE.
15511549

15521550
let iotask = uv::global_loop::get();
15531551
let server_ip = ~"127.0.0.1";
15541552
let server_port = 8891u;
15551553
let expected_req = ~"ping";
15561554
let expected_resp = ~"pong";
15571555

1558-
let server_result_po = core::comm::port::<~str>();
1559-
let server_result_ch = core::comm::chan(server_result_po);
1556+
let server_result_po = oldcomm::Port::<~str>();
1557+
let server_result_ch = oldcomm::Chan(&server_result_po);
15601558

1561-
let cont_po = core::comm::port::<()>();
1562-
let cont_ch = core::comm::chan(cont_po);
1559+
let cont_po = oldcomm::Port::<()>();
1560+
let cont_ch = oldcomm::Chan(&cont_po);
15631561
// server
15641562
do task::spawn_sched(task::ManualThreads(1u)) {
1565-
let actual_req = do comm::listen |server_ch| {
1563+
let actual_req = do oldcomm::listen |server_ch| {
15661564
run_tcp_test_server(
15671565
server_ip,
15681566
server_port,
@@ -1573,29 +1571,28 @@ pub mod test {
15731571
};
15741572
server_result_ch.send(actual_req);
15751573
};
1576-
core::comm::recv(cont_po);
1574+
oldcomm::recv(cont_po);
15771575
// client
15781576
let server_addr = ip::v4::parse_addr(server_ip);
15791577
let conn_result = connect(server_addr, server_port, iotask);
1580-
if result::is_err(conn_result) {
1578+
if result::is_err(&conn_result) {
15811579
assert false;
15821580
}
15831581
let sock_buf = @socket_buf(result::unwrap(conn_result));
15841582
buf_write(sock_buf, expected_req);
15851583

15861584
// so contrived!
1587-
let actual_resp = do str::as_bytes(expected_resp) |resp_buf| {
1588-
buf_read(sock_buf, vec::len(resp_buf))
1585+
let actual_resp = do str::as_bytes(&expected_resp) |resp_buf| {
1586+
buf_read(sock_buf, resp_buf.len())
15891587
};
15901588

1591-
let actual_req = core::comm::recv(server_result_po);
1589+
let actual_req = oldcomm::recv(server_result_po);
15921590
log(debug, fmt!("REQ: expected: '%s' actual: '%s'",
15931591
expected_req, actual_req));
15941592
log(debug, fmt!("RESP: expected: '%s' actual: '%s'",
15951593
expected_resp, actual_resp));
15961594
assert str::contains(actual_req, expected_req);
15971595
assert str::contains(actual_resp, expected_resp);
1598-
*/
15991596
}
16001597

16011598
pub fn impl_tcp_socket_impl_reader_handles_eof() {

0 commit comments

Comments
 (0)