---

yaml
---
r: 15227
b: refs/heads/try
c: ad26b00
h: refs/heads/master
i:
  15225: 26bc98a
  15223: d8d2709
v: v3

Author: brson

[refs]

@@ -2,5 +2,5 @@
 refs/heads/master: 61b1875c16de39c166b0f4d54bba19f9c6777d1a
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
-refs/heads/try: 15de9b3c957eae9bfcfb8d34fc75377266512acd
+refs/heads/try: ad26b00696afb1b74a636fa02e2600485a914d47
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105

branches/try/src/rustc/middle/ty.rs

@@ -915,35 +915,64 @@ fn type_needs_unwind_cleanup(cx: ctxt, ty: t) -> bool {
       none { }
     }
 
+    let tycache = new_ty_hash();
+    let needs_unwind_cleanup =
+        type_needs_unwind_cleanup_(cx, ty, tycache, false);
+    cx.needs_unwind_cleanup_cache.insert(ty, needs_unwind_cleanup);
+    ret needs_unwind_cleanup;
+}
+
+fn type_needs_unwind_cleanup_(cx: ctxt, ty: t,
+                              tycache: map::hashmap<t, ()>,
+                              encountered_box: bool) -> bool {
+
     // Prevent infinite recursion
-    cx.needs_unwind_cleanup_cache.insert(ty, false);
+    alt tycache.find(ty) {
+      some(_) { ret false; }
+      none { tycache.insert(ty, ()); }
+    }
 
+    let mut encountered_box = encountered_box;
     let mut needs_unwind_cleanup = false;
     maybe_walk_ty(ty) {|ty|
         alt get(ty).struct {
+          ty_box(_) | ty_opaque_box {
+            encountered_box = true;
+            true
+          }
           ty_nil | ty_bot | ty_bool |
           ty_int(_) | ty_uint(_) | ty_float(_) |
-          ty_box(_) | ty_rec(_) | ty_tup(_) {
+          ty_rec(_) | ty_tup(_) | ty_ptr(_) {
             true
           }
           ty_enum(did, tps) {
             for v in *enum_variants(cx, did) {
                 for aty in v.args {
                     let t = substitute_type_params(cx, tps, aty);
-                    needs_unwind_cleanup |= type_needs_unwind_cleanup(cx, t);
+                    needs_unwind_cleanup |=
+                        type_needs_unwind_cleanup_(cx, t, tycache,
+                                                   encountered_box);
                 }
             }
             !needs_unwind_cleanup
           }
+          ty_uniq(_) | ty_str | ty_vec(_) | ty_res(_, _, _) {
+            // Once we're inside a box, the annihilator will find
+            // it and destroy it.
+            if !encountered_box {
+                needs_unwind_cleanup = true;
+                false
+            } else {
+                true
+            }
+          }
           _ {
             needs_unwind_cleanup = true;
             false
           }
         }
     }
 
-    cx.needs_unwind_cleanup_cache.insert(ty, needs_unwind_cleanup);
-
     ret needs_unwind_cleanup;
 }
 

branches/try/src/test/run-fail/unwind-box-fn-unique.rs

@@ -0,0 +1,14 @@
+// error-pattern:fail
+
+fn failfn() {
+    fail;
+}
+
+fn main() {
+    let y = ~0;
+    let x = @fn~() {
+        log(error, y);
+    };
+    failfn();
+    log(error, x);
+}

branches/try/src/test/run-fail/unwind-box-fn.rs

@@ -0,0 +1,14 @@
+// error-pattern:fail
+
+fn failfn() {
+    fail;
+}
+
+fn main() {
+    let y = ~0;
+    let x = @fn@() {
+        log(error, y);
+    };
+    failfn();
+    log(error, x);
+}

branches/try/src/test/run-fail/unwind-box-iface.rs

@@ -0,0 +1,19 @@
+// error-pattern:fail
+
+fn failfn() {
+    fail;
+}
+
+iface i {
+    fn foo();
+}
+
+impl of i for ~int {
+    fn foo() { }
+}
+
+fn main() {
+    let x = ~0 as i;
+    failfn();
+    log(error, x);
+}

branches/try/src/test/run-fail/unwind-box-res.rs

@@ -0,0 +1,18 @@
+// error-pattern:fail
+
+fn failfn() {
+    fail;
+}
+
+resource r(v: *int) unsafe {
+    let v2: ~int = unsafe::reinterpret_cast(v);
+}
+
+fn main() unsafe {
+    let i1 = ~0;
+    let i1p = unsafe::reinterpret_cast(i1);
+    unsafe::forget(i1);
+    let x = @r(i1p);
+    failfn();
+    log(error, x);
+}

branches/try/src/test/run-fail/unwind-box-str.rs

@@ -0,0 +1,11 @@
+// error-pattern:fail
+
+fn failfn() {
+    fail;
+}
+
+fn main() {
+    let x = @"hi";
+    failfn();
+    log(error, x);
+}

branches/try/src/test/run-fail/unwind-box-unique-unique.rs

@@ -0,0 +1,11 @@
+// error-pattern:fail
+
+fn failfn() {
+    fail;
+}
+
+fn main() {
+    let x = @~~0;
+    failfn();
+    log(error, x);
+}

branches/try/src/test/run-fail/unwind-box-unique.rs

@@ -0,0 +1,11 @@
+// error-pattern:fail
+
+fn failfn() {
+    fail;
+}
+
+fn main() {
+    let x = @~0;
+    failfn();
+    log(error, x);
+}

branches/try/src/test/run-fail/unwind-box-vec.rs

@@ -0,0 +1,11 @@
+// error-pattern:fail
+
+fn failfn() {
+    fail;
+}
+
+fn main() {
+    let x = @[0, 1, 2, 3, 4, 5];
+    failfn();
+    log(error, x);
+}