---

yaml
---
r: 14647
b: refs/heads/try
c: 2465a63
h: refs/heads/master
i:
  14645: ef11d81
  14643: 0581c60
  14639: 31c4c2b
v: v3

Author: brson

[refs]

@@ -2,5 +2,5 @@
 refs/heads/master: 61b1875c16de39c166b0f4d54bba19f9c6777d1a
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
-refs/heads/try: 237652299ec5fa3529ac7bd1bfddc52b7526bb82
+refs/heads/try: 2465a63a69ea51d4fce10430b6a8fd0079cbbcd5
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105

branches/try/src/rt/rust_task.cpp

@@ -401,26 +401,16 @@ rust_task::free(void *p)
 void
 rust_task::transition(rust_task_list *src, rust_task_list *dst,
                       rust_cond *cond, const char* cond_name) {
-    bool unlock = false;
-    if(!thread->lock.lock_held_by_current_thread()) {
-        unlock = true;
-        thread->lock.lock();
-    }
-    DLOG(thread, task,
-         "task %s " PTR " state change '%s' -> '%s' while in '%s'",
-         name, (uintptr_t)this, src->name, dst->name, state->name);
-    I(thread, state == src);
-    src->remove(this);
-    dst->append(this);
-    {
-        scoped_lock with(state_lock);
-        state = dst;
-        this->cond = cond;
-        this->cond_name = cond_name;
-    }
-    thread->lock.signal();
-    if(unlock)
-        thread->lock.unlock();
+    thread->transition(this, src, dst, cond, cond_name);
+}
+
+void
+rust_task::set_state(rust_task_list *state,
+                     rust_cond *cond, const char* cond_name) {
+    scoped_lock with(state_lock);
+    this->state = state;
+    this->cond = cond;
+    this->cond_name = cond_name;
 }
 
 void

branches/try/src/rt/rust_task.h

@@ -137,6 +137,9 @@ rust_task : public kernel_owned<rust_task>, rust_cond
 
     void return_c_stack();
 
+    void transition(rust_task_list *src, rust_task_list *dst,
+                    rust_cond *cond, const char* cond_name);
+
     friend void task_start_wrapper(spawn_args *a);
     friend void cleanup_task(cleanup_args *a);
     friend void reset_stack_limit_on_c_stack(reset_args *a);
@@ -163,8 +166,8 @@ rust_task : public kernel_owned<rust_task>, rust_cond
     void *realloc(void *data, size_t sz);
     void free(void *p);
 
-    void transition(rust_task_list *src, rust_task_list *dst,
-                    rust_cond *cond, const char* cond_name);
+    void set_state(rust_task_list *state,
+                   rust_cond *cond, const char* cond_name);
 
     void block(rust_cond *on, const char* name);
     void wakeup(rust_cond *from);

branches/try/src/rt/rust_task_thread.cpp

@@ -319,6 +319,29 @@ rust_task_thread::create_task(rust_task *spawner, const char *name,
     return task->id;
 }
 
+void 
+rust_task_thread::transition(rust_task *task,
+                             rust_task_list *src, rust_task_list *dst,
+                             rust_cond *cond, const char* cond_name) {
+    bool unlock = false;
+    if(!lock.lock_held_by_current_thread()) {
+        unlock = true;
+        lock.lock();
+    }
+    DLOG(this, task,
+         "task %s " PTR " state change '%s' -> '%s' while in '%s'",
+         name, (uintptr_t)this, src->name, dst->name,
+         task->get_state()->name);
+    I(this, task->get_state() == src);
+    src->remove(task);
+    dst->append(task);
+    task->set_state(dst, cond, cond_name);
+
+    lock.signal();
+    if(unlock)
+        lock.unlock();
+}
+
 void rust_task_thread::run() {
     this->start_main_loop();
     sched->release_task_thread();

branches/try/src/rt/rust_task_thread.h

@@ -123,6 +123,10 @@ struct rust_task_thread : public kernel_owned<rust_task_thread>,
     rust_task_id create_task(rust_task *spawner, const char *name,
                              size_t init_stack_sz);
 
+    void transition(rust_task *task,
+                    rust_task_list *src, rust_task_list *dst,
+                    rust_cond *cond, const char* cond_name);
+
     virtual void run();
 
     void init_tls();