Skip to content

Commit 158b699

Browse files
committed
---
yaml --- r: 157660 b: refs/heads/snap-stage3 c: fb00015 h: refs/heads/master v: v3
1 parent 54deace commit 158b699

File tree

3 files changed

+29
-1
lines changed

3 files changed

+29
-1
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
refs/heads/master: 065caf34f5ff29e04605f95d9c5d511af219439a
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
4-
refs/heads/snap-stage3: 2a7be1b209a4ceea42418f55baf68774571ed9a2
4+
refs/heads/snap-stage3: fb00015246824313e8882935c9ba175ea6daf9d4
55
refs/heads/try: 0ee4d8b0b112c608646fa75463ab4dc59132efd9
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b

branches/snap-stage3/src/libsyntax/parse/parser.rs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2730,6 +2730,8 @@ impl<'a> Parser<'a> {
27302730
return self.parse_dot_or_call_expr();
27312731
}
27322732

2733+
let lo = self.span.lo;
2734+
27332735
self.bump();
27342736

27352737
// Check for a place: `box(PLACE) EXPR`.
@@ -2738,6 +2740,18 @@ impl<'a> Parser<'a> {
27382740
if !self.eat(&token::RParen) {
27392741
let place = self.parse_expr();
27402742
self.expect(&token::RParen);
2743+
// Give a suggestion to use `box()` when a parenthesised expression is used
2744+
if !self.token.can_begin_expr() {
2745+
let span = self.span;
2746+
let this_token_to_string = self.this_token_to_string();
2747+
self.span_err(span,
2748+
format!("expected expression, found `{}`",
2749+
this_token_to_string).as_slice());
2750+
let box_span = mk_sp(lo, self.last_span.hi);
2751+
self.span_help(box_span,
2752+
"perhaps you meant `box() (foo)` instead?");
2753+
self.abort_if_errors();
2754+
}
27412755
let subexpression = self.parse_prefix_expr();
27422756
hi = subexpression.span.hi;
27432757
ex = ExprBox(place, subexpression);
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
fn main() {
12+
box(1 + 1) //~ HELP perhaps you meant `box() (foo)` instead?
13+
; //~ ERROR expected expression, found `;`
14+
}

0 commit comments

Comments
 (0)