Skip to content

Commit 159e4ae

Browse files
committed
---
yaml --- r: 129589 b: refs/heads/master c: 5c82f48 h: refs/heads/master i: 129587: 7c39c13 v: v3
1 parent 00a4c92 commit 159e4ae

File tree

3 files changed

+9
-23
lines changed

3 files changed

+9
-23
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 3ee047ae1ffab454270bc1859b3beef3556ef8f9
2+
refs/heads/master: 5c82f484db29e37e26064e853d8a303cc13bc78c
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: 0d3bd7720c50e3ada4bac77331d43926493be4fe
55
refs/heads/try: 80b45ddbd351f0a4a939c3a3c4e20b4defec4b35

trunk/src/librustdoc/clean/inline.rs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,14 @@ fn try_inline_def(cx: &core::DocContext,
124124
pub fn load_attrs(tcx: &ty::ctxt, did: ast::DefId) -> Vec<clean::Attribute> {
125125
let mut attrs = Vec::new();
126126
csearch::get_item_attrs(&tcx.sess.cstore, did, |v| {
127-
attrs.extend(v.move_iter().map(|a| {
127+
attrs.extend(v.move_iter().map(|mut a| {
128+
// FIXME this isn't quite always true, it's just true about 99% of
129+
// the time when dealing with documentation. For example,
130+
// this would treat doc comments of the form `#[doc = "foo"]`
131+
// incorrectly.
132+
if a.name().get() == "doc" && a.value_str().is_some() {
133+
a.node.is_sugared_doc = true;
134+
}
128135
a.clean()
129136
}));
130137
});

trunk/src/libsync/spsc_queue.rs

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -315,27 +315,6 @@ mod test {
315315
assert_eq!(consumer.pop(), None);
316316
}
317317

318-
// This behaviour is blocked by the type system if using the safe constructor
319-
#[test]
320-
fn pop_peeked_unchecked() {
321-
let q = unsafe { Queue::new(0) };
322-
q.push(vec![1i]);
323-
q.push(vec![2]);
324-
let peeked = q.peek().unwrap();
325-
326-
assert_eq!(*peeked, vec![1]);
327-
assert_eq!(q.pop(), Some(vec![1]));
328-
329-
assert_eq!(*peeked, vec![1]);
330-
q.push(vec![7]);
331-
332-
// Note: This should actually expect 1, but this test is to highlight
333-
// the unsafety allowed by the unchecked usage. A Rust user would not
334-
// expect their peeked value to mutate like this without the type system
335-
// complaining.
336-
assert_eq!(*peeked, vec![7]);
337-
}
338-
339318
#[test]
340319
fn peek() {
341320
let (mut consumer, mut producer) = queue(0);

0 commit comments

Comments
 (0)