Show error if --target-dir is provided more than once

hyd-dev · hyd-dev · commit 16929329667c · 2021-06-26T22:36:05.000+08:00
diff --git a/cargo-miri/bin.rs b/cargo-miri/bin.rs
@@ -572,7 +572,12 @@ fn phase_cargo_miri(mut args: env::Args) {
     // Forward all arguments before `--` other than `--target-dir` and its value to Cargo.
     for arg in ArgSplitFlagValue::new(&mut args, "--target-dir") {
         match arg {
-            Ok(value) => target_dir = Some(value.into()),
+            Ok(value) => {
+                if target_dir.is_some() {
+                    show_error(format!("`--target-dir` is provided more than once"));
+                }
+                target_dir = Some(value.into());
+            }
             Err(arg) => drop(cmd.arg(arg)),
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -572,7 +572,12 @@ fn phase_cargo_miri(mut args: env::Args) {`
`572`	`572`	// Forward all arguments before `--` other than `--target-dir` and its value to Cargo.
`573`	`573`	`for arg in ArgSplitFlagValue::new(&mut args, "--target-dir") {`
`574`	`574`	`match arg {`
`575`		`- Ok(value) => target_dir = Some(value.into()),`
	`575`	`+ Ok(value) => {`
	`576`	`+ if target_dir.is_some() {`
	`577`	+ show_error(format!("`--target-dir` is provided more than once"));
	`578`	`+ }`
	`579`	`+ target_dir = Some(value.into());`
	`580`	`+ }`
`576`	`581`	`Err(arg) => drop(cmd.arg(arg)),`
`577`	`582`	`}`
`578`	`583`	`}`