---

yaml
---
r: 172786
b: refs/heads/try
c: 14b6c6d
h: refs/heads/master
v: v3

Author: dotdash

[refs]

@@ -2,7 +2,7 @@
 refs/heads/master: 170c4399e614fe599c3d41306b3429ca8b3b68c6
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: 5b3cd3900ceda838f5798c30ab96ceb41f962534
-refs/heads/try: 32ddbb82e05abd1662950db857e7c6a6dcfba580
+refs/heads/try: 14b6c6d153edec5731230f919eaafcb5c32959d8
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596

branches/try/src/libcollections/dlist.rs

@@ -221,12 +221,9 @@ impl<T> DList<T> {
         DList{list_head: None, list_tail: Rawlink::none(), length: 0}
     }
 
-    /// Moves all elements from `other` to the end of the list.
+    /// Adds all elements from `other` to the end of the list.
     ///
-    /// This reuses all the nodes from `other` and moves them into `self`. After
-    /// this operation, `other` becomes empty.
-    ///
-    /// This operation should compute in O(1) time and O(1) memory.
+    /// This operation should compute in O(1) time.
     ///
     /// # Examples
     ///
@@ -240,20 +237,16 @@ impl<T> DList<T> {
     /// b.push_back(3i);
     /// b.push_back(4);
     ///
-    /// a.append(&mut b);
+    /// a.append(b);
     ///
     /// for e in a.iter() {
     ///     println!("{}", e); // prints 1, then 2, then 3, then 4
     /// }
-    /// println!("{}", b.len()); // prints 0
     /// ```
-    pub fn append(&mut self, other: &mut DList<T>) {
+    #[unstable = "append should be by-mutable-reference"]
+    pub fn append(&mut self, mut other: DList<T>) {
         match self.list_tail.resolve() {
-            None => {
-                self.length = other.length;
-                self.list_head = other.list_head.take();
-                self.list_tail = other.list_tail.take();
-            },
+            None => *self = other,
             Some(tail) => {
                 // Carefully empty `other`.
                 let o_tail = other.list_tail.take();
@@ -268,7 +261,6 @@ impl<T> DList<T> {
                 }
             }
         }
-        other.length = 0;
     }
 
     /// Provides a forward iterator.
@@ -412,51 +404,6 @@ impl<T> DList<T> {
     pub fn pop_back(&mut self) -> Option<T> {
         self.pop_back_node().map(|box Node{value, ..}| value)
     }
-
-    /// Splits the list into two at the given index. Returns everything after the given index,
-    /// including the index.
-    ///
-    /// This operation should compute in O(n) time.
-    #[stable]
-    pub fn split_off(&mut self, at: uint) -> DList<T> {
-        let len = self.len();
-        assert!(at < len, "Cannot split off at a nonexistent index");
-        if at == 0 {
-            return mem::replace(self, DList::new());
-        }
-
-        // Below, we iterate towards the `i-1`th node, either from the start or the end,
-        // depending on which would be faster.
-        let mut split_node = if at - 1 <= len - 1 - (at - 1) {
-            let mut iter = self.iter_mut();
-            // instead of skipping using .skip() (which creates a new struct),
-            // we skip manually so we can access the head field without
-            // depending on implementation details of Skip
-            for _ in range(0, at - 1) {
-                iter.next();
-            }
-            iter.head
-        }  else {
-            // better off starting from the end
-            let mut iter = self.iter_mut();
-            for _ in range(0, len - 1 - (at - 1)) {
-                iter.next_back();
-            }
-            iter.tail
-        };
-
-        let mut splitted_list = DList {
-            list_head: None,
-            list_tail: self.list_tail,
-            length: len - at
-        };
-
-        mem::swap(&mut split_node.resolve().unwrap().next, &mut splitted_list.list_head);
-        self.list_tail = split_node;
-        self.length = at;
-
-        splitted_list
-    }
 }
 
 #[unsafe_destructor]
@@ -830,108 +777,6 @@ mod tests {
         v.iter().map(|x| (*x).clone()).collect()
     }
 
-    #[test]
-    fn test_append() {
-        // Empty to empty
-        {
-            let mut m: DList<int> = DList::new();
-            let mut n = DList::new();
-            m.append(&mut n);
-            check_links(&m);
-            assert_eq!(m.len(), 0);
-            assert_eq!(n.len(), 0);
-        }
-        // Non-empty to empty
-        {
-            let mut m = DList::new();
-            let mut n = DList::new();
-            n.push_back(2i);
-            m.append(&mut n);
-            check_links(&m);
-            assert_eq!(m.len(), 1);
-            assert_eq!(m.pop_back(), Some(2));
-            assert_eq!(n.len(), 0);
-            check_links(&m);
-        }
-        // Empty to non-empty
-        {
-            let mut m = DList::new();
-            let mut n = DList::new();
-            m.push_back(2i);
-            m.append(&mut n);
-            check_links(&m);
-            assert_eq!(m.len(), 1);
-            assert_eq!(m.pop_back(), Some(2));
-            check_links(&m);
-        }
-
-        // Non-empty to non-empty
-        let v = vec![1i,2,3,4,5];
-        let u = vec![9i,8,1,2,3,4,5];
-        let mut m = list_from(v.as_slice());
-        let mut n = list_from(u.as_slice());
-        m.append(&mut n);
-        check_links(&m);
-        let mut sum = v;
-        sum.push_all(u.as_slice());
-        assert_eq!(sum.len(), m.len());
-        for elt in sum.into_iter() {
-            assert_eq!(m.pop_front(), Some(elt))
-        }
-        assert_eq!(n.len(), 0);
-        // let's make sure it's working properly, since we
-        // did some direct changes to private members
-        n.push_back(3);
-        assert_eq!(n.len(), 1);
-        assert_eq!(n.pop_front(), Some(3));
-        check_links(&n);
-    }
-
-    #[test]
-    fn test_split_off() {
-        // singleton
-        {
-            let mut m = DList::new();
-            m.push_back(1i);
-
-            let p = m.split_off(0);
-            assert_eq!(m.len(), 0);
-            assert_eq!(p.len(), 1);
-            assert_eq!(p.back(), Some(&1));
-            assert_eq!(p.front(), Some(&1));
-        }
-
-        // not singleton, forwards
-        {
-            let u = vec![1i,2,3,4,5];
-            let mut m = list_from(u.as_slice());
-            let mut n = m.split_off(2);
-            assert_eq!(m.len(), 2);
-            assert_eq!(n.len(), 3);
-            for elt in range(1i, 3) {
-                assert_eq!(m.pop_front(), Some(elt));
-            }
-            for elt in range(3i, 6) {
-                assert_eq!(n.pop_front(), Some(elt));
-            }
-        }
-        // not singleton, backwards
-        {
-            let u = vec![1i,2,3,4,5];
-            let mut m = list_from(u.as_slice());
-            let mut n = m.split_off(4);
-            assert_eq!(m.len(), 4);
-            assert_eq!(n.len(), 1);
-            for elt in range(1i, 5) {
-                assert_eq!(m.pop_front(), Some(elt));
-            }
-            for elt in range(5i, 6) {
-                assert_eq!(n.pop_front(), Some(elt));
-            }
-        }
-
-    }
-
     #[test]
     fn test_iterator() {
         let m = generate_test();
@@ -1220,6 +1065,41 @@ mod tests {
         assert_eq!(i, v.len());
     }
 
+    #[allow(deprecated)]
+    #[test]
+    fn test_append() {
+        {
+            let mut m = DList::new();
+            let mut n = DList::new();
+            n.push_back(2i);
+            m.append(n);
+            assert_eq!(m.len(), 1);
+            assert_eq!(m.pop_back(), Some(2));
+            check_links(&m);
+        }
+        {
+            let mut m = DList::new();
+            let n = DList::new();
+            m.push_back(2i);
+            m.append(n);
+            assert_eq!(m.len(), 1);
+            assert_eq!(m.pop_back(), Some(2));
+            check_links(&m);
+        }
+
+        let v = vec![1i,2,3,4,5];
+        let u = vec![9i,8,1,2,3,4,5];
+        let mut m = list_from(v.as_slice());
+        m.append(list_from(u.as_slice()));
+        check_links(&m);
+        let mut sum = v;
+        sum.push_all(u.as_slice());
+        assert_eq!(sum.len(), m.len());
+        for elt in sum.into_iter() {
+            assert_eq!(m.pop_front(), Some(elt))
+        }
+    }
+
     #[bench]
     fn bench_collect_into(b: &mut test::Bencher) {
         let v = &[0i; 64];

branches/try/src/libcollections/string.rs

@@ -302,7 +302,6 @@ impl String {
     /// assert_eq!(String::from_utf16_lossy(v),
     ///            "𝄞mus\u{FFFD}ic\u{FFFD}".to_string());
     /// ```
-    #[inline]
     #[stable]
     pub fn from_utf16_lossy(v: &[u16]) -> String {
         unicode_str::utf16_items(v).map(|c| c.to_char_lossy()).collect()
@@ -557,7 +556,6 @@ impl String {
     /// assert_eq!(s.remove(1), 'o');
     /// assert_eq!(s.remove(0), 'o');
     /// ```
-    #[inline]
     #[stable]
     pub fn remove(&mut self, idx: uint) -> char {
         let len = self.len();
@@ -584,7 +582,6 @@ impl String {
     ///
     /// If `idx` does not lie on a character boundary or is out of bounds, then
     /// this function will panic.
-    #[inline]
     #[stable]
     pub fn insert(&mut self, idx: uint, ch: char) {
         let len = self.len();
@@ -621,7 +618,6 @@ impl String {
     /// }
     /// assert_eq!(s.as_slice(), "olleh");
     /// ```
-    #[inline]
     #[stable]
     pub unsafe fn as_mut_vec<'a>(&'a mut self) -> &'a mut Vec<u8> {
         &mut self.vec
@@ -649,7 +645,6 @@ impl String {
     /// v.push('a');
     /// assert!(!v.is_empty());
     /// ```
-    #[inline]
     #[stable]
     pub fn is_empty(&self) -> bool { self.len() == 0 }
 
@@ -806,7 +801,6 @@ impl Str for String {
 
 #[stable]
 impl Default for String {
-    #[inline]
     #[stable]
     fn default() -> String {
         String::new()
@@ -815,15 +809,13 @@ impl Default for String {
 
 #[stable]
 impl fmt::String for String {
-    #[inline]
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         fmt::String::fmt(&**self, f)
     }
 }
 
 #[unstable = "waiting on fmt stabilization"]
 impl fmt::Show for String {
-    #[inline]
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         fmt::Show::fmt(&**self, f)
     }
@@ -850,7 +842,6 @@ impl<H: hash::Writer + hash::Hasher> hash::Hash<H> for String {
 impl<'a> Add<&'a str> for String {
     type Output = String;
 
-    #[inline]
     fn add(mut self, other: &str) -> String {
         self.push_str(other);
         self
@@ -890,7 +881,6 @@ impl ops::Index<ops::FullRange> for String {
 impl ops::Deref for String {
     type Target = str;
 
-    #[inline]
     fn deref<'a>(&'a self) -> &'a str {
         unsafe { mem::transmute(&self.vec[]) }
     }
@@ -905,7 +895,6 @@ pub struct DerefString<'a> {
 impl<'a> Deref for DerefString<'a> {
     type Target = String;
 
-    #[inline]
     fn deref<'b>(&'b self) -> &'b String {
         unsafe { mem::transmute(&*self.x) }
     }
@@ -944,7 +933,6 @@ pub trait ToString {
 }
 
 impl<T: fmt::String + ?Sized> ToString for T {
-    #[inline]
     fn to_string(&self) -> String {
         use core::fmt::Writer;
         let mut buf = String::new();
@@ -955,14 +943,12 @@ impl<T: fmt::String + ?Sized> ToString for T {
 }
 
 impl IntoCow<'static, String, str> for String {
-    #[inline]
     fn into_cow(self) -> CowString<'static> {
         Cow::Owned(self)
     }
 }
 
 impl<'a> IntoCow<'a, String, str> for &'a str {
-    #[inline]
     fn into_cow(self) -> CowString<'a> {
         Cow::Borrowed(self)
     }
@@ -980,7 +966,6 @@ impl<'a> Str for CowString<'a> {
 }
 
 impl fmt::Writer for String {
-    #[inline]
     fn write_str(&mut self, s: &str) -> fmt::Result {
         self.push_str(s);
         Ok(())