Skip to content

Commit 1c3a4a2

Browse files
committed
---
yaml --- r: 208873 b: refs/heads/master c: f472403 h: refs/heads/master i: 208871: a89454a v: v3
1 parent 9f56382 commit 1c3a4a2

File tree

3 files changed

+7
-19
lines changed

3 files changed

+7
-19
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: e90959e58bdf1a3685836987f85baf206b93fcf9
2+
refs/heads/master: f472403650e3f321b2dea893d890929af309695b
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: ba0e1cd8147d452c356aacb29fb87568ca26f111
55
refs/heads/try: 7b4ef47b7805a402d756fb8157101f64880a522f

trunk/mk/docs.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ ERR_IDX_GEN = $(RPATH_VAR2_T_$(CFG_BUILD)_H_$(CFG_BUILD)) $(ERR_IDX_GEN_EXE)
7777

7878
D := $(S)src/doc
7979

80-
DOC_TARGETS := trpl style error-index
80+
# FIXME (#25705) eventually may want to put error-index target back here.
81+
DOC_TARGETS := trpl style
8182
COMPILER_DOC_TARGETS :=
8283
DOC_L10N_TARGETS :=
8384

trunk/src/libsyntax/diagnostics/plugin.rs

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ use std::collections::BTreeMap;
1414
use ast;
1515
use ast::{Ident, Name, TokenTree};
1616
use codemap::Span;
17-
use diagnostics::metadata::{check_uniqueness, output_metadata, Duplicate};
1817
use ext::base::{ExtCtxt, MacEager, MacResult};
1918
use ext::build::AstBuilder;
2019
use parse::token;
@@ -148,7 +147,7 @@ pub fn expand_build_diagnostic_array<'cx>(ecx: &'cx mut ExtCtxt,
148147
token_tree: &[TokenTree])
149148
-> Box<MacResult+'cx> {
150149
assert_eq!(token_tree.len(), 3);
151-
let (crate_name, name) = match (&token_tree[0], &token_tree[2]) {
150+
let (_crate_name, name) = match (&token_tree[0], &token_tree[2]) {
152151
(
153152
// Crate name.
154153
&ast::TtToken(_, token::Ident(ref crate_name, _)),
@@ -158,21 +157,9 @@ pub fn expand_build_diagnostic_array<'cx>(ecx: &'cx mut ExtCtxt,
158157
_ => unreachable!()
159158
};
160159

161-
// Check uniqueness of errors and output metadata.
162-
with_registered_diagnostics(|diagnostics| {
163-
match check_uniqueness(crate_name, &*diagnostics) {
164-
Ok(Duplicate(err, location)) => {
165-
ecx.span_err(span, &format!(
166-
"error {} from `{}' also found in `{}'",
167-
err, crate_name, location
168-
));
169-
},
170-
Ok(_) => (),
171-
Err(e) => panic!("{}", e.description())
172-
}
173-
174-
output_metadata(&*ecx, crate_name, &*diagnostics).ok().expect("metadata output error");
175-
});
160+
// FIXME (#25705): we used to ensure error code uniqueness and
161+
// output error description JSON metadata here, but the approach
162+
// employed was too brittle.
176163

177164
// Construct the output expression.
178165
let (count, expr) =

0 commit comments

Comments
 (0)