Skip to content

Commit 1d1400b

Browse files
Mark-SimulacrumMark-Simulacrum
authored
Add triage for 2023-09-19 (#1723)
1 parent b57ed2f commit 1d1400b

File tree

1 file changed

+92
-0
lines changed

1 file changed

+92
-0
lines changed

‎triage/2023-09-19.md

Lines changed: 92 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
1+
# 2023-09-19 Triage Log
2+
3+
A pretty quiet week, with relatively few statistically significant changes, though some good improvements to a number of benchmarks, particularly in cycle counts rather than instructions.
4+
5+
Triage done by **@simulacrum**.
6+
Revision range: [7e0261e7ea2085bdc0bc3d0fd6776bf343473858..af78bae565e85b9c5698ee909af0652674eca6d4](https://perf.rust-lang.org/?start=7e0261e7ea2085bdc0bc3d0fd6776bf343473858&end=af78bae565e85b9c5698ee909af0652674eca6d4&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.5% | [0.3%, 0.8%] | 14 |
13+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 0.8%] | 5 |
14+
| Improvements ✅ <br /> (primary) | -1.2% | [-6.4%, -0.3%] | 22 |
15+
| Improvements ✅ <br /> (secondary) | -2.1% | [-8.1%, -0.2%] | 37 |
16+
| All ❌✅ (primary) | -0.5% | [-6.4%, 0.8%] | 36 |
17+
18+
3 Regressions, 3 Improvements, 2 Mixed; 2 of them in rollups
19+
56 artifact comparisons made in total
20+
21+
#### Regressions
22+
23+
Accept additional user-defined syntax classes in fenced code blocks [#110800](https://github.com/rust-lang/rust/pull/110800) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=42dead4d23309234802390aca16763f353920cf6&end=41bafc4ff3eb6a73aa40e60c3bd4494302c7ec57&stat=instructions:u)
24+
25+
| (instructions:u) | mean | range | count |
26+
|:----------------------------------:|:----:|:------------:|:-----:|
27+
| Regressions ❌ <br /> (primary) | 0.7% | [0.5%, 0.9%] | 3 |
28+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.5%, 1.4%] | 3 |
29+
| Improvements ✅ <br /> (primary) | - | - | 0 |
30+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
31+
| All ❌✅ (primary) | 0.7% | [0.5%, 0.9%] | 3 |
32+
33+
Some slight regressions, limited to doc benchmarks, for a new feature in rustdoc.
34+
35+
Store a index per dep node kind [#115733](https://github.com/rust-lang/rust/pull/115733) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4514fb98d58eb0bcd65a16266875ef031c373cdf&end=341ef15eeed243dce9a30e800173450393bf776b&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.5%] | 9 |
40+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.5%] | 6 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.4% | [0.2%, 0.5%] | 9 |
44+
45+
Slight instruction regressions but overall an improvement -- max-rss and cycle
46+
counts are both down in aggregate.
47+
48+
#### Improvements
49+
50+
Rollup of 6 pull requests [#115909](https://github.com/rust-lang/rust/pull/115909) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8ed1d4a02ddd840a1efaca4e5e66881cbec5b0b3&end=db9c21fd944b942a3a83e1fbce0d7c1c9164bc2a&stat=instructions:u)
51+
52+
| (instructions:u) | mean | range | count |
53+
|:----------------------------------:|:-----:|:--------------:|:-----:|
54+
| Regressions ❌ <br /> (primary) | - | - | 0 |
55+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
56+
| Improvements ✅ <br /> (primary) | -0.6% | [-1.0%, -0.5%] | 6 |
57+
| Improvements ✅ <br /> (secondary) | -1.1% | [-1.5%, -0.4%] | 19 |
58+
| All ❌✅ (primary) | -0.6% | [-1.0%, -0.5%] | 6 |
59+
60+
61+
Rollup of 8 pull requests [#115929](https://github.com/rust-lang/rust/pull/115929) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=078eb1120a3f576598b976d9470701363f48fccc&end=de68911f4adaed19ac662880cf1a5ded9e44d685&stat=instructions:u)
62+
63+
| (instructions:u) | mean | range | count |
64+
|:----------------------------------:|:-----:|:--------------:|:-----:|
65+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
66+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
67+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.7%, -0.2%] | 19 |
68+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.2%] | 12 |
69+
| All ❌✅ (primary) | -0.4% | [-0.7%, 0.2%] | 20 |
70+
71+
72+
move required_consts check to general post-mono-check function [#115748](https://github.com/rust-lang/rust/pull/115748) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b1575cb72ef40459666f802af8636faf8428e3eb&end=cebb9cfd4f0052fbb5e98f9b6f3a61dae8fd96a7&stat=instructions:u)
73+
74+
| (instructions:u) | mean | range | count |
75+
|:----------------------------------:|:-----:|:--------------:|:-----:|
76+
| Regressions ❌ <br /> (primary) | - | - | 0 |
77+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.5%] | 1 |
78+
| Improvements ✅ <br /> (primary) | -5.0% | [-6.3%, -3.6%] | 2 |
79+
| Improvements ✅ <br /> (secondary) | -6.1% | [-6.6%, -5.7%] | 6 |
80+
| All ❌✅ (primary) | -5.0% | [-6.3%, -3.6%] | 2 |
81+
82+
Cache reachable_set on disk [#115740](https://github.com/rust-lang/rust/pull/115740) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=790309b102a0f0459f0ca0ac0386cec2b8a9b0db&end=fd70f7eea23636d4ce83656f5c8c2b24cd56998c&stat=instructions:u)
83+
84+
| (instructions:u) | mean | range | count |
85+
|:----------------------------------:|:-----:|:--------------:|:-----:|
86+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 1 |
87+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.6%] | 4 |
88+
| Improvements ✅ <br /> (primary) | -1.0% | [-2.4%, -0.3%] | 8 |
89+
| Improvements ✅ <br /> (secondary) | -2.6% | [-8.2%, -0.8%] | 4 |
90+
| All ❌✅ (primary) | -0.9% | [-2.4%, 0.4%] | 9 |
91+
92+
Regressions are actually just noise, so moved this to improvements.

0 commit comments

Comments
 (0)