Skip to content

Commit 1d5043b

Browse files
committed
---
yaml --- r: 195442 b: refs/heads/master c: 4c1f5bd h: refs/heads/master v: v3
1 parent b97dac1 commit 1d5043b

File tree

18 files changed

+117
-322
lines changed

18 files changed

+117
-322
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 8225a1cf901e5ac12abcbc15c9f384ab9714524e
2+
refs/heads/master: 4c1f5bd6dc03116c20938d11800c0da8f1a84615
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: b3317d68910900f135f9f38e43a7a699bc736b4a
55
refs/heads/try: 961e0358e1a5c0faaef606e31e9965742c1643bf

trunk/src/doc/reference.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,15 +1188,12 @@ the guarantee that these issues are never caused by safe code.
11881188

11891189
* Data races
11901190
* Dereferencing a null/dangling raw pointer
1191+
* Mutating an immutable value/reference without `UnsafeCell`
11911192
* Reads of [undef](http://llvm.org/docs/LangRef.html#undefined-values)
11921193
(uninitialized) memory
11931194
* Breaking the [pointer aliasing
11941195
rules](http://llvm.org/docs/LangRef.html#pointer-aliasing-rules)
11951196
with raw pointers (a subset of the rules used by C)
1196-
* `&mut` and `&` follow LLVM’s scoped [noalias] model, except if the `&T`
1197-
contains an `UnsafeCell<U>`. Unsafe code must not violate these aliasing
1198-
guarantees.
1199-
* Mutating an immutable value/reference without `UnsafeCell<U>`
12001197
* Invoking undefined behavior via compiler intrinsics:
12011198
* Indexing outside of the bounds of an object with `std::ptr::offset`
12021199
(`offset` intrinsic), with
@@ -1213,8 +1210,6 @@ the guarantee that these issues are never caused by safe code.
12131210
code. Rust's failure system is not compatible with exception handling in
12141211
other languages. Unwinding must be caught and handled at FFI boundaries.
12151212

1216-
[noalias]: http://llvm.org/docs/LangRef.html#noalias
1217-
12181213
##### Behaviour not considered unsafe
12191214

12201215
This is a list of behaviour not considered *unsafe* in Rust terms, but that may

trunk/src/doc/trpl/method-syntax.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ parameter, of which there are three variants: `self`, `&self`, and `&mut self`.
5050
You can think of this first parameter as being the `x` in `x.foo()`. The three
5151
variants correspond to the three kinds of thing `x` could be: `self` if it's
5252
just a value on the stack, `&self` if it's a reference, and `&mut self` if it's
53-
a mutable reference. We should default to using `&self`, as you should prefer
54-
borrowing over taking ownership, as well as taking immutable references
55-
over mutable ones. Here's an example of all three variants:
53+
a mutable reference. We should default to using `&self`, as it's the most
54+
common, as Rustaceans prefer borrowing over taking ownership, and references
55+
over mutable references. Here's an example of all three variants:
5656

5757
```rust
5858
struct Circle {

trunk/src/doc/trpl/ownership.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -472,15 +472,10 @@ thread-safe counterpart of `Rc<T>`.
472472

473473
## Lifetime Elision
474474

475-
Rust supports powerful local type inference in function bodies, but it’s
476-
forbidden in item signatures to allow reasoning about the types just based in
477-
the item signature alone. However, for ergonomic reasons a very restricted
478-
secondary inference algorithm called “lifetime elision” applies in function
479-
signatures. It infers only based on the signature components themselves and not
480-
based on the body of the function, only infers lifetime paramters, and does
481-
this with only three easily memorizable and unambiguous rules. This makes
482-
lifetime elision a shorthand for writing an item signature, while not hiding
483-
away the actual types involved as full local inference would if applied to it.
475+
Earlier, we mentioned *lifetime elision*, a feature of Rust which allows you to
476+
not write lifetime annotations in certain circumstances. All references have a
477+
lifetime, and so if you elide a lifetime (like `&T` instead of `&'a T`), Rust
478+
will do three things to determine what those lifetimes should be.
484479

485480
When talking about lifetime elision, we use the term *input lifetime* and
486481
*output lifetime*. An *input lifetime* is a lifetime associated with a parameter

trunk/src/doc/trpl/testing.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ pub fn add_two(a: i32) -> i32 {
231231
}
232232
233233
#[cfg(test)]
234-
mod test {
234+
mod tests {
235235
use super::add_two;
236236
237237
#[test]
@@ -241,7 +241,7 @@ mod test {
241241
}
242242
```
243243

244-
There's a few changes here. The first is the introduction of a `mod test` with
244+
There's a few changes here. The first is the introduction of a `mod tests` with
245245
a `cfg` attribute. The module allows us to group all of our tests together, and
246246
to also define helper functions if needed, that don't become a part of the rest
247247
of our crate. The `cfg` attribute only compiles our test code if we're
@@ -260,7 +260,7 @@ pub fn add_two(a: i32) -> i32 {
260260
}
261261
262262
#[cfg(test)]
263-
mod test {
263+
mod tests {
264264
use super::*;
265265
266266
#[test]

trunk/src/libcollections/string.rs

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,27 +1019,44 @@ impl AsRef<str> for String {
10191019

10201020
#[stable(feature = "rust1", since = "1.0.0")]
10211021
impl<'a> From<&'a str> for String {
1022+
#[inline]
10221023
fn from(s: &'a str) -> String {
10231024
s.to_string()
10241025
}
10251026
}
10261027

1028+
#[stable(feature = "rust1", since = "1.0.0")]
1029+
impl<'a> From<&'a str> for Cow<'a, str> {
1030+
#[inline]
1031+
fn from(s: &'a str) -> Cow<'a, str> {
1032+
Cow::Borrowed(s)
1033+
}
1034+
}
1035+
1036+
#[stable(feature = "rust1", since = "1.0.0")]
1037+
impl<'a> From<String> for Cow<'a, str> {
1038+
#[inline]
1039+
fn from(s: String) -> Cow<'a, str> {
1040+
Cow::Owned(s)
1041+
}
1042+
}
1043+
10271044
#[stable(feature = "rust1", since = "1.0.0")]
10281045
impl Into<Vec<u8>> for String {
10291046
fn into(self) -> Vec<u8> {
10301047
self.into_bytes()
10311048
}
10321049
}
10331050

1034-
#[stable(feature = "rust1", since = "1.0.0")]
1051+
#[unstable(feature = "into_cow", reason = "may be replaced by `convert::Into`")]
10351052
impl IntoCow<'static, str> for String {
10361053
#[inline]
10371054
fn into_cow(self) -> Cow<'static, str> {
10381055
Cow::Owned(self)
10391056
}
10401057
}
10411058

1042-
#[stable(feature = "rust1", since = "1.0.0")]
1059+
#[unstable(feature = "into_cow", reason = "may be replaced by `convert::Into`")]
10431060
impl<'a> IntoCow<'a, str> for &'a str {
10441061
#[inline]
10451062
fn into_cow(self) -> Cow<'a, str> {

trunk/src/libcore/error.rs

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -48,30 +48,33 @@
4848
//! For example,
4949
//!
5050
//! ```
51-
//! #![feature(core)]
51+
//! # #![feature(os, old_io, old_path)]
5252
//! use std::error::FromError;
53-
//! use std::{io, str};
54-
//! use std::fs::File;
53+
//! use std::old_io::{File, IoError};
54+
//! use std::os::{MemoryMap, MapError};
55+
//! use std::old_path::Path;
5556
//!
5657
//! enum MyError {
57-
//! Io(io::Error),
58-
//! Utf8(str::Utf8Error),
58+
//! Io(IoError),
59+
//! Map(MapError)
5960
//! }
6061
//!
61-
//! impl FromError<io::Error> for MyError {
62-
//! fn from_error(err: io::Error) -> MyError { MyError::Io(err) }
62+
//! impl FromError<IoError> for MyError {
63+
//! fn from_error(err: IoError) -> MyError {
64+
//! MyError::Io(err)
65+
//! }
6366
//! }
6467
//!
65-
//! impl FromError<str::Utf8Error> for MyError {
66-
//! fn from_error(err: str::Utf8Error) -> MyError { MyError::Utf8(err) }
68+
//! impl FromError<MapError> for MyError {
69+
//! fn from_error(err: MapError) -> MyError {
70+
//! MyError::Map(err)
71+
//! }
6772
//! }
6873
//!
6974
//! #[allow(unused_variables)]
7075
//! fn open_and_map() -> Result<(), MyError> {
71-
//! let b = b"foo.txt";
72-
//! let s = try!(str::from_utf8(b));
73-
//! let f = try!(File::open(s));
74-
//!
76+
//! let f = try!(File::open(&Path::new("foo.txt")));
77+
//! let m = try!(MemoryMap::new(0, &[]));
7578
//! // do something interesting here...
7679
//! Ok(())
7780
//! }

trunk/src/libcore/option.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ impl<T> Option<T> {
333333
}
334334
}
335335

336-
/// Moves the value `v` out of the `Option<T>` if it is `Some(v)`.
336+
/// Moves the value `v` out of the `Option<T>` if the content of the `Option<T>` is a `Some(v)`.
337337
///
338338
/// # Panics
339339
///

trunk/src/librustc/middle/expr_use_visitor.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -885,11 +885,6 @@ impl<'d,'t,'tcx,TYPER:mc::Typer<'tcx>> ExprUseVisitor<'d,'t,'tcx,TYPER> {
885885
}
886886
}
887887

888-
// When this returns true, it means that the expression *is* a
889-
// method-call (i.e. via the operator-overload). This true result
890-
// also implies that walk_overloaded_operator already took care of
891-
// recursively processing the input arguments, and thus the caller
892-
// should not do so.
893888
fn walk_overloaded_operator(&mut self,
894889
expr: &ast::Expr,
895890
receiver: &ast::Expr,

0 commit comments

Comments
 (0)