---

yaml
---
r: 105403
b: refs/heads/master
c: 6b2888a
h: refs/heads/master
i:
  105401: 83a8c57
  105399: 4064360
v: v3

Author: alan-andrade

[refs]

@@ -1,5 +1,5 @@
 ---
-refs/heads/master: ffe72e95368aba02d002be0095522548e8f0ee79
+refs/heads/master: 6b2888aeec08c56200ed26576eafb2d27ca079b8
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: b8601a3d8b91ad3b653d143307611f2f5c75617e
 refs/heads/try: db814977d07bd798feb24f6b74c00800ef458a13

trunk/src/libgetopts/lib.rs

@@ -98,27 +98,34 @@ use std::vec;
 
 /// Name of an option. Either a string or a single char.
 #[deriving(Clone, Eq)]
-#[allow(missing_doc)]
 pub enum Name {
+    /// A string representing the long name of an option.
+    /// For example: "help"
     Long(~str),
+    /// A char representing the short name of an option.
+    /// For example: 'h'
     Short(char),
 }
 
 /// Describes whether an option has an argument.
 #[deriving(Clone, Eq)]
-#[allow(missing_doc)]
 pub enum HasArg {
+    /// The option requires an argument.
     Yes,
+    /// The option is just a flag, therefore no argument.
     No,
+    /// The option argument is optional and it could or not exist.
     Maybe,
 }
 
 /// Describes how often an option may occur.
 #[deriving(Clone, Eq)]
-#[allow(missing_doc)]
 pub enum Occur {
+    /// The option occurs once.
     Req,
+    /// The option could or not occur.
     Optional,
+    /// The option occurs once or multiple times.
     Multi,
 }
 
@@ -176,12 +183,16 @@ pub struct Matches {
 /// expected format. Call the `to_err_msg` method to retrieve the
 /// error as a string.
 #[deriving(Clone, Eq, Show)]
-#[allow(missing_doc)]
 pub enum Fail_ {
+    /// The option requires an argument but none was passed.
     ArgumentMissing(~str),
+    /// The passed option is not declared among the possible options.
     UnrecognizedOption(~str),
+    /// A required option is not present.
     OptionMissing(~str),
+    /// A single occurence option is being used multiple times.
     OptionDuplicated(~str),
+    /// There's an argument being passed to a non-argument option.
     UnexpectedArgument(~str),
 }
 

trunk/src/librustc/middle/typeck/check/mod.rs

@@ -2317,13 +2317,11 @@ fn check_expr_with_unifier(fcx: @FnCtxt,
                 fcx.type_error_message(
                     expr.span,
                     |actual| {
-                        format!("attempted to take value of method `{}` on type `{}`",
+                        format!("attempted to take value of method `{}` on type `{}` \
+                                 (try writing an anonymous function)",
                                 token::get_name(field), actual)
                     },
                     expr_t, None);
-
-                tcx.sess.span_note(expr.span,
-                    "maybe a missing `()` to call it? If not, try an anonymous function.");
             }
 
             None => {

trunk/src/libstd/option.rs

@@ -311,10 +311,10 @@ impl<T> Option<T> {
     /// Fails if the value equals `None`.
     #[inline]
     pub fn take_unwrap(&mut self) -> T {
-        match self.take() {
-            Some(x) => x,
-            None => fail!("called `Option::take_unwrap()` on a `None` value")
+        if self.is_none() {
+            fail!("called `Option::take_unwrap()` on a `None` value")
         }
+        self.take().unwrap()
     }
 
     /// Gets an immutable reference to the value inside an option.

trunk/src/libtime/lib.rs

@@ -187,51 +187,20 @@ pub fn tzset() {
     }
 }
 
-/// Holds a calendar date and time broken down into its components (year, month, day, and so on),
-/// also called a broken-down time value.
 #[deriving(Clone, Eq, Encodable, Decodable, Show)]
 pub struct Tm {
-    /// Seconds after the minute – [0, 60]
-    tm_sec: i32,
-
-    /// Minutes after the hour – [0, 59]
-    tm_min: i32,
-
-    /// Hours after midnight – [0, 23]
-    tm_hour: i32,
-
-    /// Day of the month – [1, 31]
-    tm_mday: i32,
-
-    /// Months since January – [0, 11]
-    tm_mon: i32,
-
-    /// Years since 1900
-    tm_year: i32,
-
-    /// Days since Sunday – [0, 6]. 0 = Sunday, 1 = Monday, …, 6 = Saturday.
-    tm_wday: i32,
-
-    /// Days since January 1 – [0, 365]
-    tm_yday: i32,
-
-    /// Daylight Saving Time flag.
-    ///
-    /// This value is positive if Daylight Saving Time is in effect, zero if Daylight Saving Time
-    /// is not in effect, and negative if this information is not available.
-    tm_isdst: i32,
-
-    /// Identifies the time zone that was used to compute this broken-down time value, including any
-    /// adjustment for Daylight Saving Time. This is the number of seconds east of UTC. For example,
-    /// for U.S. Pacific Daylight Time, the value is -7*60*60 = -25200.
-    tm_gmtoff: i32,
-
-    /// Abbreviated name for the time zone that was used to compute this broken-down time value.
-    /// For example, U.S. Pacific Daylight Time is "PDT".
-    tm_zone: ~str,
-
-    /// Nanoseconds after the second – [0, 10<sup>9</sup> - 1]
-    tm_nsec: i32,
+    tm_sec: i32, // seconds after the minute ~[0-60]
+    tm_min: i32, // minutes after the hour ~[0-59]
+    tm_hour: i32, // hours after midnight ~[0-23]
+    tm_mday: i32, // days of the month ~[1-31]
+    tm_mon: i32, // months since January ~[0-11]
+    tm_year: i32, // years since 1900
+    tm_wday: i32, // days since Sunday ~[0-6]
+    tm_yday: i32, // days since January 1 ~[0-365]
+    tm_isdst: i32, // Daylight Savings Time flag
+    tm_gmtoff: i32, // offset from UTC in seconds
+    tm_zone: ~str, // timezone abbreviation
+    tm_nsec: i32, // nanoseconds
 }
 
 pub fn empty_tm() -> Tm {

trunk/src/test/compile-fail/method-missing-call.rs

@@ -13,10 +13,6 @@
 // ignore-android needs extra network permissions
 // exec-env:RUST_LOG=debug
 
-#[feature(phase)];
-#[phase(syntax, link)]
-extern crate log;
-
 use std::libc;
 use std::io::net::ip::{Ipv4Addr, SocketAddr};
 use std::io::net::tcp::{TcpListener, TcpStream};