---

yaml
---
r: 15811
b: refs/heads/try
c: c424b7f
h: refs/heads/master
i:
  15809: 8cc8a2c
  15807: a07f342
v: v3

Author: brson

[refs]

@@ -2,5 +2,5 @@
 refs/heads/master: 61b1875c16de39c166b0f4d54bba19f9c6777d1a
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
-refs/heads/try: 7277cd71984e6a09bc2f8a8a828a5e213b485d00
+refs/heads/try: c424b7f847bbec50d01b00a89e044d80b8eb59f8
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105

branches/try/src/libcore/comm.rs

@@ -93,25 +93,27 @@ fn listen<T: send, U>(f: fn(chan<T>) -> U) -> U {
     f(po.chan())
 }
 
-resource port_ptr<T: send>(po: *rust_port) {
-    // Once the port is detached it's guaranteed not to receive further
-    // messages
-    let yield = 0u;
-    let yieldp = ptr::addr_of(yield);
-    rustrt::rust_port_begin_detach(po, yieldp);
-    if yield != 0u {
-        // Need to wait for the port to be detached
-        // FIXME: If this fails then we're going to leave our port
-        // in a bogus state. (Issue #1988)
-        task::yield();
-    }
-    rustrt::rust_port_end_detach(po);
+resource port_ptr<T: send>(po: *rust_port) unsafe {
+    task::unkillable {||
+        // Once the port is detached it's guaranteed not to receive further
+        // messages
+        let yield = 0u;
+        let yieldp = ptr::addr_of(yield);
+        rustrt::rust_port_begin_detach(po, yieldp);
+        if yield != 0u {
+            // Need to wait for the port to be detached
+            // FIXME: If this fails then we're going to leave our port
+            // in a bogus state. (Issue #1988)
+            task::yield();
+        }
+        rustrt::rust_port_end_detach(po);
 
-    // Drain the port so that all the still-enqueued items get dropped
-    while rustrt::rust_port_size(po) > 0u {
-       recv_::<T>(po);
+        // Drain the port so that all the still-enqueued items get dropped
+        while rustrt::rust_port_size(po) > 0u {
+            recv_::<T>(po);
+        }
+        rustrt::del_port(po);
     }
-    rustrt::del_port(po);
 }
 
 #[doc = "
@@ -458,4 +460,25 @@ fn test_listen() {
         }
         assert parent.recv() == "oatmeal-salad";
     }
+}
+
+#[test]
+#[ignore(cfg(target_os="win32"))]
+fn test_port_detach_fail() {
+    iter::repeat(100u) {||
+        let builder = task::builder();
+        task::unsupervise(builder);
+        task::run(builder) {||
+            let po = port();
+            let ch = po.chan();
+
+            task::spawn {||
+                fail;
+            }
+
+            task::spawn {||
+                ch.send(());
+            }
+        }
+    }
 }