Skip to content

Commit 2822e8a

Browse files
rylevrylev
authored
Add triage for 2023-09-26 (#1726)
Signed-off-by: Ryan Levick <[email protected]>
1 parent 2a9fade commit 2822e8a

File tree

1 file changed

+130
-0
lines changed

1 file changed

+130
-0
lines changed

‎triage/2023-09-26.md

Lines changed: 130 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,130 @@
1+
# 2023-09-26 Triage Log
2+
3+
A very quiet week with the only large change in performance being improvements brought on by @saethlin's work on cleaning up the `FileEncoder` used in various places like `rustc_metadata` and `rustc_serialize`.
4+
5+
Triage done by **@rylev**.
6+
Revision range: [af78bae..27b4eb9](https://perf.rust-lang.org/?start=af78bae565e85b9c5698ee909af0652674eca6d4&end=27b4eb96d13106332d511be2ea6d0c008a57aa6e&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.6% | [0.3%, 1.1%] | 15 |
13+
| Regressions ❌ <br /> (secondary) | 2.0% | [0.2%, 7.1%] | 32 |
14+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.3%, -0.3%] | 70 |
15+
| Improvements ✅ <br /> (secondary) | -0.9% | [-3.5%, -0.2%] | 31 |
16+
| All ❌✅ (primary) | -0.4% | [-1.3%, 1.1%] | 85 |
17+
18+
19+
2 Regressions, 3 Improvements, 4 Mixed; 0 of them in rollups
20+
73 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Fix `ui-fulldeps --stage=1` with `-Zignore-directory-in-diagnostics-source-blocks` [#116009](https://github.com/rust-lang/rust/pull/116009) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4fda889bf8735755573b27e6116ce025f3ded5f9&end=0a689c1be85d635bf61ffb7922ef9ce02587a3b1&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.5%] | 3 |
29+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.4% | [0.4%, 0.5%] | 3 |
33+
- This only modified tests so this is noise
34+
35+
36+
rustdoc: correctly render the return type of cross-crate async fns [#116084](https://github.com/rust-lang/rust/pull/116084) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6f13ea0d1a0687073d36b5b1f7dd0e41e67665fb&end=0288f2e1955b154262e0669ec5f7bb9a4c6cf5aa&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:----:|:------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.8%] | 9 |
41+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.3%, 0.9%] | 17 |
42+
| Improvements ✅ <br /> (primary) | - | - | 0 |
43+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
44+
| All ❌✅ (primary) | 0.4% | [0.3%, 0.8%] | 9 |
45+
46+
47+
#### Improvements
48+
49+
Pretty-print argument-position impl trait to name it. [#113955](https://github.com/rust-lang/rust/pull/113955) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ac5ac4754a4a837f7138a1fa5ab01475b63fc9fe&end=bdb0fa3ee5ffb4cc1a1b53cbe8344a2b83b1ae2a&stat=instructions:u)
50+
51+
| (instructions:u) | mean | range | count |
52+
|:----------------------------------:|:-----:|:--------------:|:-----:|
53+
| Regressions ❌ <br /> (primary) | - | - | 0 |
54+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
55+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.7%] | 2 |
56+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 3 |
57+
| All ❌✅ (primary) | -0.7% | [-0.7%, -0.7%] | 2 |
58+
59+
60+
compiletest: load supported sanitizers from target spec [#115695](https://github.com/rust-lang/rust/pull/115695) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e4133ba9b1a150ef624f5d189913a37405f4414c&end=55b5c7bfde6247db5e4d2e3efe353e13849bb233&stat=instructions:u)
61+
62+
| (instructions:u) | mean | range | count |
63+
|:----------------------------------:|:-----:|:--------------:|:-----:|
64+
| Regressions ❌ <br /> (primary) | - | - | 0 |
65+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
66+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
67+
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.8%, -0.5%] | 6 |
68+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
69+
70+
71+
Do not create a DerefLen place for `Box<[T]>`. [#115794](https://github.com/rust-lang/rust/pull/115794) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8a6bae28247fbaa3257856e00d084ac8c90712f3&end=551c7183f8ae46c4b4fd0237acbdc937670bf74a&stat=instructions:u)
72+
73+
| (instructions:u) | mean | range | count |
74+
|:----------------------------------:|:-----:|:--------------:|:-----:|
75+
| Regressions ❌ <br /> (primary) | - | - | 0 |
76+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
77+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.6%] | 4 |
78+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.5%] | 3 |
79+
| All ❌✅ (primary) | -0.7% | [-0.7%, -0.6%] | 4 |
80+
81+
82+
#### Mixed
83+
84+
Simplify/Optimize FileEncoder [#115542](https://github.com/rust-lang/rust/pull/115542) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ad36b5a622b0d6d6f0f3260049b2245ee1f27a07&end=3223b0b5e8dadda3f76c3fd1a8d6c5addc09599e&stat=instructions:u)
85+
86+
| (instructions:u) | mean | range | count |
87+
|:----------------------------------:|:-----:|:--------------:|:-----:|
88+
| Regressions ❌ <br /> (primary) | 1.0% | [0.7%, 1.3%] | 2 |
89+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
90+
| Improvements ✅ <br /> (primary) | -0.6% | [-1.2%, -0.2%] | 95 |
91+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.2%, -0.3%] | 28 |
92+
| All ❌✅ (primary) | -0.6% | [-1.2%, 1.3%] | 97 |
93+
- looks like a small regression snuck back in. The regressions seem real, but perhaps it's not worth it given the much larger amount of improvements.
94+
95+
96+
Enable effects for libcore [#114776](https://github.com/rust-lang/rust/pull/114776) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aace2dfa37f4589b0071530d2ed7b352f6196704&end=8759de0a4935e677fdce99a849addea2d5318da9&stat=instructions:u)
97+
98+
| (instructions:u) | mean | range | count |
99+
|:----------------------------------:|:-----:|:--------------:|:-----:|
100+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.4%] | 4 |
101+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.3%, 0.8%] | 3 |
102+
| Improvements ✅ <br /> (primary) | - | - | 0 |
103+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 4 |
104+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.4%] | 4 |
105+
- Per Oli: The perf run shows a few extra executions of queries and metadata encoding, which seems unavoidable to me. We may get the perf back when ripping out the const checker's logic that is only needed until we enable effects by default for doing const fn callability checks
106+
107+
108+
Enable -Zdrop-tracking-mir by default [#107421](https://github.com/rust-lang/rust/pull/107421) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=19c65022fc1ad9cc3d3dcf50a0bdf50e4ab572ab&end=13e6f24b9adda67852fb86538541adaa68aff6e8&stat=instructions:u)
109+
110+
| (instructions:u) | mean | range | count |
111+
|:----------------------------------:|:-----:|:--------------:|:-----:|
112+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.5%] | 2 |
113+
| Regressions ❌ <br /> (secondary) | 4.5% | [0.3%, 6.5%] | 9 |
114+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
115+
| Improvements ✅ <br /> (secondary) | -2.5% | [-3.3%, -1.9%] | 5 |
116+
| All ❌✅ (primary) | 0.2% | [-0.4%, 0.5%] | 3 |
117+
- it seems the regressions to await-call-tree are real, but it's unclear what the underlying cause is.
118+
119+
120+
Add the `cfg_match!` macro [#115416](https://github.com/rust-lang/rust/pull/115416) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=42ca6e4e5760a548a6fa858482de6d237f6fb3b8&end=8a6bae28247fbaa3257856e00d084ac8c90712f3&stat=instructions:u)
121+
122+
| (instructions:u) | mean | range | count |
123+
|:----------------------------------:|:-----:|:--------------:|:-----:|
124+
| Regressions ❌ <br /> (primary) | 0.6% | [0.5%, 0.7%] | 4 |
125+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.6%] | 2 |
126+
| Improvements ✅ <br /> (primary) | -1.3% | [-1.3%, -1.3%] | 1 |
127+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
128+
| All ❌✅ (primary) | 0.2% | [-1.3%, 0.7%] | 5 |
129+
- This is noise
130+

0 commit comments

Comments
 (0)