Skip to content

Commit 291fe1a

Browse files
committed
---
yaml --- r: 35992 b: refs/heads/try2 c: 4e03ffd h: refs/heads/master v: v3
1 parent fa43a25 commit 291fe1a

File tree

4 files changed

+20
-27
lines changed

4 files changed

+20
-27
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ refs/heads/snap-stage3: eb8fd119c65c67f3b1b8268cc7341c22d39b7b61
55
refs/heads/try: d324a424d8f84b1eb049b12cf34182bda91b0024
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
8-
refs/heads/try2: 6ce4cf769f671c53f05e97357110d4c0ba322eae
8+
refs/heads/try2: 4e03ffdb6547d9541de84b61d7798b497235472b
99
refs/heads/incoming: d9317a174e434d4c99fc1a37fd7dc0d2f5328d37
1010
refs/heads/dist-snap: 22efa39382d41b084fde1719df7ae8ce5697d8c9
1111
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596

branches/try2/src/libcore/run.rs

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -248,14 +248,12 @@ pub fn start_program(prog: &str, args: &[~str]) -> Program {
248248
}
249249

250250
fn read_all(rd: io::Reader) -> ~str {
251-
let buf = io::with_bytes_writer(|wr| {
252-
let mut bytes = [mut 0, ..4096];
253-
while !rd.eof() {
254-
let nread = rd.read(bytes, bytes.len());
255-
wr.write(bytes.view(0, nread));
256-
}
257-
});
258-
str::from_bytes(buf)
251+
let mut buf = ~"";
252+
while !rd.eof() {
253+
let bytes = rd.read_bytes(4096u);
254+
buf += str::from_bytes(bytes);
255+
}
256+
move buf
259257
}
260258

261259
/**
@@ -343,15 +341,13 @@ fn writeclose(fd: c_int, s: ~str) {
343341
fn readclose(fd: c_int) -> ~str {
344342
let file = os::fdopen(fd);
345343
let reader = io::FILE_reader(file, false);
346-
let buf = io::with_bytes_writer(|writer| {
347-
let mut bytes = [mut 0, ..4096];
348-
while !reader.eof() {
349-
let nread = reader.read(bytes, bytes.len());
350-
writer.write(bytes.view(0, nread));
351-
}
352-
});
344+
let mut buf = ~"";
345+
while !reader.eof() {
346+
let bytes = reader.read_bytes(4096u);
347+
buf += str::from_bytes(bytes);
348+
}
353349
os::fclose(file);
354-
str::from_bytes(buf)
350+
move buf
355351
}
356352

357353
/// Waits for a process to exit and returns the exit code

branches/try2/src/rustc/middle/trans/build.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,7 @@ fn GEP(cx: block, Pointer: ValueRef, Indices: ~[ValueRef]) -> ValueRef {
433433
//
434434
// XXX: Use a small-vector optimization to avoid allocations here.
435435
fn GEPi(cx: block, base: ValueRef, ixs: &[uint]) -> ValueRef {
436-
let mut v: ~[ValueRef] = ~[];
437-
for vec::each(ixs) |i| { v.push(C_i32(*i as i32)); }
436+
let v = do vec::map(ixs) |i| { C_i32(*i as i32) };
438437
count_insn(cx, "gepi");
439438
return InBoundsGEP(cx, base, v);
440439
}

branches/try2/src/rustdoc/markdown_writer.rs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -136,15 +136,13 @@ fn readclose(fd: libc::c_int) -> ~str {
136136
// Copied from run::program_output
137137
let file = os::fdopen(fd);
138138
let reader = io::FILE_reader(file, false);
139-
let buf = io::with_bytes_writer(|writer| {
140-
let mut bytes = [mut 0, ..4096];
141-
while !reader.eof() {
142-
let nread = reader.read(bytes, bytes.len());
143-
writer.write(bytes.view(0, nread));
144-
}
145-
});
139+
let mut buf = ~"";
140+
while !reader.eof() {
141+
let bytes = reader.read_bytes(4096u);
142+
buf += str::from_bytes(bytes);
143+
}
146144
os::fclose(file);
147-
str::from_bytes(buf)
145+
return buf;
148146
}
149147
150148
fn generic_writer(+process: fn~(markdown: ~str)) -> Writer {

0 commit comments

Comments
 (0)