Skip to content

Commit 2a92efd

Browse files
committed
[CodeComplete] drop unused Scope param. NFC
1 parent 1379eb5 commit 2a92efd

File tree

8 files changed

+20
-22
lines changed

8 files changed

+20
-22
lines changed

clang/include/clang/Sema/Sema.h

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12537,17 +12537,16 @@ class Sema final {
1253712537
/// signatures that were considered.
1253812538
///
1253912539
/// FIXME: rename to GuessCallArgumentType to reduce confusion.
12540-
QualType ProduceCallSignatureHelp(Scope *S, Expr *Fn, ArrayRef<Expr *> Args,
12540+
QualType ProduceCallSignatureHelp(Expr *Fn, ArrayRef<Expr *> Args,
1254112541
SourceLocation OpenParLoc);
12542-
QualType ProduceConstructorSignatureHelp(Scope *S, QualType Type,
12543-
SourceLocation Loc,
12542+
QualType ProduceConstructorSignatureHelp(QualType Type, SourceLocation Loc,
1254412543
ArrayRef<Expr *> Args,
1254512544
SourceLocation OpenParLoc,
1254612545
bool Braced);
1254712546
QualType ProduceCtorInitMemberSignatureHelp(
12548-
Scope *S, Decl *ConstructorDecl, CXXScopeSpec SS,
12549-
ParsedType TemplateTypeTy, ArrayRef<Expr *> ArgExprs, IdentifierInfo *II,
12550-
SourceLocation OpenParLoc, bool Braced);
12547+
Decl *ConstructorDecl, CXXScopeSpec SS, ParsedType TemplateTypeTy,
12548+
ArrayRef<Expr *> ArgExprs, IdentifierInfo *II, SourceLocation OpenParLoc,
12549+
bool Braced);
1255112550
QualType ProduceTemplateArgumentSignatureHelp(
1255212551
TemplateTy, ArrayRef<ParsedTemplateArgument>, SourceLocation LAngleLoc);
1255312552
void CodeCompleteInitializer(Scope *S, Decl *D);

clang/lib/Parse/ParseDecl.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2419,7 +2419,7 @@ Decl *Parser::ParseDeclarationAfterDeclaratorAndAttributes(
24192419
auto ThisVarDecl = dyn_cast_or_null<VarDecl>(ThisDecl);
24202420
auto RunSignatureHelp = [&]() {
24212421
QualType PreferredType = Actions.ProduceConstructorSignatureHelp(
2422-
getCurScope(), ThisVarDecl->getType()->getCanonicalTypeInternal(),
2422+
ThisVarDecl->getType()->getCanonicalTypeInternal(),
24232423
ThisDecl->getLocation(), Exprs, T.getOpenLocation(),
24242424
/*Braced=*/false);
24252425
CalledSignatureHelp = true;
@@ -2440,7 +2440,7 @@ Decl *Parser::ParseDeclarationAfterDeclaratorAndAttributes(
24402440
if (ParseExpressionList(Exprs, CommaLocs, ExpressionStarts)) {
24412441
if (ThisVarDecl && PP.isCodeCompletionReached() && !CalledSignatureHelp) {
24422442
Actions.ProduceConstructorSignatureHelp(
2443-
getCurScope(), ThisVarDecl->getType()->getCanonicalTypeInternal(),
2443+
ThisVarDecl->getType()->getCanonicalTypeInternal(),
24442444
ThisDecl->getLocation(), Exprs, T.getOpenLocation(),
24452445
/*Braced=*/false);
24462446
CalledSignatureHelp = true;

clang/lib/Parse/ParseDeclCXX.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3740,8 +3740,8 @@ MemInitResult Parser::ParseMemInitializer(Decl *ConstructorDecl) {
37403740
if (TemplateTypeTy.isInvalid())
37413741
return QualType();
37423742
QualType PreferredType = Actions.ProduceCtorInitMemberSignatureHelp(
3743-
getCurScope(), ConstructorDecl, SS, TemplateTypeTy.get(), ArgExprs,
3744-
II, T.getOpenLocation(), /*Braced=*/false);
3743+
ConstructorDecl, SS, TemplateTypeTy.get(), ArgExprs, II,
3744+
T.getOpenLocation(), /*Braced=*/false);
37453745
CalledSignatureHelp = true;
37463746
return PreferredType;
37473747
};

clang/lib/Parse/ParseExpr.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2019,7 +2019,7 @@ Parser::ParsePostfixExpressionSuffix(ExprResult LHS) {
20192019
CommaLocsTy CommaLocs;
20202020
auto RunSignatureHelp = [&]() -> QualType {
20212021
QualType PreferredType = Actions.ProduceCallSignatureHelp(
2022-
getCurScope(), LHS.get(), ArgExprs, PT.getOpenLocation());
2022+
LHS.get(), ArgExprs, PT.getOpenLocation());
20232023
CalledSignatureHelp = true;
20242024
return PreferredType;
20252025
};

clang/lib/Parse/ParseExprCXX.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1877,8 +1877,8 @@ Parser::ParseCXXTypeConstructExpression(const DeclSpec &DS) {
18771877
QualType PreferredType;
18781878
if (TypeRep)
18791879
PreferredType = Actions.ProduceConstructorSignatureHelp(
1880-
getCurScope(), TypeRep.get()->getCanonicalTypeInternal(),
1881-
DS.getEndLoc(), Exprs, T.getOpenLocation(), /*Braced=*/false);
1880+
TypeRep.get()->getCanonicalTypeInternal(), DS.getEndLoc(), Exprs,
1881+
T.getOpenLocation(), /*Braced=*/false);
18821882
CalledSignatureHelp = true;
18831883
return PreferredType;
18841884
};
@@ -3167,7 +3167,7 @@ Parser::ParseCXXNewExpression(bool UseGlobal, SourceLocation Start) {
31673167
// `new decltype(invalid) (^)`.
31683168
if (TypeRep)
31693169
PreferredType = Actions.ProduceConstructorSignatureHelp(
3170-
getCurScope(), TypeRep.get()->getCanonicalTypeInternal(),
3170+
TypeRep.get()->getCanonicalTypeInternal(),
31713171
DeclaratorInfo.getEndLoc(), ConstructorArgs, ConstructorLParen,
31723172
/*Braced=*/false);
31733173
CalledSignatureHelp = true;

clang/lib/Parse/ParseInit.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,8 +466,8 @@ ExprResult Parser::ParseBraceInitializer() {
466466
QualType PreferredType;
467467
if (!LikelyType.isNull())
468468
PreferredType = Actions.ProduceConstructorSignatureHelp(
469-
getCurScope(), LikelyType->getCanonicalTypeInternal(),
470-
T.getOpenLocation(), InitExprs, T.getOpenLocation(), /*Braced=*/true);
469+
LikelyType->getCanonicalTypeInternal(), T.getOpenLocation(),
470+
InitExprs, T.getOpenLocation(), /*Braced=*/true);
471471
CalledSignatureHelp = true;
472472
return PreferredType;
473473
};

clang/lib/Parse/ParseOpenMP.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,7 @@ void Parser::ParseOpenMPReductionInitializerForDecl(VarDecl *OmpPrivParm) {
470470
SourceLocation LParLoc = T.getOpenLocation();
471471
auto RunSignatureHelp = [this, OmpPrivParm, LParLoc, &Exprs]() {
472472
QualType PreferredType = Actions.ProduceConstructorSignatureHelp(
473-
getCurScope(), OmpPrivParm->getType()->getCanonicalTypeInternal(),
473+
OmpPrivParm->getType()->getCanonicalTypeInternal(),
474474
OmpPrivParm->getLocation(), Exprs, LParLoc, /*Braced=*/false);
475475
CalledSignatureHelp = true;
476476
return PreferredType;

clang/lib/Sema/SemaCodeComplete.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5956,8 +5956,7 @@ ProduceSignatureHelp(Sema &SemaRef, MutableArrayRef<ResultCandidate> Candidates,
59565956
return getParamType(SemaRef, Candidates, CurrentArg);
59575957
}
59585958

5959-
QualType Sema::ProduceCallSignatureHelp(Scope *S, Expr *Fn,
5960-
ArrayRef<Expr *> Args,
5959+
QualType Sema::ProduceCallSignatureHelp(Expr *Fn, ArrayRef<Expr *> Args,
59615960
SourceLocation OpenParLoc) {
59625961
Fn = unwrapParenList(Fn);
59635962
if (!CodeCompleter || !Fn)
@@ -6059,7 +6058,7 @@ QualType Sema::ProduceCallSignatureHelp(Scope *S, Expr *Fn,
60596058
return !CandidateSet.empty() ? ParamType : QualType();
60606059
}
60616060

6062-
QualType Sema::ProduceConstructorSignatureHelp(Scope *S, QualType Type,
6061+
QualType Sema::ProduceConstructorSignatureHelp(QualType Type,
60636062
SourceLocation Loc,
60646063
ArrayRef<Expr *> Args,
60656064
SourceLocation OpenParLoc,
@@ -6112,7 +6111,7 @@ QualType Sema::ProduceConstructorSignatureHelp(Scope *S, QualType Type,
61126111
}
61136112

61146113
QualType Sema::ProduceCtorInitMemberSignatureHelp(
6115-
Scope *S, Decl *ConstructorDecl, CXXScopeSpec SS, ParsedType TemplateTypeTy,
6114+
Decl *ConstructorDecl, CXXScopeSpec SS, ParsedType TemplateTypeTy,
61166115
ArrayRef<Expr *> ArgExprs, IdentifierInfo *II, SourceLocation OpenParLoc,
61176116
bool Braced) {
61186117
if (!CodeCompleter)
@@ -6125,7 +6124,7 @@ QualType Sema::ProduceCtorInitMemberSignatureHelp(
61256124
// FIXME: Add support for Base class constructors as well.
61266125
if (ValueDecl *MemberDecl = tryLookupCtorInitMemberDecl(
61276126
Constructor->getParent(), SS, TemplateTypeTy, II))
6128-
return ProduceConstructorSignatureHelp(getCurScope(), MemberDecl->getType(),
6127+
return ProduceConstructorSignatureHelp(MemberDecl->getType(),
61296128
MemberDecl->getLocation(), ArgExprs,
61306129
OpenParLoc, Braced);
61316130
return QualType();

0 commit comments

Comments
 (0)