Skip to content

Commit 2e0595b

Browse files
antoyoantoyo
authored
Merge pull request #618 from rust-lang/success-job
Move back to a success job so because the required checks only work without a matrix
2 parents 1a25284 + befc31c commit 2e0595b

File tree

5 files changed

+100
-5
lines changed

5 files changed

+100
-5
lines changed

‎.github/workflows/failures.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ env:
1212
RUST_BACKTRACE: 1
1313

1414
jobs:
15-
success:
15+
build:
1616
runs-on: ubuntu-24.04
1717

1818
strategy:
@@ -108,3 +108,22 @@ jobs:
108108
echo "Error: 'the compiler unexpectedly panicked' found in output logs. CI Error!!"
109109
exit 1
110110
fi
111+
112+
# Summary job for the merge queue.
113+
# ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
114+
success_failures:
115+
needs: [build]
116+
# We need to ensure this job does *not* get skipped if its dependencies fail,
117+
# because a skipped job is considered a success by GitHub. So we have to
118+
# overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run
119+
# when the workflow is canceled manually.
120+
if: ${{ !cancelled() }}
121+
runs-on: ubuntu-latest
122+
steps:
123+
# Manually check the status of all dependencies. `if: failure()` does not work.
124+
- name: Conclusion
125+
run: |
126+
# Print the dependent jobs to see them in the CI log
127+
jq -C <<< '${{ toJson(needs) }}'
128+
# Check if all jobs that we depend on (in the needs array) were successful.
129+
jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'

‎.github/workflows/gcc12.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ env:
1515
GCC_EXEC_PREFIX: /usr/lib/gcc/
1616

1717
jobs:
18-
success:
18+
build:
1919
runs-on: ubuntu-24.04
2020

2121
strategy:
@@ -84,3 +84,22 @@ jobs:
8484
#- name: Run tests
8585
#run: |
8686
#./y.sh test --release --clean --build-sysroot ${{ matrix.commands }} --no-default-features
87+
88+
# Summary job for the merge queue.
89+
# ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
90+
success_gcc12:
91+
needs: [build]
92+
# We need to ensure this job does *not* get skipped if its dependencies fail,
93+
# because a skipped job is considered a success by GitHub. So we have to
94+
# overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run
95+
# when the workflow is canceled manually.
96+
if: ${{ !cancelled() }}
97+
runs-on: ubuntu-latest
98+
steps:
99+
# Manually check the status of all dependencies. `if: failure()` does not work.
100+
- name: Conclusion
101+
run: |
102+
# Print the dependent jobs to see them in the CI log
103+
jq -C <<< '${{ toJson(needs) }}'
104+
# Check if all jobs that we depend on (in the needs array) were successful.
105+
jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'

‎.github/workflows/m68k.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ env:
1515
OVERWRITE_TARGET_TRIPLE: m68k-unknown-linux-gnu
1616

1717
jobs:
18-
success:
18+
build:
1919
runs-on: ubuntu-24.04
2020

2121
strategy:
@@ -104,3 +104,22 @@ jobs:
104104
- name: Run tests
105105
run: |
106106
./y.sh test --release --clean --build-sysroot --sysroot-features compiler_builtins/no-f16-f128 ${{ matrix.commands }}
107+
108+
# Summary job for the merge queue.
109+
# ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
110+
success_m68k:
111+
needs: [build]
112+
# We need to ensure this job does *not* get skipped if its dependencies fail,
113+
# because a skipped job is considered a success by GitHub. So we have to
114+
# overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run
115+
# when the workflow is canceled manually.
116+
if: ${{ !cancelled() }}
117+
runs-on: ubuntu-latest
118+
steps:
119+
# Manually check the status of all dependencies. `if: failure()` does not work.
120+
- name: Conclusion
121+
run: |
122+
# Print the dependent jobs to see them in the CI log
123+
jq -C <<< '${{ toJson(needs) }}'
124+
# Check if all jobs that we depend on (in the needs array) were successful.
125+
jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'

‎.github/workflows/release.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ env:
1111
RUST_BACKTRACE: 1
1212

1313
jobs:
14-
success:
14+
build:
1515
runs-on: ubuntu-24.04
1616

1717
strategy:
@@ -81,3 +81,22 @@ jobs:
8181
echo "Test is done with LTO enabled, hence inlining should occur across crates"
8282
exit 1
8383
fi
84+
85+
# Summary job for the merge queue.
86+
# ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
87+
success_release:
88+
needs: [build]
89+
# We need to ensure this job does *not* get skipped if its dependencies fail,
90+
# because a skipped job is considered a success by GitHub. So we have to
91+
# overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run
92+
# when the workflow is canceled manually.
93+
if: ${{ !cancelled() }}
94+
runs-on: ubuntu-latest
95+
steps:
96+
# Manually check the status of all dependencies. `if: failure()` does not work.
97+
- name: Conclusion
98+
run: |
99+
# Print the dependent jobs to see them in the CI log
100+
jq -C <<< '${{ toJson(needs) }}'
101+
# Check if all jobs that we depend on (in the needs array) were successful.
102+
jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'

‎.github/workflows/stdarch.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ env:
1111
RUST_BACKTRACE: 1
1212

1313
jobs:
14-
success:
14+
build:
1515
runs-on: ubuntu-24.04
1616

1717
strategy:
@@ -101,3 +101,22 @@ jobs:
101101
# TODO: remove --skip test_mm512_stream_ps when stdarch is updated in rustc.
102102
# TODO: remove --skip test_tile_ when it's implemented.
103103
STDARCH_TEST_EVERYTHING=1 CHANNEL=release CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER="${{ matrix.cargo_runner }}" TARGET=x86_64-unknown-linux-gnu CG_RUSTFLAGS="-Ainternal_features --cfg stdarch_intel_sde" ./y.sh cargo test --manifest-path build/build_sysroot/sysroot_src/library/stdarch/Cargo.toml -- --skip rtm --skip tbm --skip sse4a --skip test_mm512_stream_ps --skip test_tile_
104+
105+
# Summary job for the merge queue.
106+
# ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
107+
success_stdarch:
108+
needs: [build]
109+
# We need to ensure this job does *not* get skipped if its dependencies fail,
110+
# because a skipped job is considered a success by GitHub. So we have to
111+
# overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run
112+
# when the workflow is canceled manually.
113+
if: ${{ !cancelled() }}
114+
runs-on: ubuntu-latest
115+
steps:
116+
# Manually check the status of all dependencies. `if: failure()` does not work.
117+
- name: Conclusion
118+
run: |
119+
# Print the dependent jobs to see them in the CI log
120+
jq -C <<< '${{ toJson(needs) }}'
121+
# Check if all jobs that we depend on (in the needs array) were successful.
122+
jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'

0 commit comments

Comments
 (0)