Skip to content

Commit 30de2e7

Browse files
committed
Update UI test expected output
1 parent 1615813 commit 30de2e7

File tree

1 file changed

+32
-26
lines changed

1 file changed

+32
-26
lines changed

tests/ui/unnecessary_clone.stderr

Lines changed: 32 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,75 +1,81 @@
11
error: using `clone` on a `Copy` type
2-
--> $DIR/unnecessary_clone.rs:11:5
2+
--> $DIR/unnecessary_clone.rs:16:5
33
|
4-
11 | 42.clone();
4+
16 | 42.clone();
55
| ^^^^^^^^^^ help: try removing the `clone` call: `42`
66
|
77
= note: `-D clone-on-copy` implied by `-D warnings`
88

99
error: using `clone` on a `Copy` type
10-
--> $DIR/unnecessary_clone.rs:15:5
10+
--> $DIR/unnecessary_clone.rs:20:5
1111
|
12-
15 | (&42).clone();
12+
20 | (&42).clone();
1313
| ^^^^^^^^^^^^^ help: try dereferencing it: `*(&42)`
1414

1515
error: using '.clone()' on a ref-counted pointer
16-
--> $DIR/unnecessary_clone.rs:25:5
16+
--> $DIR/unnecessary_clone.rs:30:5
1717
|
18-
25 | rc.clone();
19-
| ^^^^^^^^^^ help: try this: `Rc::clone(&rc)`
18+
30 | rc.clone();
19+
| ^^^^^^^^^^ help: try this: `Rc<bool>::clone(&rc)`
2020
|
2121
= note: `-D clone-on-ref-ptr` implied by `-D warnings`
2222

2323
error: using '.clone()' on a ref-counted pointer
24-
--> $DIR/unnecessary_clone.rs:28:5
24+
--> $DIR/unnecessary_clone.rs:33:5
2525
|
26-
28 | arc.clone();
27-
| ^^^^^^^^^^^ help: try this: `Arc::clone(&arc)`
26+
33 | arc.clone();
27+
| ^^^^^^^^^^^ help: try this: `Arc<bool>::clone(&arc)`
2828

2929
error: using '.clone()' on a ref-counted pointer
30-
--> $DIR/unnecessary_clone.rs:31:5
30+
--> $DIR/unnecessary_clone.rs:36:5
3131
|
32-
31 | rcweak.clone();
33-
| ^^^^^^^^^^^^^^ help: try this: `Weak::clone(&rcweak)`
32+
36 | rcweak.clone();
33+
| ^^^^^^^^^^^^^^ help: try this: `Weak<bool>::clone(&rcweak)`
3434

3535
error: using '.clone()' on a ref-counted pointer
36-
--> $DIR/unnecessary_clone.rs:34:5
36+
--> $DIR/unnecessary_clone.rs:39:5
3737
|
38-
34 | arc_weak.clone();
39-
| ^^^^^^^^^^^^^^^^ help: try this: `Weak::clone(&arc_weak)`
38+
39 | arc_weak.clone();
39+
| ^^^^^^^^^^^^^^^^ help: try this: `Weak<bool>::clone(&arc_weak)`
40+
41+
error: using '.clone()' on a ref-counted pointer
42+
--> $DIR/unnecessary_clone.rs:43:29
43+
|
44+
43 | let _: Arc<SomeTrait> = x.clone();
45+
| ^^^^^^^^^ help: try this: `Arc<SomeImpl>::clone(&x)`
4046

4147
error: using `clone` on a `Copy` type
42-
--> $DIR/unnecessary_clone.rs:41:5
48+
--> $DIR/unnecessary_clone.rs:47:5
4349
|
44-
41 | t.clone();
50+
47 | t.clone();
4551
| ^^^^^^^^^ help: try removing the `clone` call: `t`
4652

4753
error: using `clone` on a `Copy` type
48-
--> $DIR/unnecessary_clone.rs:43:5
54+
--> $DIR/unnecessary_clone.rs:49:5
4955
|
50-
43 | Some(t).clone();
56+
49 | Some(t).clone();
5157
| ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `Some(t)`
5258

5359
error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
54-
--> $DIR/unnecessary_clone.rs:49:22
60+
--> $DIR/unnecessary_clone.rs:55:22
5561
|
56-
49 | let z: &Vec<_> = y.clone();
62+
55 | let z: &Vec<_> = y.clone();
5763
| ^^^^^^^^^
5864
|
5965
= note: `-D clone-double-ref` implied by `-D warnings`
6066
help: try dereferencing it
6167
|
62-
49 | let z: &Vec<_> = &(*y).clone();
68+
55 | let z: &Vec<_> = &(*y).clone();
6369
| ^^^^^^^^^^^^^
6470
help: or try being explicit about what type to clone
6571
|
66-
49 | let z: &Vec<_> = &std::vec::Vec<i32>::clone(y);
72+
55 | let z: &Vec<_> = &std::vec::Vec<i32>::clone(y);
6773
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
6874

6975
error: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
70-
--> $DIR/unnecessary_clone.rs:56:27
76+
--> $DIR/unnecessary_clone.rs:62:27
7177
|
72-
56 | let v2 : Vec<isize> = v.iter().cloned().collect();
78+
62 | let v2 : Vec<isize> = v.iter().cloned().collect();
7379
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
7480
|
7581
= note: `-D iter-cloned-collect` implied by `-D warnings`

0 commit comments

Comments
 (0)