librustc: Change self as a type to Self everywhere. r=brson

Author: pcwalton

doc/tutorial.md

@@ -1993,10 +1993,10 @@ trait, `self` is a type, and in an impl, `self` is a value. The
 following trait describes types that support an equality operation:
 
 ~~~~
-// In a trait, `self` refers both to the self argument
-// and to the type implementing the trait
+// In a trait, `self` refers to the self argument.
+// `Self` refers to the type implementing the trait.
 trait Eq {
-    fn equals(&self, other: &self) -> bool;
+    fn equals(&self, other: &Self) -> bool;
 }
 
 // In an impl, `self` refers just to the value of the receiver
@@ -2015,7 +2015,7 @@ the method name with the trait name.
 The compiler will use type inference to decide which implementation to call.
 
 ~~~~
-trait Shape { static fn new(area: float) -> self; }
+trait Shape { static fn new(area: float) -> Self; }
 # use float::consts::pi;
 # use float::sqrt;
 struct Circle { radius: float }

src/libcore/clone.rs

@@ -12,7 +12,7 @@
 Clonable types are copied with the clone method
 */
 pub trait Clone {
-    fn clone(&self) -> self;
+    fn clone(&self) -> Self;
 }
 
 impl (): Clone {

src/libcore/cmp.rs

@@ -37,8 +37,8 @@ and `Eq` to overload the `==` and `!=` operators.
 */
 #[lang="eq"]
 pub trait Eq {
-    pure fn eq(&self, other: &self) -> bool;
-    pure fn ne(&self, other: &self) -> bool;
+    pure fn eq(&self, other: &Self) -> bool;
+    pure fn ne(&self, other: &Self) -> bool;
 }
 
 /**
@@ -53,10 +53,10 @@ pub trait Eq {
 */
 #[lang="ord"]
 pub trait Ord {
-    pure fn lt(&self, other: &self) -> bool;
-    pure fn le(&self, other: &self) -> bool;
-    pure fn ge(&self, other: &self) -> bool;
-    pure fn gt(&self, other: &self) -> bool;
+    pure fn lt(&self, other: &Self) -> bool;
+    pure fn le(&self, other: &Self) -> bool;
+    pure fn ge(&self, other: &Self) -> bool;
+    pure fn gt(&self, other: &Self) -> bool;
 }
 
 #[inline(always)]

src/libcore/container.rs

@@ -68,23 +68,23 @@ pub trait Set<T>: Mutable {
 
     /// Return true if the set has no elements in common with `other`.
     /// This is equivalent to checking for an empty intersection.
-    pure fn is_disjoint(&self, other: &self) -> bool;
+    pure fn is_disjoint(&self, other: &Self) -> bool;
 
     /// Return true if the set is a subset of another
-    pure fn is_subset(&self, other: &self) -> bool;
+    pure fn is_subset(&self, other: &Self) -> bool;
 
     /// Return true if the set is a superset of another
-    pure fn is_superset(&self, other: &self) -> bool;
+    pure fn is_superset(&self, other: &Self) -> bool;
 
     /// Visit the values representing the difference
-    pure fn difference(&self, other: &self, f: fn(&T) -> bool);
+    pure fn difference(&self, other: &Self, f: fn(&T) -> bool);
 
     /// Visit the values representing the symmetric difference
-    pure fn symmetric_difference(&self, other: &self, f: fn(&T) -> bool);
+    pure fn symmetric_difference(&self, other: &Self, f: fn(&T) -> bool);
 
     /// Visit the values representing the intersection
-    pure fn intersection(&self, other: &self, f: fn(&T) -> bool);
+    pure fn intersection(&self, other: &Self, f: fn(&T) -> bool);
 
     /// Visit the values representing the union
-    pure fn union(&self, other: &self, f: fn(&T) -> bool);
+    pure fn union(&self, other: &Self, f: fn(&T) -> bool);
 }

src/libcore/from_str.rs

@@ -17,6 +17,6 @@
 use option::Option;
 
 pub trait FromStr {
-    static pure fn from_str(s: &str) -> Option<self>;
+    static pure fn from_str(s: &str) -> Option<Self>;
 }
 

src/libcore/iter.rs

@@ -85,7 +85,7 @@ pub trait Buildable<A> {
      *             onto the sequence being constructed.
      */
      static pure fn build_sized(size: uint,
-                                builder: fn(push: pure fn(A))) -> self;
+                                builder: fn(push: pure fn(A))) -> Self;
 }
 
 #[inline(always)]

src/libcore/num.rs

@@ -12,26 +12,26 @@
 
 pub trait Num {
     // FIXME: Trait composition. (#2616)
-    pure fn add(&self, other: &self) -> self;
-    pure fn sub(&self, other: &self) -> self;
-    pure fn mul(&self, other: &self) -> self;
-    pure fn div(&self, other: &self) -> self;
-    pure fn modulo(&self, other: &self) -> self;
-    pure fn neg(&self) -> self;
+    pure fn add(&self, other: &Self) -> Self;
+    pure fn sub(&self, other: &Self) -> Self;
+    pure fn mul(&self, other: &Self) -> Self;
+    pure fn div(&self, other: &Self) -> Self;
+    pure fn modulo(&self, other: &Self) -> Self;
+    pure fn neg(&self) -> Self;
 
     pure fn to_int(&self) -> int;
-    static pure fn from_int(n: int) -> self;
+    static pure fn from_int(n: int) -> Self;
 }
 
 pub trait IntConvertible {
     pure fn to_int(&self) -> int;
-    static pure fn from_int(n: int) -> self;
+    static pure fn from_int(n: int) -> Self;
 }
 
 pub trait Zero {
-    static pure fn zero() -> self;
+    static pure fn zero() -> Self;
 }
 
 pub trait One {
-    static pure fn one() -> self;
+    static pure fn one() -> Self;
 }

src/libcore/path.rs

@@ -48,28 +48,27 @@ pub pure fn PosixPath(s: &str) -> PosixPath {
 }
 
 pub trait GenericPath {
-
-    static pure fn from_str(&str) -> self;
+    static pure fn from_str(&str) -> Self;
 
     pure fn dirname() -> ~str;
     pure fn filename() -> Option<~str>;
     pure fn filestem() -> Option<~str>;
     pure fn filetype() -> Option<~str>;
 
-    pure fn with_dirname((&str)) -> self;
-    pure fn with_filename((&str)) -> self;
-    pure fn with_filestem((&str)) -> self;
-    pure fn with_filetype((&str)) -> self;
+    pure fn with_dirname((&str)) -> Self;
+    pure fn with_filename((&str)) -> Self;
+    pure fn with_filestem((&str)) -> Self;
+    pure fn with_filetype((&str)) -> Self;
 
-    pure fn dir_path() -> self;
-    pure fn file_path() -> self;
+    pure fn dir_path() -> Self;
+    pure fn file_path() -> Self;
 
-    pure fn push((&str)) -> self;
-    pure fn push_rel((&self)) -> self;
-    pure fn push_many((&[~str])) -> self;
-    pure fn pop() -> self;
+    pure fn push((&str)) -> Self;
+    pure fn push_rel((&Self)) -> Self;
+    pure fn push_many((&[~str])) -> Self;
+    pure fn pop() -> Self;
 
-    pure fn normalize() -> self;
+    pure fn normalize() -> Self;
 }
 
 #[cfg(windows)]

src/libcore/ptr.rs

@@ -187,7 +187,7 @@ pub pure fn ref_eq<T>(thing: &a/T, other: &b/T) -> bool {
 pub trait Ptr<T> {
     pure fn is_null() -> bool;
     pure fn is_not_null() -> bool;
-    pure fn offset(count: uint) -> self;
+    pure fn offset(count: uint) -> Self;
 }
 
 #[cfg(stage0)]

src/libcore/str.rs

@@ -2119,9 +2119,9 @@ pub mod raw {
 }
 
 pub trait Trimmable {
-    pure fn trim() -> self;
-    pure fn trim_left() -> self;
-    pure fn trim_right() -> self;
+    pure fn trim() -> Self;
+    pure fn trim_left() -> Self;
+    pure fn trim_right() -> Self;
 }
 
 /// Extension methods for strings

src/librustc/middle/astencode.rs

@@ -77,7 +77,7 @@ enum extended_decode_ctxt {
 }
 
 trait tr {
-    fn tr(xcx: extended_decode_ctxt) -> self;
+    fn tr(xcx: extended_decode_ctxt) -> Self;
 }
 
 trait tr_intern {

src/librustc/middle/resolve.rs

@@ -3581,8 +3581,6 @@ pub impl Resolver {
                 // Create a new rib for the self type.
                 let self_type_rib = @Rib(NormalRibKind);
                 (*self.type_ribs).push(self_type_rib);
-                self_type_rib.bindings.insert(self.self_ident,
-                                              dl_def(def_self_ty(item.id)));
                 self_type_rib.bindings.insert(self.type_self_ident,
                                               dl_def(def_self_ty(item.id)));
 

src/librustc/middle/typeck/infer/lattice.rs

@@ -50,9 +50,9 @@ use middle::typeck::infer::to_str::InferStr;
 use std::list;
 
 pub trait LatticeValue {
-    static fn sub(cf: &CombineFields, a: &self, b: &self) -> ures;
-    static fn lub(cf: &CombineFields, a: &self, b: &self) -> cres<self>;
-    static fn glb(cf: &CombineFields, a: &self, b: &self) -> cres<self>;
+    static fn sub(cf: &CombineFields, a: &Self, b: &Self) -> ures;
+    static fn lub(cf: &CombineFields, a: &Self, b: &Self) -> cres<Self>;
+    static fn glb(cf: &CombineFields, a: &Self, b: &Self) -> cres<Self>;
 }
 
 pub type LatticeOp<T> = &fn(cf: &CombineFields, a: &T, b: &T) -> cres<T>;

src/librustc/middle/typeck/infer/unify.rs

@@ -39,7 +39,7 @@ pub struct Node<V, T> {
 
 pub trait UnifyVid<T> {
     static fn appropriate_vals_and_bindings(infcx: &v/InferCtxt)
-        -> &v/ValsAndBindings<self, T>;
+        -> &v/ValsAndBindings<Self, T>;
 }
 
 pub impl InferCtxt {
@@ -136,7 +136,7 @@ pub impl InferCtxt {
 // doesn't have a subtyping relationship we need to worry about.
 
 pub trait SimplyUnifiable {
-    static fn to_type_err(expected_found<self>) -> ty::type_err;
+    static fn to_type_err(expected_found<Self>) -> ty::type_err;
 }
 
 pub fn mk_err<T: SimplyUnifiable>(+a_is_expected: bool,

src/libstd/cmp.rs

@@ -18,8 +18,8 @@ use core::float;
 const fuzzy_epsilon: float = 1.0e-6;
 
 pub trait FuzzyEq {
-    pure fn fuzzy_eq(&self, other: &self) -> bool;
-    pure fn fuzzy_eq_eps(&self, other: &self, epsilon: &self) -> bool;
+    pure fn fuzzy_eq(&self, other: &Self) -> bool;
+    pure fn fuzzy_eq_eps(&self, other: &Self, epsilon: &Self) -> bool;
 }
 
 impl float: FuzzyEq {

src/libstd/flatpipes.rs

@@ -467,11 +467,11 @@ pub mod flatteners {
     }
 
     pub trait FromReader {
-        static fn from_reader(r: Reader) -> self;
+        static fn from_reader(r: Reader) -> Self;
     }
 
     pub trait FromWriter {
-        static fn from_writer(w: Writer) -> self;
+        static fn from_writer(w: Writer) -> Self;
     }
 
     impl json::Decoder: FromReader {

src/libstd/serialize.rs

@@ -111,7 +111,7 @@ pub trait Encodable<S: Encoder> {
 }
 
 pub trait Decodable<D: Decoder> {
-    static fn decode(&self, d: &D) -> self;
+    static fn decode(&self, d: &D) -> Self;
 }
 
 pub impl<S: Encoder> uint: Encodable<S> {

src/libsyntax/codemap.rs

@@ -34,7 +34,7 @@ use core::vec;
 use std::serialize::{Encodable, Decodable, Encoder, Decoder};
 
 pub trait Pos {
-    static pure fn from_uint(n: uint) -> self;
+    static pure fn from_uint(n: uint) -> Self;
     pure fn to_uint(&self) -> uint;
 }
 

src/test/auxiliary/static-methods-crate.rs

@@ -14,7 +14,7 @@
 #[crate_type = "lib"];
 
 pub trait read {
-    static fn readMaybe(s: ~str) -> Option<self>;
+    static fn readMaybe(s: ~str) -> Option<Self>;
 }
 
 impl int: read {

src/test/auxiliary/static_fn_inline_xc_aux.rs

@@ -11,7 +11,7 @@
 
 pub mod num {
     pub trait Num2 {
-        static pure fn from_int2(n: int) -> self;
+        static pure fn from_int2(n: int) -> Self;
     }
 }
 

src/test/auxiliary/static_fn_trait_xc_aux.rs

@@ -1,6 +1,6 @@
 pub mod num {
     pub trait Num2 {
-        static pure fn from_int2(n: int) -> self;
+        static pure fn from_int2(n: int) -> Self;
     }
 }
 

src/test/auxiliary/trait_inheritance_overloading_xc.rs

@@ -10,7 +10,7 @@
 
 use cmp::Eq;
 
-pub trait MyNum : Add<self,self> Sub<self,self> Mul<self,self> Eq {
+pub trait MyNum : Add<Self,Self> Sub<Self,Self> Mul<Self,Self> Eq {
 }
 
 pub struct MyInt {

src/test/compile-fail/infinite-instantiation.rs

@@ -12,7 +12,7 @@
 // issue 2258
 
 trait to_opt {
-    fn to_option() -> Option<self>;
+    fn to_option() -> Option<Self>;
 }
 
 impl uint: to_opt {

src/test/compile-fail/missing-derivable-attr.rs

@@ -9,7 +9,7 @@
 // except according to those terms.
 
 trait MyEq {
-    pure fn eq(&self, other: &self) -> bool;
+    pure fn eq(&self, other: &Self) -> bool;
 }
 
 struct A {

src/test/compile-fail/selftype-astparam.rs

@@ -9,7 +9,7 @@
 // except according to those terms.
 
 trait add {
-    fn plus(++x: self) -> self;
+    fn plus(++x: Self) -> Self;
 }
 
 impl int: add {

src/test/compile-fail/selftype-traittype.rs

@@ -9,7 +9,7 @@
 // except according to those terms.
 
 trait add {
-    fn plus(x: self) -> self;
+    fn plus(x: Self) -> Self;
 }
 
 fn do_add(x: add, y: add) -> add {

src/test/compile-fail/trait-impl-different-num-params.rs

@@ -9,7 +9,7 @@
 // except according to those terms.
 
 trait foo {
-    fn bar(x: uint) -> self;
+    fn bar(x: uint) -> Self;
 }
 impl int: foo {
     fn bar() -> int {

src/test/compile-fail/trait-test-2.rs

@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-trait bar { fn dup() -> self; fn blah<X>(); }
+trait bar { fn dup() -> Self; fn blah<X>(); }
 impl int: bar { fn dup() -> int { self } fn blah<X>() {} }
 impl uint: bar { fn dup() -> uint { self } fn blah<X>() {} }