Skip to content

Commit 371be3c

Browse files
committed
Remove unused file_type enum from the parser
1 parent 74b2e99 commit 371be3c

File tree

8 files changed

+24
-38
lines changed

8 files changed

+24
-38
lines changed

src/libsyntax/ext/pipes.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ use codemap::span;
3737
use ext::base::ext_ctxt;
3838
use ast::tt_delim;
3939
use parse::lexer::{new_tt_reader, reader};
40-
use parse::parser::{Parser, SOURCE_FILE};
40+
use parse::parser::Parser;
4141
use parse::common::parser_common;
4242

4343
use pipes::parse_proto::proto_parser;
@@ -52,7 +52,7 @@ fn expand_proto(cx: ext_ctxt, _sp: span, id: ast::ident,
5252
let tt_rdr = new_tt_reader(cx.parse_sess().span_diagnostic,
5353
cx.parse_sess().interner, None, tt);
5454
let rdr = tt_rdr as reader;
55-
let rust_parser = Parser(sess, cfg, rdr.dup(), SOURCE_FILE);
55+
let rust_parser = Parser(sess, cfg, rdr.dup());
5656

5757
let proto = rust_parser.parse_proto(cx.str_of(id));
5858

src/libsyntax/ext/source_util.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@ fn expand_include(cx: ext_ctxt, sp: span, arg: ast::mac_arg,
6060
let file = expr_to_str(cx, args[0], ~"include_str! requires a string");
6161
let p = parse::new_sub_parser_from_file(
6262
cx.parse_sess(), cx.cfg(),
63-
&res_rel_file(cx, sp, &Path(file)),
64-
parse::parser::SOURCE_FILE, sp);
63+
&res_rel_file(cx, sp, &Path(file)), sp);
6564
return p.parse_expr();
6665
}
6766

src/libsyntax/ext/trace_macros.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use codemap::span;
22
use ext::base::ext_ctxt;
33
use ast::tt_delim;
44
use parse::lexer::{new_tt_reader, reader};
5-
use parse::parser::{Parser, SOURCE_FILE};
5+
use parse::parser::Parser;
66
use parse::common::parser_common;
77

88
fn expand_trace_macros(cx: ext_ctxt, sp: span,
@@ -13,15 +13,15 @@ fn expand_trace_macros(cx: ext_ctxt, sp: span,
1313
let tt_rdr = new_tt_reader(cx.parse_sess().span_diagnostic,
1414
cx.parse_sess().interner, None, tt);
1515
let rdr = tt_rdr as reader;
16-
let rust_parser = Parser(sess, cfg, rdr.dup(), SOURCE_FILE);
16+
let rust_parser = Parser(sess, cfg, rdr.dup());
1717

1818
let arg = cx.str_of(rust_parser.parse_ident());
1919
match arg {
2020
~"true" => cx.set_trace_macros(true),
2121
~"false" => cx.set_trace_macros(false),
2222
_ => cx.span_fatal(sp, ~"trace_macros! only accepts `true` or `false`")
2323
}
24-
let rust_parser = Parser(sess, cfg, rdr.dup(), SOURCE_FILE);
24+
let rust_parser = Parser(sess, cfg, rdr.dup());
2525
let result = rust_parser.parse_expr();
2626
base::mr_expr(result)
2727
}

src/libsyntax/ext/tt/macro_parser.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use parse::token;
33
use parse::token::{Token, EOF, to_str, nonterminal};
44
use parse::lexer::*; //resolve bug?
55
//import parse::lexer::{reader, tt_reader, tt_reader_as_reader};
6-
use parse::parser::{Parser, SOURCE_FILE};
6+
use parse::parser::Parser;
77
//import parse::common::parser_common;
88
use parse::common::*; //resolve bug?
99
use parse::parse_sess;
@@ -355,7 +355,7 @@ fn parse(sess: parse_sess, cfg: ast::crate_cfg, rdr: reader, ms: ~[matcher])
355355
}
356356
rdr.next_token();
357357
} else /* bb_eis.len() == 1 */ {
358-
let rust_parser = Parser(sess, cfg, rdr.dup(), SOURCE_FILE);
358+
let rust_parser = Parser(sess, cfg, rdr.dup());
359359
360360
let ei = bb_eis.pop();
361361
match ei.elts[ei.idx].node {

src/libsyntax/ext/tt/macro_rules.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use ast::{ident, matcher_, matcher, match_tok,
44
match_nonterminal, match_seq, tt_delim};
55
use parse::lexer::{new_tt_reader, reader};
66
use parse::token::{FAT_ARROW, SEMI, LBRACE, RBRACE, nt_matchers, nt_tt};
7-
use parse::parser::{Parser, SOURCE_FILE};
7+
use parse::parser::Parser;
88
use macro_parser::{parse, parse_or_else, success, failure, named_match,
99
matched_seq, matched_nonterminal, error};
1010
use std::map::HashMap;
@@ -88,7 +88,7 @@ fn add_new_extension(cx: ext_ctxt, sp: span, name: ident,
8888
let trncbr = new_tt_reader(s_d, itr, Some(named_matches),
8989
~[rhs]);
9090
let p = Parser(cx.parse_sess(), cx.cfg(),
91-
trncbr as reader, SOURCE_FILE);
91+
trncbr as reader);
9292
let e = p.parse_expr();
9393
return mr_expr(e);
9494
}

src/libsyntax/parse.rs

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@ fn parse_crate_from_file(input: &Path, cfg: ast::crate_cfg,
6262
6363
fn parse_crate_from_crate_file(input: &Path, cfg: ast::crate_cfg,
6464
sess: parse_sess) -> @ast::crate {
65-
let p = new_crate_parser_from_file(sess, cfg, input,
66-
parser::CRATE_FILE);
65+
let p = new_crate_parser_from_file(sess, cfg, input);
6766
let lo = p.span.lo;
6867
let prefix = input.dir_path();
6968
let leading_attrs = p.parse_inner_attrs_and_next();
@@ -85,8 +84,7 @@ fn parse_crate_from_crate_file(input: &Path, cfg: ast::crate_cfg,
8584
8685
fn parse_crate_from_source_file(input: &Path, cfg: ast::crate_cfg,
8786
sess: parse_sess) -> @ast::crate {
88-
let p = new_crate_parser_from_file(sess, cfg, input,
89-
parser::SOURCE_FILE);
87+
let p = new_crate_parser_from_file(sess, cfg, input);
9088
let r = p.parse_crate_mod(cfg);
9189
return r;
9290
}
@@ -156,23 +154,21 @@ fn next_node_id(sess: parse_sess) -> node_id {
156154
fn new_parser_from_source_str(sess: parse_sess, cfg: ast::crate_cfg,
157155
+name: ~str, +ss: codemap::FileSubstr,
158156
source: @~str) -> Parser {
159-
let ftype = parser::SOURCE_FILE;
160157
let filemap = sess.cm.new_filemap_w_substr(name, ss, source);
161158
let srdr = lexer::new_string_reader(sess.span_diagnostic, filemap,
162159
sess.interner);
163-
return Parser(sess, cfg, srdr as reader, ftype);
160+
return Parser(sess, cfg, srdr as reader);
164161
}
165162

166163
fn new_parser_from_file(sess: parse_sess, cfg: ast::crate_cfg,
167-
path: &Path,
168-
ftype: parser::file_type) -> Result<Parser, ~str> {
164+
path: &Path) -> Result<Parser, ~str> {
169165
match io::read_whole_file_str(path) {
170166
result::Ok(move src) => {
171167
let filemap = sess.cm.new_filemap(path.to_str(), @move src);
172168
let srdr = lexer::new_string_reader(sess.span_diagnostic, filemap,
173169
sess.interner);
174170

175-
Ok(Parser(sess, cfg, srdr as reader, ftype))
171+
Ok(Parser(sess, cfg, srdr as reader))
176172

177173
}
178174
result::Err(move e) => Err(move e)
@@ -182,9 +178,8 @@ fn new_parser_from_file(sess: parse_sess, cfg: ast::crate_cfg,
182178
/// Create a new parser for an entire crate, handling errors as appropriate
183179
/// if the file doesn't exist
184180
fn new_crate_parser_from_file(sess: parse_sess, cfg: ast::crate_cfg,
185-
path: &Path,
186-
ftype: parser::file_type) -> Parser {
187-
match new_parser_from_file(sess, cfg, path, ftype) {
181+
path: &Path) -> Parser {
182+
match new_parser_from_file(sess, cfg, path) {
188183
Ok(move parser) => move parser,
189184
Err(move e) => {
190185
sess.span_diagnostic.handler().fatal(e)
@@ -195,9 +190,8 @@ fn new_crate_parser_from_file(sess: parse_sess, cfg: ast::crate_cfg,
195190
/// Create a new parser based on a span from an existing parser. Handles
196191
/// error messages correctly when the file does not exist.
197192
fn new_sub_parser_from_file(sess: parse_sess, cfg: ast::crate_cfg,
198-
path: &Path, ftype: parser::file_type,
199-
sp: span) -> Parser {
200-
match new_parser_from_file(sess, cfg, path, ftype) {
193+
path: &Path, sp: span) -> Parser {
194+
match new_parser_from_file(sess, cfg, path) {
201195
Ok(move parser) => move parser,
202196
Err(move e) => {
203197
sess.span_diagnostic.span_fatal(sp, e)
@@ -209,5 +203,5 @@ fn new_parser_from_tt(sess: parse_sess, cfg: ast::crate_cfg,
209203
tt: ~[ast::token_tree]) -> Parser {
210204
let trdr = lexer::new_tt_reader(sess.span_diagnostic, sess.interner,
211205
None, tt);
212-
return Parser(sess, cfg, trdr as reader, parser::SOURCE_FILE)
206+
return Parser(sess, cfg, trdr as reader)
213207
}

src/libsyntax/parse/eval.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use parser::{Parser, SOURCE_FILE};
1+
use parser::Parser;
22
use attr::parser_attr;
33
use ast_util::mk_sp;
44
use codemap::span;
@@ -67,7 +67,7 @@ fn parse_companion_mod(cx: ctx, prefix: &Path, suffix: &Option<Path>)
6767
debug!("found companion mod");
6868
// XXX: Using a dummy span, but this code will go away soon
6969
let p0 = new_sub_parser_from_file(cx.sess, cx.cfg,
70-
modpath, SOURCE_FILE,
70+
modpath,
7171
ast_util::dummy_sp());
7272
let inner_attrs = p0.parse_inner_attrs_and_next();
7373
let m0 = p0.parse_mod_items(token::EOF, inner_attrs.next);
@@ -96,7 +96,7 @@ fn eval_src_mod(cx: ctx, prefix: &Path, id: ast::ident,
9696
};
9797
let p0 =
9898
new_sub_parser_from_file(cx.sess, cx.cfg,
99-
&full_path, SOURCE_FILE, sp);
99+
&full_path, sp);
100100
let inner_attrs = p0.parse_inner_attrs_and_next();
101101
let mod_attrs = vec::append(outer_attrs, inner_attrs.inner);
102102
let first_item_outer_attrs = inner_attrs.next;

src/libsyntax/parse/parser.rs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,7 @@ use ast::{_mod, add, arg, arm, attribute,
7070
expr_vstore_fixed, expr_vstore_slice, expr_vstore_box,
7171
expr_vstore_uniq, TyFn, Onceness, Once, Many};
7272

73-
export file_type;
7473
export Parser;
75-
export CRATE_FILE;
76-
export SOURCE_FILE;
7774

7875
// FIXME (#3726): #ast expects to find this here but it's actually
7976
// defined in `parse` Fixing this will be easier when we have export
@@ -92,8 +89,6 @@ enum restriction {
9289
RESTRICT_NO_BAR_OR_DOUBLEBAR_OP,
9390
}
9491

95-
enum file_type { CRATE_FILE, SOURCE_FILE, }
96-
9792
enum class_member {
9893
field_member(@struct_field),
9994
method_member(@method)
@@ -180,7 +175,7 @@ pure fn maybe_append(+lhs: ~[attribute], rhs: Option<~[attribute]>)
180175
/* ident is handled by common.rs */
181176

182177
fn Parser(sess: parse_sess, cfg: ast::crate_cfg,
183-
+rdr: reader, ftype: file_type) -> Parser {
178+
+rdr: reader) -> Parser {
184179

185180
let tok0 = rdr.next_token();
186181
let span0 = tok0.sp;
@@ -191,7 +186,6 @@ fn Parser(sess: parse_sess, cfg: ast::crate_cfg,
191186
interner: move interner,
192187
sess: sess,
193188
cfg: cfg,
194-
file_type: ftype,
195189
token: tok0.tok,
196190
span: span0,
197191
last_span: span0,
@@ -210,7 +204,6 @@ fn Parser(sess: parse_sess, cfg: ast::crate_cfg,
210204
struct Parser {
211205
sess: parse_sess,
212206
cfg: crate_cfg,
213-
file_type: file_type,
214207
mut token: token::Token,
215208
mut span: span,
216209
mut last_span: span,

0 commit comments

Comments
 (0)