Skip to content

Commit 387b7fa

Browse files
committed
---
yaml --- r: 89085 b: refs/heads/snap-stage3 c: 7f816b7 h: refs/heads/master i: 89083: 381a585 v: v3
1 parent 30c0ea5 commit 387b7fa

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
refs/heads/master: deeca5d586bfaa4aa60246f671a8d611d38f6248
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
4-
refs/heads/snap-stage3: 8c703643ad0bb1c70c249dc16b5a32e253815be1
4+
refs/heads/snap-stage3: 7f816b7ef4c617eec3d03397f4013c06c9f98ce2
55
refs/heads/try: b160761e35efcd1207112b3b782c06633cf441a8
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b

branches/snap-stage3/src/librustc/middle/check_const.rs

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ use middle::ty;
1515
use middle::typeck;
1616
use util::ppaux;
1717

18+
use std::cell::RefCell;
1819
use syntax::ast::*;
1920
use syntax::codemap;
2021
use syntax::{ast_util, ast_map};
@@ -215,7 +216,7 @@ struct env {
215216
sess: Session,
216217
ast_map: ast_map::map,
217218
def_map: resolve::DefMap,
218-
idstack: @mut ~[NodeId]
219+
idstack: @RefCell<~[NodeId]>,
219220
}
220221

221222
struct CheckItemRecursionVisitor {
@@ -233,7 +234,7 @@ pub fn check_item_recursion(sess: Session,
233234
sess: sess,
234235
ast_map: ast_map,
235236
def_map: def_map,
236-
idstack: @mut ~[]
237+
idstack: @RefCell::new(~[]),
237238
};
238239

239240
let mut visitor = CheckItemRecursionVisitor { env: env };
@@ -242,12 +243,19 @@ pub fn check_item_recursion(sess: Session,
242243

243244
impl Visitor<()> for CheckItemRecursionVisitor {
244245
fn visit_item(&mut self, it: @item, _: ()) {
245-
if self.env.idstack.iter().any(|x| x == &(it.id)) {
246-
self.env.sess.span_fatal(self.env.root_it.span, "recursive constant");
246+
{
247+
let mut idstack = self.env.idstack.borrow_mut();
248+
if idstack.get().iter().any(|x| x == &(it.id)) {
249+
self.env.sess.span_fatal(self.env.root_it.span,
250+
"recursive constant");
251+
}
252+
idstack.get().push(it.id);
247253
}
248-
self.env.idstack.push(it.id);
249254
visit::walk_item(self, it, ());
250-
self.env.idstack.pop();
255+
{
256+
let mut idstack = self.env.idstack.borrow_mut();
257+
idstack.get().pop();
258+
}
251259
}
252260

253261
fn visit_expr(&mut self, e: @Expr, _: ()) {

0 commit comments

Comments
 (0)