Skip to content

Commit 3a36ffe

Browse files
committed
Revert "Update the build system to handle dependency on header files. Closes #2547."
This reverts commit 31f4b63.
1 parent a72d469 commit 3a36ffe

File tree

3 files changed

+19
-16
lines changed

3 files changed

+19
-16
lines changed

mk/platform.mk

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -214,16 +214,14 @@ ifeq ($(CFG_C_COMPILER),clang)
214214
endif
215215
CFG_GCCISH_CFLAGS += -Wall -Werror -fno-rtti -g
216216
CFG_GCCISH_LINK_FLAGS += -g
217-
# These flags will cause the compiler to produce a .d file
218-
# next to the .o file that lists header deps.
219-
CFG_DEPEND_FLAGS = -MMD -MP -MT $(1) -MF $(1:%.o=%.d)
217+
CFG_DEPEND_C = $(CFG_GCCISH_CROSS)$(CXX) $(CFG_GCCISH_CFLAGS) -MT "$(1)" \
218+
-MM $(2)
220219

221220
define CFG_MAKE_CC
222221
CFG_COMPILE_C_$(1) = $$(CFG_GCCISH_CROSS)$$(CXX) \
223222
$$(CFG_GCCISH_CFLAGS) $$(CFG_CLANG_CFLAGS) \
224223
$$(CFG_GCCISH_CFLAGS_$$(HOST_$(1))) \
225224
$$(CFG_CLANG_CFLAGS_$$(HOST_$(1))) \
226-
$$(CFG_DEPEND_FLAGS) \
227225
-c -o $$(1) $$(2)
228226
CFG_LINK_C_$(1) = $$(CFG_GCCISH_CROSS)$$(CXX) \
229227
$$(CFG_GCCISH_LINK_FLAGS) -o $$(1) \
@@ -247,17 +245,15 @@ ifeq ($(CFG_C_COMPILER),gcc)
247245
endif
248246
CFG_GCCISH_CFLAGS += -Wall -Werror -fno-rtti -g
249247
CFG_GCCISH_LINK_FLAGS += -g
250-
# These flags will cause the compiler to produce a .d file
251-
# next to the .o file that lists header deps.
252-
CFG_DEPEND_FLAGS = -MMD -MP -MT $(1) -MF $(1:%.o=%.d)
248+
CFG_DEPEND_C = $(CFG_GCCISH_CROSS)$(CXX) $(CFG_GCCISH_CFLAGS) -MT "$(1)" \
249+
-MM $(2)
253250

254251
define CFG_MAKE_CC
255252
CFG_COMPILE_C_$(1) = $$(CFG_GCCISH_CROSS)$$(CXX) \
256253
$$(CFG_GCCISH_CFLAGS) \
257254
$$(CFG_GCCISH_CFLAGS_$$(HOST_$(1))) \
258255
$$(CFG_GCC_CFLAGS) \
259256
$$(CFG_GCC_CFLAGS_$$(HOST_$(1))) \
260-
$$(CFG_DEPEND_FLAGS) \
261257
-c -o $$(1) $$(2)
262258
CFG_LINK_C_$(1) = $$(CFG_GCCISH_CROSS)$$(CXX) \
263259
$$(CFG_GCCISH_LINK_FLAGS) -o $$(1) \
@@ -276,7 +272,7 @@ endif
276272
# We're using llvm-mc as our assembler because it supports
277273
# .cfi pseudo-ops on mac
278274
define CFG_MAKE_ASSEMBLER
279-
CFG_ASSEMBLE_$(1)=$$(CPP) $$(CFG_DEPEND_FLAGS) $$(2) | \
275+
CFG_ASSEMBLE_$(1)=$$(CPP) $$(2) | \
280276
$$(LLVM_MC_$$(CFG_HOST_TRIPLE)) \
281277
-assemble \
282278
-filetype=obj \

mk/rt.mk

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,17 @@ RUNTIME_S_$(1) := rt/arch/$$(HOST_$(1))/_context.S \
7979
rt/arch/$$(HOST_$(1))/ccall.S \
8080
rt/arch/$$(HOST_$(1))/record_sp.S
8181

82+
RUNTIME_HDR_$(1) := $$(wildcard \
83+
rt/*.h \
84+
rt/bigint/*.h \
85+
rt/isaac/*.h \
86+
rt/msvc/*.h \
87+
rt/sync/*.h \
88+
rt/uthash/*.h \
89+
rt/util/*.h \
90+
rt/vg/*.h \
91+
rt/arch/$$(HOST_$(1))/*.h)
92+
8293
ifeq ($$(HOST_$(1)), i386)
8394
LIBUV_ARCH_$(1) := ia32
8495
else
@@ -105,17 +116,14 @@ RUNTIME_INCS_$(1) := -I $$(S)src/rt -I $$(S)src/rt/isaac -I $$(S)src/rt/uthash \
105116
-I $$(S)src/libuv/include
106117
RUNTIME_OBJS_$(1) := $$(RUNTIME_CS_$(1):rt/%.cpp=rt/$(1)/%.o) \
107118
$$(RUNTIME_S_$(1):rt/%.S=rt/$(1)/%.o)
108-
RUNTIME_DEP_FILES_$(1) := $$(RUNTIME_OBJS_$(1):%.o=%.d)
109-
-include $$(RUNTIME_DEP_FILES_$(1))
110-
111119
RUNTIME_LIBS_$(1) := $$(LIBUV_LIB_$(1))
112120

113-
rt/$(1)/%.o: rt/%.cpp $$(MKFILE_DEPS)
121+
rt/$(1)/%.o: rt/%.cpp $$(RUNTIME_HDR_$(1)) $$(MKFILE_DEPS)
114122
@$$(call E, compile: $$@)
115123
$$(Q)$$(call CFG_COMPILE_C_$(1), $$@, $$(RUNTIME_INCS_$(1)) \
116124
$$(SNAP_DEFINES)) $$<
117125

118-
rt/$(1)/%.o: rt/%.S $$(MKFILE_DEPS) \
126+
rt/$(1)/%.o: rt/%.S $$(RUNTIME_HDR_$(1)) $$(MKFILE_DEPS) \
119127
$$(LLVM_CONFIG_$$(CFG_HOST_TRIPLE))
120128
@$$(call E, compile: $$@)
121129
$$(Q)$$(call CFG_ASSEMBLE_$(1),$$@,$$<)
@@ -126,6 +134,7 @@ rt/$(1)/arch/$$(HOST_$(1))/libmorestack.a: \
126134
$$(Q)ar rcs $$@ $$<
127135

128136
rt/$(1)/$(CFG_RUNTIME): $$(RUNTIME_OBJS_$(1)) $$(MKFILE_DEPS) \
137+
$$(RUNTIME_HDR_$(1)) \
129138
$$(RUNTIME_DEF_$(1)) \
130139
$$(RUNTIME_LIBS_$(1))
131140
@$$(call E, link: $$@)

mk/rustllvm.mk

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ RUSTLLVM_INCS_$(1) = $$(LLVM_EXTRA_INCDIRS_$(1)) \
2020
-iquote $$(LLVM_INCDIR_$(1)) \
2121
-iquote $$(S)src/rustllvm/include
2222
RUSTLLVM_OBJS_OBJS_$(1) := $$(RUSTLLVM_OBJS_CS_$(1):rustllvm/%.cpp=rustllvm/$(1)/%.o)
23-
RUSTLLVM_DEP_FILES_$(1) := $$(RUSTLLVM_OBJS_OBJS_$(1):%.o=%.d)
24-
-include $$(RUSTLLVM_DEP_FILES_$(1))
2523

2624
rustllvm/$(1)/$(CFG_RUSTLLVM): $$(RUSTLLVM_OBJS_OBJS_$(1)) \
2725
$$(MKFILE_DEPS) $$(RUSTLLVM_DEF_$(1))

0 commit comments

Comments
 (0)