Pass by ref instead of value

phansch · phansch · commit 3bdc691a91e3 · 2018-09-06T08:19:09.000+02:00
diff --git a/clippy_dev/src/lib.rs b/clippy_dev/src/lib.rs
@@ -58,10 +58,10 @@ impl Lint {
 }
 
 pub fn gather_all() -> impl Iterator<Item=Lint> {
-    lint_files().flat_map(gather_from_file)
+    lint_files().flat_map(|f| gather_from_file(&f))
 }
 
-fn gather_from_file(dir_entry: fs::DirEntry) -> impl Iterator<Item=Lint> {
+fn gather_from_file(dir_entry: &fs::DirEntry) -> impl Iterator<Item=Lint> {
     let mut file = fs::File::open(dir_entry.path()).unwrap();
     let mut content = String::new();
     file.read_to_string(&mut content).unwrap();

Original file line number	Diff line number	Diff line change
`@@ -58,10 +58,10 @@ impl Lint {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`pub fn gather_all() -> impl Iterator<Item=Lint> {`
`61`		`- lint_files().flat_map(gather_from_file)`
	`61`	`+ lint_files().flat_map(\|f\| gather_from_file(&f))`
`62`	`62`	`}`
`63`	`63`
`64`		`-fn gather_from_file(dir_entry: fs::DirEntry) -> impl Iterator<Item=Lint> {`
	`64`	`+fn gather_from_file(dir_entry: &fs::DirEntry) -> impl Iterator<Item=Lint> {`
`65`	`65`	`let mut file = fs::File::open(dir_entry.path()).unwrap();`
`66`	`66`	`let mut content = String::new();`
`67`	`67`	`file.read_to_string(&mut content).unwrap();`