Skip to content

Commit 3ca3e3e

Browse files
committed
---
yaml --- r: 228974 b: refs/heads/try c: 0f92455 h: refs/heads/master v: v3
1 parent 0029e5c commit 3ca3e3e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
refs/heads/master: aca2057ed5fb7af3f8905b2bc01f72fa001c35c8
33
refs/heads/snap-stage3: 1af31d4974e33027a68126fa5a5a3c2c6491824f
4-
refs/heads/try: 77e5f70460fd0966c2b593f9f8419de01d4b7857
4+
refs/heads/try: 0f924555e50bbc9b5e7d408c5230510d4a5bc9de
55
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
66
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
77
refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try/vec.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
% Example: Implementing Vec
22

33
To bring everything together, we're going to write `std::Vec` from scratch.
4-
Because the all the best tools for writing unsafe code are unstable, this
4+
Because all the best tools for writing unsafe code are unstable, this
55
project will only work on nightly (as of Rust 1.2.0).
66

77

@@ -253,7 +253,7 @@ pub fn pop(&mut self) -> Option<T> {
253253

254254
# Deallocating
255255

256-
Next we should implement Drop so that we don't massively leak tons of resources.
256+
Next we should implement Drop so that we don't massively leaks tons of resources.
257257
The easiest way is to just call `pop` until it yields None, and then deallocate
258258
our buffer. Note that calling `pop` is uneeded if `T: !Drop`. In theory we can
259259
ask Rust if T needs_drop and omit the calls to `pop`. However in practice LLVM
@@ -442,9 +442,9 @@ end = ptr.offset(len)
442442
```
443443

444444
However because `offset` is marked as a GEP inbounds instruction, this will tell
445-
LLVM that ptr is allocated and won't alias other allocated memory. This is fine
445+
llVM that ptr is allocated and won't alias other allocated memory. This is fine
446446
for zero-sized types, as they can't alias anything. However if we're using
447-
`heap::EMPTY` as a sentinel for a non-allocation for a *non-zero-sized* type,
447+
heap::EMPTY as a sentinel for a non-allocation for a *non-zero-sized* type,
448448
this can cause undefined behaviour. Alas, we must therefore special case either
449449
cap or len being 0 to not do the offset.
450450

0 commit comments

Comments
 (0)