Remove fixed todos

bjorn3 · bjorn3 · commit 41246b2cf629 · 2024-03-27T13:35:32.000Z
diff --git a/src/debuginfo/mod.rs b/src/debuginfo/mod.rs
@@ -215,7 +215,6 @@ impl DebugContext {
             entry.set(gimli::DW_AT_linkage_name, AttributeValue::StringRef(linkage_name_id));
         }
         // Gdb requires DW_AT_name. Otherwise the DW_TAG_subprogram is skipped.
-        // FIXME only include the function name and not the full mangled symbol
         entry.set(gimli::DW_AT_name, AttributeValue::StringRef(name_id));
 
         entry.set(gimli::DW_AT_decl_file, AttributeValue::FileIndex(Some(file_id)));
@@ -225,8 +224,6 @@ impl DebugContext {
             entry.set(gimli::DW_AT_external, AttributeValue::FlagPresent);
         }
 
-        // FIXME set DW_AT_external as appropriate
-
         FunctionDebugContext {
             entry_id,
             function_source_loc: (file_id, line, column),

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,6 @@ impl DebugContext {`
`215`	`215`	`entry.set(gimli::DW_AT_linkage_name, AttributeValue::StringRef(linkage_name_id));`
`216`	`216`	`}`
`217`	`217`	`// Gdb requires DW_AT_name. Otherwise the DW_TAG_subprogram is skipped.`
`218`		`- // FIXME only include the function name and not the full mangled symbol`
`219`	`218`	`entry.set(gimli::DW_AT_name, AttributeValue::StringRef(name_id));`
`220`	`219`
`221`	`220`	`entry.set(gimli::DW_AT_decl_file, AttributeValue::FileIndex(Some(file_id)));`
`@@ -225,8 +224,6 @@ impl DebugContext {`
`225`	`224`	`entry.set(gimli::DW_AT_external, AttributeValue::FlagPresent);`
`226`	`225`	`}`
`227`	`226`
`228`		`- // FIXME set DW_AT_external as appropriate`
`229`		`-`
`230`	`227`	`FunctionDebugContext {`
`231`	`228`	`entry_id,`
`232`	`229`	`function_source_loc: (file_id, line, column),`