Skip to content

Commit 42cba98

Browse files
committed
core: Convert some multiline statements to single-line
1 parent 54bb722 commit 42cba98

File tree

5 files changed

+67
-135
lines changed

5 files changed

+67
-135
lines changed

src/libcore/rt/context.rs

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ pub impl Context {
5454
// which we will then modify to call the given function when restored
5555
let mut regs = new_regs();
5656
unsafe {
57-
swap_registers(transmute_mut_region(&mut *regs),
58-
transmute_region(&*regs))
57+
swap_registers(transmute_mut_region(&mut *regs), transmute_region(&*regs))
5958
};
6059

6160
initialize_call_frame(&mut *regs, fp, argp, sp);
@@ -107,8 +106,7 @@ fn new_regs() -> ~Registers {
107106
}
108107

109108
#[cfg(target_arch = "x86")]
110-
fn initialize_call_frame(regs: &mut Registers,
111-
fptr: *c_void, arg: *c_void, sp: *mut uint) {
109+
fn initialize_call_frame(regs: &mut Registers, fptr: *c_void, arg: *c_void, sp: *mut uint) {
112110

113111
let sp = align_down(sp);
114112
let sp = mut_offset(sp, -4);
@@ -131,8 +129,7 @@ type Registers = [uint * 22];
131129
fn new_regs() -> ~Registers { ~[0, .. 22] }
132130

133131
#[cfg(target_arch = "x86_64")]
134-
fn initialize_call_frame(regs: &mut Registers,
135-
fptr: *c_void, arg: *c_void, sp: *mut uint) {
132+
fn initialize_call_frame(regs: &mut Registers, fptr: *c_void, arg: *c_void, sp: *mut uint) {
136133

137134
// Redefinitions from regs.h
138135
const RUSTRT_ARG0: uint = 3;
@@ -166,8 +163,7 @@ type Registers = [uint * 32];
166163
fn new_regs() -> ~Registers { ~[0, .. 32] }
167164

168165
#[cfg(target_arch = "arm")]
169-
fn initialize_call_frame(regs: &mut Registers,
170-
fptr: *c_void, arg: *c_void, sp: *mut uint) {
166+
fn initialize_call_frame(regs: &mut Registers, fptr: *c_void, arg: *c_void, sp: *mut uint) {
171167
let sp = mut_offset(sp, -1);
172168

173169
// The final return address. 0 indicates the bottom of the stack
@@ -185,8 +181,7 @@ type Registers = [uint * 32];
185181
fn new_regs() -> ~Registers { ~[0, .. 32] }
186182

187183
#[cfg(target_arch = "mips")]
188-
fn initialize_call_frame(regs: &mut Registers,
189-
fptr: *c_void, arg: *c_void, sp: *mut uint) {
184+
fn initialize_call_frame(regs: &mut Registers, fptr: *c_void, arg: *c_void, sp: *mut uint) {
190185
let sp = mut_offset(sp, -1);
191186

192187
// The final return address. 0 indicates the bottom of the stack

src/libcore/rt/sched.rs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,7 @@ pub impl Scheduler {
183183

184184
let blocked_task = self.current_task.swap_unwrap();
185185
let f_fake_region = unsafe {
186-
transmute::<&fn(&mut Scheduler, ~Task),
187-
&fn(&mut Scheduler, ~Task)>(f)
186+
transmute::<&fn(&mut Scheduler, ~Task), &fn(&mut Scheduler, ~Task)>(f)
188187
};
189188
let f_opaque = HackAroundBorrowCk::from_fn(f_fake_region);
190189
self.enqueue_cleanup_job(GiveTask(blocked_task, f_opaque));
@@ -233,8 +232,7 @@ pub impl Scheduler {
233232
Context::swap(task_context, scheduler_context);
234233
}
235234

236-
priv fn swap_in_task_from_running_task(&mut self,
237-
running_task: &mut Task) {
235+
priv fn swap_in_task_from_running_task(&mut self, running_task: &mut Task) {
238236
let running_task_context = &mut running_task.saved_context;
239237
let next_context = &self.current_task.get_ref().saved_context;
240238
Context::swap(running_task_context, next_context);
@@ -344,8 +342,7 @@ impl ThreadLocalScheduler {
344342
fn put_scheduler(&mut self, scheduler: ~Scheduler) {
345343
unsafe {
346344
let key = match self { &ThreadLocalScheduler(key) => key };
347-
let value: *mut c_void =
348-
transmute::<~Scheduler, *mut c_void>(scheduler);
345+
let value: *mut c_void = transmute::<~Scheduler, *mut c_void>(scheduler);
349346
tls::set(key, value);
350347
}
351348
}
@@ -357,8 +354,9 @@ impl ThreadLocalScheduler {
357354
fail_unless!(value.is_not_null());
358355
{
359356
let value_ptr = &mut value;
360-
let sched: &mut ~Scheduler =
361-
transmute::<&mut *mut c_void, &mut ~Scheduler>(value_ptr);
357+
let sched: &mut ~Scheduler = {
358+
transmute::<&mut *mut c_void, &mut ~Scheduler>(value_ptr)
359+
};
362360
let sched: &mut Scheduler = &mut **sched;
363361
return sched;
364362
}

src/libcore/rt/uv.rs

Lines changed: 20 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,8 @@ pub impl IdleWatcher {
157157
};
158158

159159
extern fn idle_cb(handle: *uvll::uv_idle_t, status: c_int) {
160-
let idle_watcher: IdleWatcher =
161-
NativeHandle::from_native_handle(handle);
162-
let cb: &IdleCallback =
163-
borrow_callback_from_watcher(&idle_watcher);
160+
let idle_watcher: IdleWatcher = NativeHandle::from_native_handle(handle);
161+
let cb: &IdleCallback = borrow_callback_from_watcher(&idle_watcher);
164162
let status = status_to_maybe_uv_error(handle, status);
165163
(*cb)(idle_watcher, status);
166164
}
@@ -175,9 +173,7 @@ pub impl IdleWatcher {
175173

176174
extern fn close_cb(handle: *uvll::uv_idle_t) {
177175
let mut idle_watcher = NativeHandle::from_native_handle(handle);
178-
drop_watcher_callback::<uvll::uv_idle_t,
179-
IdleWatcher,
180-
IdleCallback>(&mut idle_watcher);
176+
drop_watcher_callback::<uvll::uv_idle_t, IdleWatcher, IdleCallback>(&mut idle_watcher);
181177
unsafe { uvll::idle_delete(handle) };
182178
}
183179
}
@@ -220,21 +216,17 @@ pub impl StreamWatcher {
220216
let handle = self.native_handle();
221217
unsafe { uvll::read_start(handle, alloc_cb, read_cb); }
222218

223-
extern fn alloc_cb(stream: *uvll::uv_stream_t,
224-
suggested_size: size_t) -> Buf {
225-
let mut stream_watcher: StreamWatcher =
226-
NativeHandle::from_native_handle(stream);
219+
extern fn alloc_cb(stream: *uvll::uv_stream_t, suggested_size: size_t) -> Buf {
220+
let mut stream_watcher: StreamWatcher = NativeHandle::from_native_handle(stream);
227221
let data = get_watcher_data(&mut stream_watcher);
228222
let alloc_cb = data.alloc_cb.get_ref();
229223
return (*alloc_cb)(suggested_size as uint);
230224
}
231225

232-
extern fn read_cb(stream: *uvll::uv_stream_t,
233-
nread: ssize_t, ++buf: Buf) {
226+
extern fn read_cb(stream: *uvll::uv_stream_t, nread: ssize_t, ++buf: Buf) {
234227
rtdebug!("buf addr: %x", buf.base as uint);
235228
rtdebug!("buf len: %d", buf.len as int);
236-
let mut stream_watcher: StreamWatcher =
237-
NativeHandle::from_native_handle(stream);
229+
let mut stream_watcher: StreamWatcher = NativeHandle::from_native_handle(stream);
238230
let data = get_watcher_data(&mut stream_watcher);
239231
let cb = data.read_cb.get_ref();
240232
let status = status_to_maybe_uv_error(stream, nread as c_int);
@@ -270,14 +262,11 @@ pub impl StreamWatcher {
270262
let _v = vec_from_uv_buf(buf);
271263

272264
extern fn write_cb(req: *uvll::uv_write_t, status: c_int) {
273-
let write_request: WriteRequest =
274-
NativeHandle::from_native_handle(req);
265+
let write_request: WriteRequest = NativeHandle::from_native_handle(req);
275266
let mut stream_watcher = write_request.stream();
276267
write_request.delete();
277-
let cb = get_watcher_data(&mut stream_watcher)
278-
.write_cb.swap_unwrap();
279-
let status = status_to_maybe_uv_error(
280-
stream_watcher.native_handle(), status);
268+
let cb = get_watcher_data(&mut stream_watcher).write_cb.swap_unwrap();
269+
let status = status_to_maybe_uv_error(stream_watcher.native_handle(), status);
281270
cb(stream_watcher, status);
282271
}
283272
}
@@ -301,8 +290,7 @@ pub impl StreamWatcher {
301290
unsafe { uvll::close(self.native_handle(), close_cb); }
302291

303292
extern fn close_cb(handle: *uvll::uv_stream_t) {
304-
let mut stream_watcher: StreamWatcher =
305-
NativeHandle::from_native_handle(handle);
293+
let mut stream_watcher: StreamWatcher = NativeHandle::from_native_handle(handle);
306294
{
307295
let mut data = get_watcher_data(&mut stream_watcher);
308296
data.close_cb.swap_unwrap()();
@@ -382,16 +370,14 @@ pub impl TcpWatcher {
382370

383371
extern fn connect_cb(req: *uvll::uv_connect_t, status: c_int) {
384372
rtdebug!("connect_t: %x", req as uint);
385-
let connect_request: ConnectRequest =
386-
NativeHandle::from_native_handle(req);
373+
let connect_request: ConnectRequest = NativeHandle::from_native_handle(req);
387374
let mut stream_watcher = connect_request.stream();
388375
connect_request.delete();
389376
let cb: ConnectionCallback = {
390377
let data = get_watcher_data(&mut stream_watcher);
391378
data.connect_cb.swap_unwrap()
392379
};
393-
let status = status_to_maybe_uv_error(
394-
stream_watcher.native_handle(), status);
380+
let status = status_to_maybe_uv_error(stream_watcher.native_handle(), status);
395381
cb(stream_watcher, status);
396382
}
397383
}
@@ -412,19 +398,15 @@ pub impl TcpWatcher {
412398

413399
extern fn connection_cb(handle: *uvll::uv_stream_t, status: c_int) {
414400
rtdebug!("connection_cb");
415-
let mut stream_watcher: StreamWatcher =
416-
NativeHandle::from_native_handle(handle);
417-
let cb = get_watcher_data(&mut stream_watcher)
418-
.connect_cb.swap_unwrap();
419-
let status = status_to_maybe_uv_error(
420-
stream_watcher.native_handle(), status);
401+
let mut stream_watcher: StreamWatcher = NativeHandle::from_native_handle(handle);
402+
let cb = get_watcher_data(&mut stream_watcher).connect_cb.swap_unwrap();
403+
let status = status_to_maybe_uv_error(stream_watcher.native_handle(), status);
421404
cb(stream_watcher, status);
422405
}
423406
}
424407

425408
fn as_stream(&self) -> StreamWatcher {
426-
NativeHandle::from_native_handle(
427-
self.native_handle() as *uvll::uv_stream_t)
409+
NativeHandle::from_native_handle(self.native_handle() as *uvll::uv_stream_t)
428410
}
429411
}
430412

@@ -460,9 +442,7 @@ impl ConnectRequest {
460442

461443
fn stream(&self) -> StreamWatcher {
462444
unsafe {
463-
let stream_handle =
464-
uvll::get_stream_handle_from_connect_req(
465-
self.native_handle());
445+
let stream_handle = uvll::get_stream_handle_from_connect_req(self.native_handle());
466446
NativeHandle::from_native_handle(stream_handle)
467447
}
468448
}
@@ -499,8 +479,7 @@ impl WriteRequest {
499479

500480
fn stream(&self) -> StreamWatcher {
501481
unsafe {
502-
let stream_handle =
503-
uvll::get_stream_handle_from_write_req(self.native_handle());
482+
let stream_handle = uvll::get_stream_handle_from_write_req(self.native_handle());
504483
NativeHandle::from_native_handle(stream_handle)
505484
}
506485
}
@@ -609,8 +588,7 @@ fn drop_watcher_callback<H, W: Watcher + NativeHandle<*H>, CB: Callback>(
609588
// Take ownership of the callback and drop it
610589
let _cb = transmute::<*c_void, ~CB>(handle_data);
611590
// Make sure the pointer is zeroed
612-
uvll::set_data_for_uv_handle(
613-
watcher.native_handle(), null::<()>());
591+
uvll::set_data_for_uv_handle(watcher.native_handle(), null::<()>());
614592
}
615593
}
616594
}

src/libcore/rt/uvio.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,9 @@ impl TcpListener for UvTcpListener {
189189
do server_tcp_watcher.listen |server_stream_watcher, status| {
190190
let maybe_stream = if status.is_none() {
191191
let mut server_stream_watcher = server_stream_watcher;
192-
let mut loop_ =
193-
loop_from_watcher(&server_stream_watcher);
194-
let mut client_tcp_watcher =
195-
TcpWatcher::new(&mut loop_);
196-
let mut client_tcp_watcher =
197-
client_tcp_watcher.as_stream();
192+
let mut loop_ = loop_from_watcher(&server_stream_watcher);
193+
let mut client_tcp_watcher = TcpWatcher::new(&mut loop_);
194+
let mut client_tcp_watcher = client_tcp_watcher.as_stream();
198195
// XXX: Need's to be surfaced in interface
199196
server_stream_watcher.accept(client_tcp_watcher);
200197
Some(~UvStream::new(client_tcp_watcher))
@@ -425,8 +422,7 @@ fn test_read_and_block() {
425422
// Yield to the other task in hopes that it
426423
// will trigger a read callback while we are
427424
// not ready for it
428-
do scheduler.block_running_task_and_then
429-
|scheduler, task| {
425+
do scheduler.block_running_task_and_then |scheduler, task| {
430426
scheduler.task_queue.push_back(task);
431427
}
432428
}

0 commit comments

Comments
 (0)