Skip to content

Commit 44cef3e

Browse files
committed
Cleanup some TODOs
1 parent 1697ada commit 44cef3e

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/librustdoc/clean/mod.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,6 @@ impl Clean<Vec<Item>> for hir::Item<'_> {
242242
let def_id = cx.tcx.hir().local_def_id(self.hir_id).to_def_id();
243243
let name = cx.tcx.item_name(def_id).clean(cx);
244244
let maybe_inlined = match self.kind {
245-
// TODO: should store Symbol, not String
246245
ItemKind::ExternCrate(renamed) => clean_extern_crate(self, renamed, cx),
247246
ItemKind::Use(path, kind) => clean_import(self, path, kind, cx),
248247
ItemKind::Static(ty, mutability, body_id) => NotInlined(StaticItem(Static {
@@ -305,7 +304,7 @@ impl Clean<Vec<Item>> for hir::Item<'_> {
305304
generics: generics.clean(cx),
306305
bounds: bounds.clean(cx),
307306
is_spotlight,
308-
// TODO: this is redundant with `auto`
307+
// FIXME: this is redundant with `auto`
309308
is_auto: is_auto.clean(cx),
310309
}))
311310
}
@@ -321,8 +320,8 @@ impl Clean<Vec<Item>> for hir::Item<'_> {
321320
kind,
322321
name: Some(name),
323322
source: cx.tcx.def_span(def_id).clean(cx),
324-
attrs: self.attrs.clean(cx), // should this use tcx.attrs instead?
325-
visibility: self.vis.clean(cx), // TODO: use tcx.visibility once #78077 lands
323+
attrs: self.attrs.clean(cx), // TODO: should this use tcx.attrs instead?
324+
visibility: self.vis.clean(cx), // TODO: should this use tcx.visibility instead?
326325
stability: cx.tcx.lookup_stability(def_id).copied(),
327326
deprecation: cx.tcx.lookup_deprecation(def_id).clean(cx),
328327
};
@@ -2268,7 +2267,7 @@ impl Clean<Item> for hir::MacroDef<'_> {
22682267
let matchers = tts.chunks(4).map(|arm| arm[0].span());
22692268

22702269
Item {
2271-
name: Some(self.ident.name.to_string()), // TODO: this should store a Symbol
2270+
name: Some(self.ident.name.to_string()),
22722271
attrs: self.attrs.clean(cx),
22732272
source: self.span.clean(cx),
22742273
visibility: Public,

0 commit comments

Comments
 (0)