Skip to content

Commit 47cb89b

Browse files
blake2-ppcemberian
authored andcommitted
---
yaml --- r: 143742 b: refs/heads/try2 c: 4ab05f9 h: refs/heads/master v: v3
1 parent 7c7fced commit 47cb89b

File tree

2 files changed

+6
-22
lines changed

2 files changed

+6
-22
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ refs/heads/snap-stage3: 78a7676898d9f80ab540c6df5d4c9ce35bb50463
55
refs/heads/try: 519addf6277dbafccbb4159db4b710c37eaa2ec5
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
8-
refs/heads/try2: 240f8f03c9da7e574fd0fce0eb72e6ade97628ff
8+
refs/heads/try2: 4ab05f91f49b1248aab7d21630cfb38d6dafacfa
99
refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
1010
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
1111
refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try2/src/libextra/treemap.rs

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -42,39 +42,23 @@ pub struct TreeMap<K, V> {
4242

4343
impl<K: Eq + TotalOrd, V: Eq> Eq for TreeMap<K, V> {
4444
fn eq(&self, other: &TreeMap<K, V>) -> bool {
45-
if self.len() != other.len() {
46-
false
47-
} else {
48-
let mut x = self.iter();
49-
let mut y = other.iter();
50-
for _ in range(0u, self.len()) {
51-
if x.next().unwrap() != y.next().unwrap() {
52-
return false
53-
}
54-
}
55-
true
56-
}
45+
self.len() == other.len() &&
46+
self.iter().zip(other.iter()).all(|(a, b)| a == b)
5747
}
58-
fn ne(&self, other: &TreeMap<K, V>) -> bool { !self.eq(other) }
5948
}
6049

6150
// Lexicographical comparison
6251
fn lt<K: Ord + TotalOrd, V: Ord>(a: &TreeMap<K, V>,
6352
b: &TreeMap<K, V>) -> bool {
64-
let mut x = a.iter();
65-
let mut y = b.iter();
66-
67-
let (a_len, b_len) = (a.len(), b.len());
68-
for _ in range(0u, num::min(a_len, b_len)) {
69-
let (key_a, value_a) = x.next().unwrap();
70-
let (key_b, value_b) = y.next().unwrap();
53+
// the Zip iterator is as long as the shortest of a and b.
54+
for ((key_a, value_a), (key_b, value_b)) in a.iter().zip(b.iter()) {
7155
if *key_a < *key_b { return true; }
7256
if *key_a > *key_b { return false; }
7357
if *value_a < *value_b { return true; }
7458
if *value_a > *value_b { return false; }
7559
}
7660

77-
a_len < b_len
61+
a.len() < b.len()
7862
}
7963

8064
impl<K: Ord + TotalOrd, V: Ord> Ord for TreeMap<K, V> {

0 commit comments

Comments
 (0)