Run test functions in isolated tasks. Issue #428

Each test is run in its own task so that the failure can be trapped and the
test runner can continue. The easiest way to get the test functions into tasks
currently is by treating them as unsafe pointers.

Author: brson

src/lib/test.rs

@@ -212,13 +212,32 @@ fn filter_tests(&test_opts opts, &test_desc[] tests) -> test_desc[] {
 
 fn run_test(&test_desc test) -> test_result {
     if (!test.ignore) {
-        test.fn();
-        ret tr_ok;
+        if (run_test_fn_in_task(test.fn)) {
+            ret tr_ok;
+        } else {
+            ret tr_failed;
+        }
     } else {
         ret tr_ignored;
     }
 }
 
+// We need to run our tests in another task in order to trap test failures.
+// But, at least currently, functions can't be used as spawn arguments so
+// we've got to treat our test functions as unsafe pointers.
+fn run_test_fn_in_task(&fn() f) -> bool {
+    fn run_task(*mutable fn() fptr) {
+        task::unsupervise();
+        (*fptr)()
+    }
+    auto fptr = ptr::addr_of(f);
+    auto test_task = spawn run_task(fptr);
+    ret alt (task::join(test_task)) {
+        task::tr_success { true }
+        task::tr_failure { false }
+    }
+}
+
 
 // Local Variables:
 // mode: rust;