Skip to content

Commit 4aaef72

Browse files
authored
Merge pull request #3186 from flip1995/pedantic_filter_map
Fix pedantic filter_map warnings
2 parents 582ab5a + f49f133 commit 4aaef72

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

clippy_lints/src/inherent_impl.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,11 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
7878
let mut impl_spans = impls
7979
.iter()
8080
.filter_map(|impl_def| self.impls.get(impl_def))
81-
.filter(|(_, generics)| generics.params.len() == 0)
82-
.map(|(span, _)| span);
81+
.filter_map(|(span, generics)| if generics.params.len() == 0 {
82+
Some(span)
83+
} else {
84+
None
85+
});
8386
if let Some(initial_span) = impl_spans.nth(0) {
8487
impl_spans.for_each(|additional_span| {
8588
span_lint_and_then(

src/driver.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,11 @@ pub fn main() {
7878
args.extend(
7979
extra_args
8080
.split("__CLIPPY_HACKERY__")
81-
.filter(|s| !s.is_empty())
82-
.map(str::to_owned),
81+
.filter_map(|s| if s.is_empty() {
82+
None
83+
} else {
84+
Some(s.to_string())
85+
})
8386
);
8487
}
8588
}

0 commit comments

Comments
 (0)