Skip to content

Commit 4d6dde7

Browse files
committed
libsyntax: De-@mut SCTable::mark_memo
1 parent be17a1b commit 4d6dde7

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/libsyntax/ast.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ pub type SyntaxContext = u32;
8989
// it should cut down on memory use *a lot*; applying a mark
9090
// to a tree containing 50 identifiers would otherwise generate
9191
pub struct SCTable {
92-
table : RefCell<~[SyntaxContext_]>,
93-
mark_memo : HashMap<(SyntaxContext,Mrk),SyntaxContext>,
94-
rename_memo : HashMap<(SyntaxContext,Ident,Name),SyntaxContext>
92+
table: RefCell<~[SyntaxContext_]>,
93+
mark_memo: RefCell<HashMap<(SyntaxContext,Mrk),SyntaxContext>>,
94+
rename_memo: HashMap<(SyntaxContext,Ident,Name),SyntaxContext>
9595
}
9696

9797
// NB: these must be placed in any SCTable...

src/libsyntax/ast_util.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -717,17 +717,18 @@ pub fn new_mark_internal(m:Mrk, tail:SyntaxContext,table:&mut SCTable)
717717
// flow-sensitivity. Results in two lookups on a hash table hit.
718718
// also applies to new_rename_internal, below.
719719
// let try_lookup = table.mark_memo.find(&key);
720-
match table.mark_memo.contains_key(&key) {
720+
let mut mark_memo = table.mark_memo.borrow_mut();
721+
match mark_memo.get().contains_key(&key) {
721722
false => {
722723
let new_idx = {
723724
let mut table = table.table.borrow_mut();
724725
idx_push(table.get(), Mark(m,tail))
725726
};
726-
table.mark_memo.insert(key,new_idx);
727+
mark_memo.get().insert(key,new_idx);
727728
new_idx
728729
}
729730
true => {
730-
match table.mark_memo.find(&key) {
731+
match mark_memo.get().find(&key) {
731732
None => fail!("internal error: key disappeared 2013042901"),
732733
Some(idxptr) => {*idxptr}
733734
}
@@ -771,7 +772,7 @@ pub fn new_rename_internal(id:Ident, to:Name, tail:SyntaxContext, table: &mut SC
771772
pub fn new_sctable_internal() -> SCTable {
772773
SCTable {
773774
table: RefCell::new(~[EmptyCtxt,IllegalCtxt]),
774-
mark_memo: HashMap::new(),
775+
mark_memo: RefCell::new(HashMap::new()),
775776
rename_memo: HashMap::new()
776777
}
777778
}

0 commit comments

Comments
 (0)