Skip to content

Commit 4dab48e

Browse files
nikomatsakisalexcrichton
authored andcommitted
---
yaml --- r: 184051 b: refs/heads/auto c: 63f51ee h: refs/heads/master i: 184049: 80629f1 184047: 03c2190 v: v3
1 parent ef4423a commit 4dab48e

File tree

3 files changed

+34
-5
lines changed

3 files changed

+34
-5
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503
1010
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
1111
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1212
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
13-
refs/heads/auto: d6e939a2df16338e9cf63ad19d1025a15069387c
13+
refs/heads/auto: 63f51ee90ccc1b7ab3a749ba7dbd4a3c76961c16
1414
refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
1515
refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
1616
refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

branches/auto/src/librustc/middle/traits/object_safety.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,11 @@ fn supertraits_reference_self<'tcx>(tcx: &ty::ctxt<'tcx>,
138138
match predicate {
139139
ty::Predicate::Trait(ref data) => {
140140
// In the case of a trait predicate, we can skip the "self" type.
141-
data.0.trait_ref.substs.types.get_slice(TypeSpace)
142-
.iter()
143-
.cloned()
144-
.any(is_self)
141+
Some(data.def_id()) != tcx.lang_items.phantom_fn() &&
142+
data.0.trait_ref.substs.types.get_slice(TypeSpace)
143+
.iter()
144+
.cloned()
145+
.any(is_self)
145146
}
146147
ty::Predicate::Projection(..) |
147148
ty::Predicate::TypeOutlives(..) |
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
// Check that `Self` appearing in a phantom fn does not make a trait not object safe.
12+
13+
#![feature(rustc_attrs)]
14+
15+
trait Baz : PhantomFn<Self> {
16+
}
17+
18+
fn make_bar<T:Bar<u32>>(t: &T) -> &Bar<u32> {
19+
t
20+
}
21+
22+
fn make_baz<T:Baz>(t: &T) -> &Baz {
23+
t
24+
}
25+
26+
#[rustc_error]
27+
fn main() { //~ ERROR compilation successful
28+
}

0 commit comments

Comments
 (0)