Skip to content

Commit 518e2d2

Browse files
committed
build: Disable valgrind by default on the Mac. Our suppressions file doesn't even begin to cover the huge stream of errors that dyld generates.
1 parent 883eb38 commit 518e2d2

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

Makefile.in

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ ifdef CFG_DISABLE_VALGRIND
4646
$(info cfg: disabling valgrind (CFG_DISABLE_VALGRIND))
4747
CFG_VALGRIND :=
4848
endif
49+
ifdef CFG_BAD_VALGRIND
50+
$(info cfg: disabling valgrind due to its unreliability on this platform)
51+
CFG_VALGRIND :=
52+
endif
4953

5054
DOCS :=
5155
ifeq ($(CFG_MAKEINFO),)

configure

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,15 @@ probe CFG_MAKEINFO makeinfo
201201
probe CFG_TEXI2PDF texi2pdf
202202
probe CFG_TEX tex
203203

204+
# Valgrind is only reliable on Linux. On Windows it doesn't work at all, and
205+
# on the Mac the dynamic linker causes Valgrind to emit a huge stream of
206+
# errors.
207+
if [ $CFG_OSTYPE != Linux ]
208+
then
209+
CFG_BAD_VALGRIND=1
210+
putvar CFG_BAD_VALGRIND
211+
fi
212+
204213
if [ ! -z "$CFG_LLVM_ROOT" ]
205214
then
206215
CFG_LLVM_INCDIR="$CFG_LLVM_ROOT/include"

0 commit comments

Comments
 (0)