---

yaml
---
r: 224253
b: refs/heads/beta
c: ee43920
h: refs/heads/master
i:
  224251: 3c71cec
v: v3

Author: jroesch

[refs]

@@ -23,7 +23,7 @@ refs/tags/0.9: 36870b185fc5f5486636d4515f0e22677493f225
 refs/tags/0.10: ac33f2b15782272ae348dbd7b14b8257b2148b5a
 refs/tags/0.11.0: e1247cb1d0d681be034adb4b558b5a0c0d5720f9
 refs/tags/0.12.0: f0c419429ef30723ceaf6b42f9b5a2aeb5d2e2d1
-refs/heads/beta: e85787102fa6a7b27e1df845c07084f6a7d77fe3
+refs/heads/beta: ee4392041073795f479365f34d40777eff69c378
 refs/tags/1.0.0-alpha: e42bd6d93a1d3433c486200587f8f9e12590a4d7
 refs/heads/tmp: 938f5d7af401e2d8238522fed4a612943b6e77fd
 refs/tags/1.0.0-alpha.2: 4c705f6bc559886632d3871b04f58aab093bfa2f

branches/beta/src/librustc/middle/infer/mod.rs

@@ -73,7 +73,7 @@ pub struct InferCtxt<'a, 'tcx: 'a> {
     // We instantiate UnificationTable with bounds<Ty> because the
     // types that might instantiate a general type variable have an
     // order, represented by its upper and lower bounds.
-    pub type_variables: RefCell<type_variable::TypeVariableTable<'tcx>>,
+    type_variables: RefCell<type_variable::TypeVariableTable<'tcx>>,
 
     // Map from integral variable to the kind of integer it represents
     int_unification_table: RefCell<UnificationTable<ty::IntVid>>,
@@ -1366,19 +1366,19 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
     }
 
     pub fn report_conflicting_default_types(&self,
-                                   span: Span,
-                                   expected: type_variable::Default<'tcx>,
-                                   actual: type_variable::Default<'tcx>) {
+                                            span: Span,
+                                            expected: type_variable::Default<'tcx>,
+                                            actual: type_variable::Default<'tcx>) {
         let trace = TypeTrace {
             origin: Misc(span),
-            values: Types(ty::expected_found {
+            values: Types(ty::ExpectedFound {
                 expected: expected.ty,
                 found: actual.ty
             })
         };
 
         self.report_and_explain_type_error(trace,
-            &ty::type_err::terr_ty_param_default_mismatch(ty::expected_found {
+            &TypeError::TyParamDefaultMismatch(ty::ExpectedFound {
                 expected: expected,
                 found: actual
         }));

branches/beta/src/librustc/middle/ty.rs

@@ -2039,7 +2039,7 @@ pub struct ExpectedFound<T> {
 }
 
 // Data structures used in type unification
-#[derive(Clone, Copy, Debug)]
+#[derive(Clone, Debug)]
 pub enum TypeError<'tcx> {
     Mismatch,
     UnsafetyMismatch(ExpectedFound<ast::Unsafety>),
@@ -2069,7 +2069,7 @@ pub enum TypeError<'tcx> {
     ConvergenceMismatch(ExpectedFound<bool>),
     ProjectionNameMismatched(ExpectedFound<ast::Name>),
     ProjectionBoundsLength(ExpectedFound<usize>),
-    TyParamDefaultMismatch(ExpectedFound<Ty<'tcx>>)
+    TyParamDefaultMismatch(ExpectedFound<type_variable::Default<'tcx>>)
 }
 
 /// Bounds suitable for an existentially quantified type parameter
@@ -5083,7 +5083,7 @@ impl<'tcx> fmt::Display for TypeError<'tcx> {
                        values.expected,
                        values.found)
             },
-            terr_ty_param_default_mismatch(ref values) => {
+            TyParamDefaultMismatch(ref values) => {
                 write!(f, "conflicting type parameter defaults {} and {}",
                        values.expected.ty,
                        values.found.ty)
@@ -5445,7 +5445,7 @@ impl<'tcx> ctxt<'tcx> {
                                   using it as a trait object"));
                 }
             },
-            terr_ty_param_default_mismatch(values) => {
+            TyParamDefaultMismatch(values) => {
                 let expected = values.expected;
                 let found = values.found;
                 self.sess.span_note(sp,

branches/beta/src/librustc_typeck/check/mod.rs

@@ -1785,7 +1785,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
             // it had been solved by previously applying a default.
 
             // We take a snapshot for use in error reporting.
-            let snapshot = self.infcx().type_variables.borrow_mut().snapshot();
+            let snapshot = self.infcx().start_snapshot();
 
             for ty in &unbound_tyvars {
                 if self.infcx().type_var_diverges(ty) {
@@ -1815,10 +1815,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                 }
             }
 
-            // There were some errors to report
+            // There are some errors to report
             if conflicts.len() > 0 {
-                self.infcx().type_variables.borrow_mut().rollback_to(snapshot);
+                self.infcx().rollback_to(snapshot);
 
+                // Loop through each conflicting default compute the conflict
+                // and then report the error.
                 for (conflict, default) in conflicts {
                     let conflicting_default =
                         self.find_conflicting_default(
@@ -1836,7 +1838,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                                 default)
                 }
             } else {
-                self.infcx().type_variables.borrow_mut().commit(snapshot)
+                self.infcx().commit_from(snapshot)
             }
         }