Added note about the usage of clippy_utils::path

xFrednet · xFrednet · commit 540515220d84 · 2021-11-04T13:27:08.000+01:00
diff --git a/doc/common_tools_writing_lints.md b/doc/common_tools_writing_lints.md
@@ -105,6 +105,7 @@ impl LateLintPass<'_> for MyStructLint {
         }
 
         // 3. Using the type path
+        // This method should be avoided if possible
         if match_def_path(cx, def_id, &paths::RESULT) {
             // The type is a `core::result::Result`
         }
@@ -142,6 +143,7 @@ impl LateLintPass<'_> for MyStructLint {
 
         // 3. Using the type path with the expression
         // we use `match_trait_method` function from Clippy's utils
+        // (This method should be avoided if possible)
         if match_trait_method(cx, expr, &paths::INTO) {
             // `expr` implements `Into` trait
         }

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,7 @@ impl LateLintPass<'_> for MyStructLint {`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`// 3. Using the type path`
	`108`	`+ // This method should be avoided if possible`
`108`	`109`	`if match_def_path(cx, def_id, &paths::RESULT) {`
`109`	`110`	// The type is a `core::result::Result`
`110`	`111`	`}`
`@@ -142,6 +143,7 @@ impl LateLintPass<'_> for MyStructLint {`
`142`	`143`
`143`	`144`	`// 3. Using the type path with the expression`
`144`	`145`	// we use `match_trait_method` function from Clippy's utils
	`146`	`+ // (This method should be avoided if possible)`
`145`	`147`	`if match_trait_method(cx, expr, &paths::INTO) {`
`146`	`148`	// `expr` implements `Into` trait
`147`	`149`	`}`