Skip to content

Commit 54eec5c

Browse files
---
yaml --- r: 23487 b: refs/heads/master c: bdbedb9 h: refs/heads/master i: 23485: bf061b8 23483: 96fe387 23479: 7f29815 23471: ecf354f 23455: 5860b78 23423: b499a73 v: v3
1 parent 81e1233 commit 54eec5c

File tree

2 files changed

+57
-7
lines changed

2 files changed

+57
-7
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 6277046fa0a5c119885ba33bcb6ac2f4fba0228f
2+
refs/heads/master: bdbedb9d35903be0e3f587c603db49c014ef7d9f
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: cd6f24f9d14ac90d167386a56e7a6ac1f0318195
55
refs/heads/try: ffbe0e0e00374358b789b0037bcb3a577cd218be

trunk/src/rustc/middle/resolve3.rs

Lines changed: 56 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4069,6 +4069,47 @@ struct Resolver {
40694069
}
40704070
}
40714071
4072+
fn name_exists_in_scope_class(name: &str) -> bool {
4073+
let mut i = self.type_ribs.len();
4074+
while i != 0 {
4075+
i -= 1;
4076+
let rib = self.type_ribs.get_elt(i);
4077+
match rib.kind {
4078+
MethodRibKind(node_id, _) =>
4079+
for vec::each(self.crate.node.module.items) |item| {
4080+
if item.id == node_id {
4081+
match item.node {
4082+
item_class(class_def, _) => {
4083+
for vec::each(class_def.fields) |field| {
4084+
match field.node.kind {
4085+
syntax::ast::unnamed_field
4086+
=> {},
4087+
syntax::ast::named_field(ident, _, _)
4088+
=> {
4089+
if str::eq_slice(self.session.str_of(ident),
4090+
name) {
4091+
return true
4092+
}
4093+
}
4094+
}
4095+
}
4096+
for vec::each(class_def.methods) |method| {
4097+
if str::eq_slice(self.session.str_of(method.ident),
4098+
name) {
4099+
return true
4100+
}
4101+
}
4102+
}
4103+
_ => {}
4104+
}
4105+
}
4106+
},
4107+
_ => {}
4108+
}
4109+
}
4110+
return false;
4111+
}
4112+
40724113
fn resolve_expr(expr: @expr, visitor: ResolveVisitor) {
40734114
// First, record candidate traits for this expression if it could
40744115
// result in the invocation of a method call.
@@ -4093,12 +4134,21 @@ struct Resolver {
40934134
self.record_def(expr.id, def);
40944135
}
40954136
none => {
4096-
self.session.span_err(
4097-
expr.span,
4098-
fmt!("unresolved name: %s",
4099-
connect(path.idents.map(
4100-
|x| self.session.str_of(x)),
4101-
~"::")));
4137+
let wrong_name =
4138+
connect(path.idents.map(
4139+
|x| self.session.str_of(x)), ~"::") ;
4140+
if self.name_exists_in_scope_class(wrong_name) {
4141+
self.session.span_err(expr.span,
4142+
fmt!("unresolved name: %s. \
4143+
Did you mean: self.%s",
4144+
wrong_name,
4145+
wrong_name));
4146+
}
4147+
else {
4148+
self.session.span_err(expr.span,
4149+
fmt!("unresolved name: %s",
4150+
wrong_name));
4151+
}
41024152
}
41034153
}
41044154

0 commit comments

Comments
 (0)