---

yaml
---
r: 155437
b: refs/heads/try2
c: dcdbdc1
h: refs/heads/master
i:
  155435: eb0f1b4
v: v3

Author: sfackler

[refs]

@@ -5,7 +5,7 @@ refs/heads/snap-stage3: 78a7676898d9f80ab540c6df5d4c9ce35bb50463
 refs/heads/try: 519addf6277dbafccbb4159db4b710c37eaa2ec5
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
-refs/heads/try2: 65cca7c8b14e9c5673af4921a57c2ccbac3fc2cb
+refs/heads/try2: dcdbdc10036b444ef39c329e9440d4acc6975fda
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try2/src/libsyntax/ext/base.rs

@@ -440,7 +440,7 @@ fn initial_syntax_expander_table() -> SyntaxEnv {
                             builtin_normal_expander(
                                     ext::cfg::expand_cfg));
     syntax_expanders.insert(intern("cfg_attr"),
-                            ItemModifier(ext::cfg_attr::expand));
+                            Modifier(box ext::cfg_attr::expand));
     syntax_expanders.insert(intern("trace_macros"),
                             builtin_normal_expander(
                                     ext::trace_macros::expand_trace_macros));

branches/try2/src/libsyntax/ext/cfg_attr.rs

@@ -8,45 +8,43 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use std::gc::{Gc, GC};
-
 use ast;
 use attr;
 use codemap::Span;
 use ext::base::ExtCtxt;
 use ext::build::AstBuilder;
+use ptr::P;
 
-pub fn expand(cx: &mut ExtCtxt, sp: Span, mi: Gc<ast::MetaItem>, it: Gc<ast::Item>)
-          -> Gc<ast::Item> {
+pub fn expand(cx: &mut ExtCtxt, sp: Span, mi: &ast::MetaItem, it: P<ast::Item>) -> P<ast::Item> {
     let (cfg, attr) = match mi.node {
-        ast::MetaList(_, ref mis) if mis.len() == 2 => (mis[0], mis[1]),
+        ast::MetaList(_, ref mis) if mis.len() == 2 => (&mis[0], &mis[1]),
         _ => {
             cx.span_err(sp, "expected `#[cfg_attr(<cfg pattern>, <attr>)]`");
             return it;
         }
     };
 
     let mut out = (*it).clone();
-    if cfg_matches(cx, cfg) {
-        out.attrs.push(cx.attribute(attr.span, attr));
+    if cfg_matches(cx, &**cfg) {
+        out.attrs.push(cx.attribute(attr.span, attr.clone()));
     }
 
-    box(GC) out
+    P(out)
 }
 
-fn cfg_matches(cx: &mut ExtCtxt, cfg: Gc<ast::MetaItem>) -> bool {
+fn cfg_matches(cx: &mut ExtCtxt, cfg: &ast::MetaItem) -> bool {
     match cfg.node {
         ast::MetaList(ref pred, ref mis) if pred.get() == "any" =>
-            mis.iter().any(|mi| cfg_matches(cx, *mi)),
+            mis.iter().any(|mi| cfg_matches(cx, &**mi)),
         ast::MetaList(ref pred, ref mis) if pred.get() == "all" =>
-            mis.iter().all(|mi| cfg_matches(cx, *mi)),
+            mis.iter().all(|mi| cfg_matches(cx, &**mi)),
         ast::MetaList(ref pred, ref mis) if pred.get() == "not" => {
             if mis.len() != 1 {
                 cx.span_err(cfg.span, format!("expected 1 value, got {}",
                                               mis.len()).as_slice());
                 return false;
             }
-            !cfg_matches(cx, mis[0])
+            !cfg_matches(cx, &*mis[0])
         }
         ast::MetaList(ref pred, _) => {
             cx.span_err(cfg.span,

branches/try2/src/libsyntax/test.rs

@@ -340,7 +340,7 @@ fn is_ignored(cx: &TestCtxt, i: &ast::Item) -> bool {
         attr.check_name("ignore") && match attr.meta_item_list() {
             Some(ref cfgs) => {
                 if cfgs.iter().any(|cfg| cfg.check_name("cfg")) {
-                    cx.sess.span_warn(attr.span,
+                    cx.span_diagnostic.span_warn(attr.span,
                             "The use of cfg filters in #[ignore] is \
                              deprecated. Use #[cfg_attr(<cfg pattern>, \
                              ignore)] instead.");